Unidentified issue with "set_fault_relation" #1075
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TION" is based on the model from tutorial ch1_5, where this did not work. For the video tutorial model, set fault relations does work.
Member
|
it is failing the new test looking for the data. I will look into it venv/lib/python3.13/site-packages/pandas/io/common.py:873: FileNotFoundError |
Leguark
reviewed
Dec 5, 2025
| j = self.structural_groups.index(fault_group) | ||
| if j <= i: # Only consider groups that are | ||
| raise ValueError(f"Fault {group.name} cannot affect older fault {fault_group.name}") | ||
| fault_relations[i, j] = True |
Member
There was a problem hiding this comment.
This line of code was removed in 2023 when I added the next case and no test was picking it up thanks you Nils. Great catch!
Leguark
previously approved these changes
Dec 5, 2025
Member
Leguark
left a comment
Leguark
left a comment
There was a problem hiding this comment.
Thank you for finding such a huge bug and provide the a test for it!
Leguark
dismissed
their stale review
my changes are breaking other functions looking into it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In example "ch1_5", function set_fault_relation does not work as intended as described in issue #1074. I tried this in some other models, where the behaviour is still off. This is a WIP, where I turned the model from ch1_5 into a test. For this model it works.
I am willingt to try myself, @Leguark, but I spent quite some time in it already and am a bit out of ideas.
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).