yaml-language-server integration

[davidjharder]

We now have yaml-language-server installable. Let's integrate it into our package.yml workflows:

• Mass add the language server header to the package.ymls [NFC] repo-wide: Add inlined schema to all package.yml files #7195
• Find a mass lint tool that will match formatting produced by yaml-language-server and ybump output (ref https://github.com/getsolus/ypkg/pull/122/files ), merge the ybump PR
  • Joey suggests yq -i package.yml -I 4
• Mass lint the package.ymls to fix colon spacing
• Add yaml linter to CI workflows

[davidjharder]

cc @silkeh

[davidjharder]

Initial testing notes, will link to my cleaned up diffs eventually

• If the LSP encounters double quotes on a string, like version, it converts them to single quotes, ybump doesn't care. ✔️ Additional commentary: The schema throws a warning if the version string is not quoted
• The schema throws a few false positives: emul32 not allowed as a component (1), devel not allowed as a key (2), optimize should be an array (correct)

---

• (1) schema.json: Add 'emul32' as a component ypkg#132
• (2) schema.json: Add 'devel' field ypkg#133

[davidjharder]

• Discovered YSL uses prettier to do the yaml formatting: https://github.com/redhat-developer/yaml-language-server/blob/f03324a3a81c1a32b153b61dea685308865b5dac/src/languageservice/services/yamlFormatter.ts#L47
• If I format some test package.ymls with prettier first, then see what ybump does, there is disagreement over indent for nested lists: Try prettier formatting #7255
• I think this is related: Yaml indentation duplicated at nested sequences prettier/prettier#6043

[davidjharder]

I think I have successfully tweaked ypkg to match Prettier's output at 4-space indent

• Tweaked ypkg Match prettier formatting ypkg#134
• Testing Try Prettier formatting, again #7263

[davidjharder]

YAML formatting nits that require an opinion:

• Quotes around version string. We currently mix double, single, and no quotes. Single quotes seem to be the most stable option, but is not default for some yaml formatters

• Single item array keys. Common example is optimize We should probably prefer

optimize   : 
    - thin-lto