Skip to content

chore: bump min starlette version to patch vulnerabilities #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarlzRana wants to merge 1 commit into from
+2 −2
Closed

chore: bump min starlette version to patch vulnerabilities #3796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies = [
"anyio>=4.9.0, <5.0.0", # For MCP Session Manager
"authlib>=1.5.1, <2.0.0", # For RestAPI Tool
"click>=8.1.8, <9.0.0", # For CLI tools
"fastapi>=0.115.0, <0.119.0", # FastAPI framework
"fastapi>=0.120.1, <0.123.5", # FastAPI framework
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the lower bound bump for fastapi is well-justified, the upper bound <0.123.5 seems a bit arbitrary. For consistency and better readability, consider using a rounder upper bound like <0.124.0. If there's a specific reason to avoid versions >=0.123.5, it would be helpful to add a comment explaining it.

Suggested change
"fastapi>=0.120.1, <0.123.5", # FastAPI framework
"fastapi>=0.120.1, <0.124.0", # FastAPI framework

Copy link
Contributor Author

@MarlzRana MarlzRana Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.123.5 is the latest version :)

"google-api-python-client>=2.157.0, <3.0.0", # Google API client discovery
"google-cloud-aiplatform[agent_engines]>=1.125.0, <2.0.0", # For VertexAI integrations, e.g. example store.
"google-cloud-bigquery-storage>=2.0.0",
Expand Down Expand Up @@ -59,7 +59,7 @@ dependencies = [
"requests>=2.32.4, <3.0.0",
"sqlalchemy-spanner>=1.14.0", # Spanner database session service
"sqlalchemy>=2.0, <3.0.0", # SQL database ORM
"starlette>=0.46.2, <1.0.0", # For FastAPI CLI
"starlette>=0.49.1, <1.0.0", # For FastAPI CLI
"tenacity>=9.0.0, <10.0.0", # For Retry management
"typing-extensions>=4.5, <5",
"tzlocal>=5.3, <6.0", # Time zone utilities
Expand Down