Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

This PR cleans up the .github/release-please.yml file by removing redundant options and the bump-minor-pre-major setting for major releases.

- Remove redundant options already declared at the top level.\n- Remove bumpMinorPreMajor for repositories after the first major release.
@diegomarquezp diegomarquezp requested review from a team as code owners December 5, 2025 16:27
@gemini-code-assist
Copy link

Summary of Changes

Hello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the .github/release-please.yml configuration file. The primary goal is to enhance clarity and maintainability by eliminating duplicated settings and adjusting the default behavior for major releases. These changes streamline the release automation setup without altering the core functionality of the release process, making the configuration more concise and efficient.

Highlights

  • Configuration Cleanup: Redundant releaseType: java-yoshi and handleGHRelease: true options have been removed from individual branch configurations within .github/release-please.yml, as these settings were already defined at the top level.
  • Release Strategy Adjustment: The bumpMinorPreMajor: true setting has been removed from the global release-please configuration and most branch-specific configurations. This change modifies the release process to no longer automatically bump minor versions before a major release.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 5, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively cleans up the .github/release-please.yml configuration by removing redundant settings from individual branch configurations. The changes make the file more concise and maintainable by correctly inheriting global settings. The implementation is correct and well-implemented. As a suggestion for a future cleanup, you might also consider removing the top-level bumpMinorPreMajor: true setting. This option is intended for pre-1.0 releases (major version 0) and appears to have no effect on the versions used in this repository (e.g., 3.x, 4.x), so removing it could further simplify the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant