From 894371e61e46a77a407d14ac2c5dee32884815b2 Mon Sep 17 00:00:00 2001 From: Chandra Sirimala Date: Wed, 10 Dec 2025 17:58:14 +0000 Subject: [PATCH] fix: close write object stream always --- .../_experimental/asyncio/async_appendable_object_writer.py | 3 ++- tests/unit/asyncio/test_async_appendable_object_writer.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/google/cloud/storage/_experimental/asyncio/async_appendable_object_writer.py b/google/cloud/storage/_experimental/asyncio/async_appendable_object_writer.py index d34c844d5..81dfacd6d 100644 --- a/google/cloud/storage/_experimental/asyncio/async_appendable_object_writer.py +++ b/google/cloud/storage/_experimental/asyncio/async_appendable_object_writer.py @@ -267,7 +267,8 @@ async def close(self, finalize_on_close=False) -> Union[int, _storage_v2.Object] await self.finalize() else: await self.flush() - await self.write_obj_stream.close() + + await self.write_obj_stream.close() self._is_stream_open = False self.offset = None diff --git a/tests/unit/asyncio/test_async_appendable_object_writer.py b/tests/unit/asyncio/test_async_appendable_object_writer.py index a75824f8b..a26726f2a 100644 --- a/tests/unit/asyncio/test_async_appendable_object_writer.py +++ b/tests/unit/asyncio/test_async_appendable_object_writer.py @@ -313,7 +313,7 @@ async def test_finalize_on_close(mock_write_object_stream, mock_client): result = await writer.close(finalize_on_close=True) # Assert - mock_stream.close.assert_not_awaited() # Based on new implementation + mock_stream.close.assert_awaited_once() assert not writer._is_stream_open assert writer.offset is None assert writer.object_resource == mock_resource