Failed Firmware Uploads Aren't Caught

[harrisonhjones]

So I got the following curl response when I tried to upload a .cpp file. The current failure detection in the master curl function doesn't detect this as an error. We need to fix this:

{ "ok": false, "errors": [ { "ok": false, "output": "Compiler timed out or encountered an error", "errors": [] } ] }

[devinpearson]

Can you send me a copy of that .cpp file so I can replicate the issue

[harrisonhjones]

It was a slightly modified version of this: https://github.com/spark/firmware/blob/master/applications/tinker/application.cpp but it compiled on my local system.