diff --git a/.github/workflows/buf.yaml b/.github/workflows/buf.yaml index e7a20fff4..5b76d4a9d 100644 --- a/.github/workflows/buf.yaml +++ b/.github/workflows/buf.yaml @@ -42,7 +42,6 @@ jobs: steps: - uses: actions/checkout@v3 - uses: bufbuild/buf-setup-action@v1 -# TODO (arm-versioning): Arm versioning by removing the comments of the following lines -# - uses: bufbuild/buf-breaking-action@v1 -# with: -# against: 'https://github.com/${{ github.repository }}.git#branch=main' + - uses: bufbuild/buf-breaking-action@v1 + with: + against: 'https://github.com/${{ github.repository }}.git#branch=main' diff --git a/.github/workflows/publish-bufs.yaml b/.github/workflows/publish-bufs.yaml index ab82b4ff5..ff63a15a6 100644 --- a/.github/workflows/publish-bufs.yaml +++ b/.github/workflows/publish-bufs.yaml @@ -20,13 +20,11 @@ jobs: fetch-depth: 2 - uses: bufbuild/buf-setup-action@v1 - uses: bufbuild/buf-lint-action@v1 - # TODO (arm-versioning): Arm versioning by remove the comment of ONLY the next line - # - name: Check for illegal breakage + - name: Check for illegal breakage # Only deletions are allowed. Breaking updates must happen in a new version of the package(s) in question. # This is just a sanity check! # For example it allows you to delete files from the latest version of a package (depending on context that might even be ok). - # TODO (arm-versioning): Arm versioning by remove the comment of the next line - # run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi + run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi - name: Has breakage? id: breaking # We previously checked if any illegal breakage occurred, now check if we have breakage _at all_ @@ -52,8 +50,7 @@ jobs: run: | BUMP="patch" if [ "$BREAKING" = "true" ]; then - # TODO (arm-versioning): Arm versioning by replacing the following "minor" with "major" - BUMP="minor" + BUMP="major" elif [ "$NEW_PKG" = "true" ]; then BUMP="minor" else