closes #119 #123

Author: catmando

release-notes/1.0.alpha1.7.md

@@ -1,15 +1,14 @@
-## 1.0alpha1.7 - 2021-03-29
+## 1.0alpha1.7 - 2021-04-05
 
 | Release<br/>Date | Version | Open<br/>Issues | Documentation<br/>Sections<br/>Draft Ready | Documentation<br/>Sections<br/>WIP |
 |--------------|---------|-------------|-------|------|
-| April 5, 2021 | 1.0.alpha1.6 | 167 | 35 | 10 |
-
+| April 5, 2021 | 1.0.alpha1.7 | ??? | ?? | ?? |
+| March 29, 2021 | 1.0.alpha1.6 | 167 | 35 | 10 |
 > Open issues includes enhancements, documentation, and discussion issues as well as few bugs.
 >
 > The documentation WIP (work in progress) numbers are approx, as more sections may be added.
 
 ### New Major Features
-+
 
 
 ### Breaking Changes
@@ -25,6 +24,9 @@
 + [#399](https://github.com/hyperstack-org/hyperstack/issues/399) Pluck now takes multiple keys
 + [#358](https://github.com/hyperstack-org/hyperstack/issues/358) Fixed: (again) changing primary_key causes some failures
 + [#127](https://github.com/hyperstack-org/hyperstack/issues/127) Complex expressions work better in on_client (due to upgrade in Parser gem)
++ [#123](https://github.com/hyperstack-org/hyperstack/issues/123) `public_columns_hash` now thread safe.
++ [#119](https://github.com/hyperstack-org/hyperstack/issues/119) `destroy` now updates errors properly and will not mark the record as destroyed unless destroy was successful
+
 
 
 ### Not Reproducible

ruby/hyper-model/lib/reactive_record/active_record/reactive_record/isomorphic_base.rb

@@ -557,8 +557,14 @@ def destroy(&block)
         if !data_loading? && (id || vector)
           Operations::Destroy.run(model: ar_instance.model_name.to_s, id: id, vector: vector)
           .then do |response|
-            Broadcast.to_self ar_instance
-            @destroyed = true
+            #[reactive_record_id, model.class.name, attributes, messages] model.errors.messages
+
+            if response[:success]
+              @destroyed = true
+              Broadcast.to_self ar_instance
+            else
+              errors! response[:messages]
+            end
             yield response[:success], response[:message] if block
             promise.resolve response
           end
@@ -590,10 +596,9 @@ def self.destroy_record(model, id, vector, acting_user)
                    ServerDataCache.new(acting_user, {})[*vector].value
                  end
 
-        record.check_permission_with_acting_user(acting_user, :destroy_permitted?).destroy
-        { success: true, attributes: {} }
+        success = record.check_permission_with_acting_user(acting_user, :destroy_permitted?).destroy
+        { success: success, attributes: {}, messages: record.errors.messages }
       rescue Exception => e
-        # ReactiveRecord::Pry.rescued(e)
         { success: false, record: record, message: e }
       end
     end

ruby/hyper-model/spec/batch3/aaa_edge_cases_spec.rb

@@ -106,6 +106,28 @@ class TestComponent77 < HyperComponent
     end
   end
 
+  it "destroy receives any errors added by the server" do
+    class Todo < ActiveRecord::Base
+      before_destroy do
+        return true unless title == "don't destroy me"
+        errors.add :base, "Can't destroy me"
+        throw(:abort)
+      end
+    end
+    id = Todo.create(title: "don't destroy me").id
+    expect do
+      Hyperstack::Model.load do
+        @todo = Todo.find(id)
+      end.then do |todo|
+        todo.destroy.then do |response|
+          todo.errors.messages unless response[:success]
+        end
+      end
+    end.on_client_to eq("base" => ["Can't destroy me"])
+    expect { @todo.destroyed?}.on_client_to be_falsy
+  end
+
+
   it "the limit and offset predefined scopes work" do
     5.times do |i|
       FactoryBot.create(:todo, title: "Todo #{i}")
@@ -200,7 +222,7 @@ def synchromesh_after_create
         orig_synchromesh_after_create
       end
     end
-    
+
     has_many1 = HasManyModel.create(name: "has_many1")
     2.times { |i| BelongsToModel.create(name: "belongs_to_#{i}", has_many_model: has_many1) }
     expect { HasManyModel.first.belongs_to_models.count }.on_client_to eq(1)

ruby/hyper-model/spec/batch6/aaa_update_associations_spec.rb

@@ -135,16 +135,20 @@
     expect(TodoItem.find_by_title("Jon's first todo!").user.first_name).to eq('Jan')
   end
 
-  it "and a model in a belongs_to relationship can be deleted" do
-    expect_promise do
+  it "and a model in a belongs_to relationship can be destroyed" do
+    expect do
       ReactiveRecord.load do
         User.find_by_first_name("Jan").todo_items.collect { |item| item.itself }.first
       end.then do | first |
         first.destroy.then do |response|
           User.find_by_first_name("Jan").todo_items.all
-        end
+        end.tap { @was_destroyed_already = first.destroyed? }
       end
-    end.to be_empty
+    end.on_client_to
+    # added to check that issue #119 got fixed.  Item is not
+    # considered destroyed until we get the status back from server
+    # that it was destroyed
+    expect { @was_destroyed_already }.on_client_to be_falsy
   end
 
   it "will update the server properly" do