added naming_convention method, changed version to 1.0.rc1

catmando · catmando · commit d1a65d0c3317 · 2018-11-12T00:25:46.000-05:00
diff --git a/ruby/examples/misc/stock-tickers/Gemfile.lock b/ruby/examples/misc/stock-tickers/Gemfile.lock
@@ -1,9 +1,9 @@
 PATH
   remote: ../../../hyper-component
   specs:
-    hyper-component (0.1)
-      hyper-state (= 0.1)
-      hyperstack-config (= 0.1)
+    hyper-component (1.0.rc1)
+      hyper-state (= 1.0.rc1)
+      hyperstack-config (= 1.0.rc1)
       libv8 (~> 6.3.0)
       mini_racer (~> 0.1.15)
       opal (>= 0.11.0, < 0.12.0)
@@ -13,7 +13,7 @@ PATH
 PATH
   remote: ../../../hyper-spec
   specs:
-    hyper-spec (0.1)
+    hyper-spec (1.0.rc1)
       capybara
       chromedriver-helper (= 1.2.0)
       libv8 (~> 6.3.0)
@@ -32,20 +32,20 @@ PATH
 PATH
   remote: ../../../hyper-state
   specs:
-    hyper-state (0.1)
-      hyperstack-config (= 0.1)
+    hyper-state (1.0.rc1)
+      hyperstack-config (= 1.0.rc1)
       opal (>= 0.11.0, < 0.12.0)
 
 PATH
   remote: ../../../hyper-trace
   specs:
-    hyper-trace (0.1.0)
-      hyperstack-config (= 0.1.0)
+    hyper-trace (1.0.rc1)
+      hyperstack-config (= 1.0.rc1)
 
 PATH
   remote: ../../../hyperstack-config
   specs:
-    hyperstack-config (0.1)
+    hyperstack-config (1.0.rc1)
       libv8 (~> 6.3.0)
       listen (~> 3.0)
       mini_racer (~> 0.1.15)
diff --git a/ruby/examples/misc/stock-tickers/app/hyperstack/components/app.rb b/ruby/examples/misc/stock-tickers/app/hyperstack/components/app.rb
@@ -2,8 +2,8 @@ class App < HyperComponent
   before_mount { @symbols = Set.new }
 
   def add_symbol
-    mutate @symbols << @SymbolInput.value.upcase
-    @SymbolInput.value = ''
+    mutate @symbols << @_symbol_input.value.upcase
+    @_symbol_input.value = ''
   end
 
   render do
@@ -15,7 +15,7 @@ def add_symbol
       BS::Row(style: { marginTop: 20 }) do
         BS::Col(sm: 4) do
           BS::InputGroup(class: 'mb-3') do
-            BS::FormControl(dom: set(:SymbolInput), placeholder: 'New Stock Market Symbol')
+            BS::FormControl(dom: set(:_symbol_input), placeholder: 'New Stock Market Symbol')
             .on(:enter) { add_symbol }
             BS::InputGroup::Append() { BS::Button() { 'Add' } }
             .on(:click) { add_symbol }
diff --git a/ruby/examples/misc/stock-tickers/app/hyperstack/components/display_ticker.rb b/ruby/examples/misc/stock-tickers/app/hyperstack/components/display_ticker.rb
@@ -1,28 +1,28 @@
 class DisplayTicker < HyperComponent
   param    :symbol
   triggers :cancel
-  before_mount { @ticker = StockTicker.new(@Symbol, 10.seconds) }
+  before_mount { @_ticker = StockTicker.new(@_symbol, 10.seconds) }
 
   def status
-    case @ticker.status
+    case @_ticker.status
     when :loading
       BS::Col(sm: 10) { 'loading...' }
     when :success
       BS::Col(class: 'text-right', sm: 3) { 'price' }
-      BS::Col(class: 'text-right', sm: 3) { '%.2f' % @ticker.price }
-      BS::Col(sm: 4) { "at #{@ticker.time.strftime('%I:%M:%S')}" }
+      BS::Col(class: 'text-right', sm: 3) { '%.2f' % @_ticker.price }
+      BS::Col(sm: 4) { "at #{@_ticker.time.strftime('%I:%M:%S')}" }
     when :failed
-      BS::Col(sm: 10) { "failed to get quote: #{@ticker.reason}" }
+      BS::Col(sm: 10) { "failed to get quote: #{@_ticker.reason}" }
     end
   end
 
   render do
     BS::Row() do
-      BS::Col(sm: 1) { @Symbol.upcase }
+      BS::Col(sm: 1) { @_symbol.upcase }
       status
       BS::Col(sm: 1) do
         BS::Button(class: :close) { "\u00D7" }
-        .on(:click) { cancel! } unless @ticker.status == :loading
+        .on(:click) { cancel! } unless @_ticker.status == :loading
       end
     end
   end
diff --git a/ruby/examples/misc/stock-tickers/app/hyperstack/components/hyper_component.rb b/ruby/examples/misc/stock-tickers/app/hyperstack/components/hyper_component.rb
@@ -1,3 +1,13 @@
+module Hyperstack
+  module State
+    module Observable
+      def self.naming_convention
+        :prefix_params
+      end
+    end
+  end
+end
+
 class HyperComponent
   include Hyperstack::Component
   include Hyperstack::State::Observable
diff --git a/ruby/hyper-component/lib/hyperstack/component/version.rb b/ruby/hyper-component/lib/hyperstack/component/version.rb
@@ -1,5 +1,5 @@
 module Hyperstack
   module Component
-    VERSION = '0.1'
+    VERSION = '1.0.rc1' # '1.0.rc1'
   end
 end
diff --git a/ruby/hyper-component/lib/hyperstack/internal/component/props_wrapper.rb b/ruby/hyper-component/lib/hyperstack/internal/component/props_wrapper.rb
@@ -6,13 +6,19 @@ class PropsWrapper
         attr_reader :component
 
         class << self
-
           def instance_var_name_for(name)
-            name.camelize
+            case Hyperstack::State::Observable.naming_convention
+            when :camelize_params
+              name.camelize
+            when :prefix_params
+              "_#{name}"
+            else
+              name
+            end
           end
 
-          def param_accessor_style(*args)
-            @param_accessor_style = args[0] if args.length > 0
+          def param_accessor_style(style = nil)
+            @param_accessor_style = style if style
             @param_accessor_style ||=
               if superclass.respond_to? :param_accessor_style
                 superclass.param_accessor_style
diff --git a/ruby/hyper-i18n/lib/hyper-i18n/version.rb b/ruby/hyper-i18n/lib/hyper-i18n/version.rb
@@ -1,3 +1,3 @@
 module HyperI18n
-  VERSION = '0.1.0'
+  VERSION = '1.0.rc1'
 end
diff --git a/ruby/hyper-i18n/lib/hyperstack/i18n/version.rb b/ruby/hyper-i18n/lib/hyperstack/i18n/version.rb
@@ -1,5 +1,5 @@
 module Hyperstack
   module I18n
-    VERSION = '0.1.0'
+    VERSION = '1.0.rc1'
   end
 end
diff --git a/ruby/hyper-model/lib/hyper_model/version.rb b/ruby/hyper-model/lib/hyper_model/version.rb
@@ -1,3 +1,3 @@
 module HyperModel
-  VERSION = '0.1'
+  VERSION = '1.0.rc1'
 end
diff --git a/ruby/hyper-model/lib/reactive_record/active_record/reactive_record/isomorphic_base.rb b/ruby/hyper-model/lib/reactive_record/active_record/reactive_record/isomorphic_base.rb
@@ -308,7 +308,6 @@ def send_save_to_server(save, validate, force, &block)
           backing_records.each { |_id, record| record.saved!(true) rescue nil } if save
         end
       rescue Exception => e
-        debugger
         log("Exception raised while saving - #{e}", :error)
         yield false, e.message, [] if block
         promise.resolve({success: false, message: e.message, models: []})
diff --git a/ruby/hyper-operation/lib/hyper-operation/version.rb b/ruby/hyper-operation/lib/hyper-operation/version.rb
@@ -1,5 +1,5 @@
 module Hyperstack
   class Operation
-    VERSION = '0.1'
+    VERSION = '1.0.rc1'
   end
 end
diff --git a/ruby/hyper-router/lib/hyperstack/router/version.rb b/ruby/hyper-router/lib/hyperstack/router/version.rb
@@ -1,3 +1,3 @@
 module HyperRouter
-  VERSION = '0.1'
+  VERSION = '1.0.rc1'
 end
diff --git a/ruby/hyper-spec/lib/hyper-spec/version.rb b/ruby/hyper-spec/lib/hyper-spec/version.rb
@@ -1,3 +1,3 @@
 module HyperSpec
-  VERSION = '0.1'
+  VERSION = '1.0.rc1'
 end
diff --git a/ruby/hyper-state/lib/hyperstack/state/observable.rb b/ruby/hyper-state/lib/hyperstack/state/observable.rb
@@ -5,6 +5,10 @@ def self.bulk_update(&block)
         Internal::State::Mapper.bulk_update(&block)
       end
 
+      def self.naming_convention
+        :camelize_params
+      end
+
       def self.included(base)
         base.include Internal::AutoUnmount
         %i[singleton_method method].each do |kind|
@@ -24,16 +28,26 @@ def self.included(base)
           end
           if RUBY_ENGINE == 'opal'
             base.send(:"define_#{kind}", :set) do |var|
+              if Hyperstack::State::Observable.naming_convention == :prefix_state
+                var = "_#{var}" if var !~ /^_/
+              elsif var =~ /^[a-z]/
+                add_mutate = true
+              end
               lambda do |val|
                 `self[#{var}] = #{val}`
-                mutate if var =~ /^[a-z]/
+                mutate if add_mutate
               end
             end
           else
             base.send(:"define_#{kind}", :set) do |var|
+              if Hyperstack::State::Observable.naming_convention == :prefix_state
+                var = "_#{var}" if var !~ /^_/
+              elsif var =~ /^[a-z]/
+                add_mutate = true
+              end
               lambda do |val|
                 instance_variable_set(:"@#{var}", val)
-                mutate if var =~ /^[a-z]/
+                mutate if add_mutate
               end
             end
           end
@@ -53,15 +67,25 @@ def self.included(base)
           end
           base.singleton_class.send(:"define_#{kind}", :state_reader) do |*names|
             names.each do |name|
+              var_name = if Hyperstack::State::Observable.naming_convention == :prefix_state && name !~ /^_/
+                           "_#{name}"
+                         else
+                           name
+                         end
               define_method(name) do
-                instance_variable_get(:"@#{name}").tap { Internal::State::Mapper.observed!(self) }
+                instance_variable_get(:"@#{var_name}").tap { Internal::State::Mapper.observed!(self) }
               end
             end
           end
           base.singleton_class.send(:"define_#{kind}", :state_writer) do |*names|
             names.each do |name|
+              var_name = if Hyperstack::State::Observable.naming_convention == :prefix_state && name !~ /^_/
+                           "_#{name}"
+                         else
+                           name
+                         end
               define_method(:"#{name}=") do |x|
-                instance_variable_set(:"@#{name}", x).tap { Internal::State::Mapper.mutated!(self) }
+                instance_variable_set(:"@#{var_name}", x).tap { Internal::State::Mapper.mutated!(self) }
               end
             end
           end
diff --git a/ruby/hyper-state/lib/hyperstack/state/version.rb b/ruby/hyper-state/lib/hyperstack/state/version.rb
@@ -1,5 +1,5 @@
 module Hyperstack
   module State
-    VERSION = '0.1'
+    VERSION = '1.0.rc1'
   end
 end
diff --git a/ruby/hyper-store/lib/hyperstack/legacy/store/version.rb b/ruby/hyper-store/lib/hyperstack/legacy/store/version.rb
@@ -1,7 +1,7 @@
 module Hyperstack
   module Legacy
     module Store
-      VERSION = '0.1'
+      VERSION = '1.0.rc1'
     end
   end
 end
diff --git a/ruby/hyper-trace/lib/hyper_trace/version.rb b/ruby/hyper-trace/lib/hyper_trace/version.rb
@@ -1,3 +1,3 @@
 module HyperTrace
-  VERSION = '0.1.0'
+  VERSION = '1.0.rc1'
 end
diff --git a/ruby/hyperstack-config/lib/hyperstack/config/version.rb b/ruby/hyperstack-config/lib/hyperstack/config/version.rb
@@ -1,5 +1,5 @@
 module Hyperstack
   module Config
-    VERSION = '0.1'
+    VERSION = '1.0.rc1'
   end
 end
diff --git a/ruby/rails-hyperstack/lib/hyperstack/version.rb b/ruby/rails-hyperstack/lib/hyperstack/version.rb
@@ -1,3 +1,3 @@
 module Hyperstack
-  ROUTERVERSION = VERSION = '0.1.0'
+  ROUTERVERSION = VERSION = '1.0.rc1'
 end
