PeachPied.WordPress.Build.Plugin NuGet package missing required DLL (build/netstandard2.0/PeachPied.WordPress.Build.Plugin.dll)

[mkn8rn]

Describe the bug
I am trying to use the PeachPied.WordPress.Build.Plugin NuGet package (version 6.7.1) in a .NET 8 project, but MSBuild fails with the following error:
The "WpPluginTask" task could not be loaded from the assembly ...\build\netstandard2.0\PeachPied.WordPress.Build.Plugin.dll. Could not load file or assembly '...PeachPied.WordPress.Build.Plugin.dll' or one of its dependencies. The system cannot find the file specified.

After investigating, I found that the build/netstandard2.0/PeachPied.WordPress.Build.Plugin.dll file is missing from the NuGet package, both after a local restore and when inspecting the .nupkg file downloaded directly from NuGet.org. This prevents MSBuild from loading the required task and breaks plugin compilation.

To Reproduce

1. Add PeachPied.WordPress.Build.Plugin version 6.7.1 to a .NET project.
2. Restore NuGet packages.
3. Observe that build/netstandard2.0/PeachPied.WordPress.Build.Plugin.dll is missing from the package directory.
4. Build the project and see the MSBuild error above.

Expected behavior
The NuGet package should include the required DLL so that MSBuild can load the WpPluginTask.

Additional context
• .NET 8 project
• Visual Studio 2022
• Issue occurs on multiple machines and after clearing the NuGet cache
• The DLL is also missing from the .nupkg file when downloaded and extracted manually

[mkn8rn]

Reverted to .NET 6 to fix. All the other plugins installed and appeared to work fine without this revert.

[mkn8rn]

It seems that netstandard2.0 support was dropped, and it causes this bug:

wpdotnet-sdk/PeachPied.WordPress.Build.Plugin/build/PeachPied.WordPress.Build.Plugin.targets

Line 22 in bf26d50

<BuildPluginTaskAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)netstandard2.0\PeachPied.WordPress.Build.Plugin.dll</BuildPluginTaskAssembly>

  <!-- use netstandard2.0 for full .NET just in case -->

  <PropertyGroup Condition=" '$(BuildPluginTaskAssembly)'=='' ">
    <BuildPluginTaskAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)netstandard2.0\PeachPied.WordPress.Build.Plugin.dll</BuildPluginTaskAssembly>
    <BuildPluginTaskAssembly Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)net6.0\PeachPied.WordPress.Build.Plugin.dll</BuildPluginTaskAssembly>
  </PropertyGroup>

Error happens because the project tries to use netstandard2.0 build when not on 6, but because csproj only targets net6.0 there is no netstandard2.0 build and hence no build/netstandard2.0/PeachPied.WordPress.Build.Plugin.dll.

This is the only indication in the documentation that this was ever supported that I could find, and it seems only with older PeachPie versions: https://docs.peachpie.io/scenarios/beginner/full-net-framework/

And we can see netstandard2.0 was a targetted version in the csproj once:

wpdotnet-sdk/PeachPied.WordPress.Build.Plugin/PeachPied.WordPress.Build.Plugin.csproj

Line 3 in 2852642

<TargetFrameworks>netstandard2.0;netcoreapp2.1</TargetFrameworks>