GitHub: Use menuitemcheckbox instead of menuitem for checkable menu items so they work in Chrome (and as per the ARIA spec; oops).

jcsteh · jcsteh · commit 0d40580c34b9 · 2017-06-07T09:13:22.000+10:00
diff --git a/GitHubA11yFixes.user.js b/GitHubA11yFixes.user.js
@@ -103,7 +103,7 @@ function onNodeAdded(target) {
 	// Site-wide stuff.
 	// Checkable menu items; e.g. in watch and labels pop-ups.
 	for (elem of target.querySelectorAll(".select-menu-item")) {
-		elem.setAttribute("role", "menuitem");
+		elem.setAttribute("role", "menuitemcheckbox");
 		onSelectMenuItemChanged(elem);
 	}
 	// Table lists; e.g. in issue and commit listings.

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ function onNodeAdded(target) {`
`103`	`103`	`// Site-wide stuff.`
`104`	`104`	`// Checkable menu items; e.g. in watch and labels pop-ups.`
`105`	`105`	`for (elem of target.querySelectorAll(".select-menu-item")) {`
`106`		`- elem.setAttribute("role", "menuitem");`
	`106`	`+ elem.setAttribute("role", "menuitemcheckbox");`
`107`	`107`	`onSelectMenuItemChanged(elem);`
`108`	`108`	`}`
`109`	`109`	`// Table lists; e.g. in issue and commit listings.`