-
Notifications
You must be signed in to change notification settings - Fork 34
Open
Description
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Overview
Final cleanup tasks after all 5 module migrations are complete. This issue removes the legacy resources/ directory and updates configuration files.
Prerequisites
Blocked by: #182, #183, #184, #185, #186
All 5 module migrations must be completed before this cleanup can proceed.
Tasks
-
Remove
package_datafromsetup.py- Remove the line:
package_data={"le_utils": ["resources/*.json"]} - The resources directory will no longer exist, so this must be removed
- Remove the line:
-
Delete
le_utils/resources/directory- Verify all JSON files have been deleted by individual migration issues
- Remove the empty
resources/directory itself
-
Update
README.md- Remove warnings about keeping Python/JSON in sync
- Update documentation to describe spec + generation workflow
- Remove references to manual constants maintenance
-
Update
CHANGELOG.md- Add entry for the migration with version number
- List all migrated modules
- Note JavaScript exports now available for all constants
-
Verify entire test suite passes
- Run
pytest tests/ -v - Ensure no broken imports or references to old JSON files
- Run
How to Verify
# Ensure resources directory doesn't exist
ls le_utils/resources/ # should error: No such file or directory
# Verify tests pass
pytest tests/ -v
# Verify build works
make build
# Verify package can be installed
python setup.py sdist
pip install dist/le-utils-*.tar.gzAcceptance Criteria
-
package_dataremoved fromsetup.py -
le_utils/resources/directory deleted - README.md updated to remove sync warnings
- README.md updated to document spec + generation workflow
- CHANGELOG.md updated with migration notes
- All tests pass:
pytest tests/ -v -
make buildsucceeds - Package builds and installs successfully
Disclosure
🤖 This issue was written by Claude Code, under supervision, review and final edits by @rtibbles 🤖
Metadata
Metadata
Assignees
Labels
No labels
