Fixed #36 - Expression.Body is const when variables are passed

Author: linkdotnet

LinkDotNet.Blog.Infrastructure/Persistence/CachedRepository.cs

@@ -48,7 +48,7 @@ public async Task<IPagedList<T>> GetAllAsync(
             int page = 1,
             int pageSize = int.MaxValue)
         {
-            var key = $"{filter?.Body}-{orderBy?.Body}-{descending}-{page}-{pageSize}";
+            var key = $"{filter?.GetHashCode()}-{orderBy?.GetHashCode()}-{descending}-{page}-{pageSize}";
             return await memoryCache.GetOrCreate(key, async e =>
             {
                 e.SetOptions(Options);

LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/CachedRepositoryTests.cs

@@ -0,0 +1,34 @@
+using System.Linq;
+using System.Threading.Tasks;
+using FluentAssertions;
+using LinkDotNet.Blog.Domain;
+using LinkDotNet.Blog.Infrastructure.Persistence;
+using LinkDotNet.Blog.TestUtilities;
+using Microsoft.Extensions.Caching.Memory;
+using Xunit;
+
+namespace LinkDotNet.Blog.IntegrationTests.Infrastructure.Persistence
+{
+    public class CachedRepositoryTests : SqlDatabaseTestBase<BlogPost>
+    {
+        [Fact]
+        public async Task ShouldNotCacheWhenDifferentQueries()
+        {
+            var bp1 = new BlogPostBuilder().WithTags("tag 1").Build();
+            var bp2 = new BlogPostBuilder().WithTags("tag 2").Build();
+            var bp3 = new BlogPostBuilder().WithTags("tag 1").Build();
+            await Repository.StoreAsync(bp1);
+            await Repository.StoreAsync(bp2);
+            await Repository.StoreAsync(bp3);
+            var searchTerm = "tag 1";
+            var sut = new CachedRepository<BlogPost>(Repository, new MemoryCache(new MemoryCacheOptions()));
+            await sut.GetAllAsync(f => f.Tags.Any(t => t.Content == searchTerm));
+            searchTerm = "tag 2";
+
+            var allWithTag2 = await sut.GetAllAsync(f => f.Tags.Any(t => t.Content == searchTerm));
+
+            allWithTag2.Count.Should().Be(1);
+            allWithTag2.Single().Tags.Single().Content.Should().Be("tag 2");
+        }
+    }
+}