From 75bb543993f615d8310e9781dc6947431e75abb8 Mon Sep 17 00:00:00 2001 From: Tim Trippel Date: Tue, 18 Mar 2025 11:09:17 -0700 Subject: [PATCH] [manuf] remove noisy console prints during individualize This removes noisy console prints during FT individualization binary execution. This is to optimize test execution in ATE environment. Signed-off-by: Tim Trippel (cherry picked from commit bc3ec65f4953b8bad924fff52af8f113e2265e76) --- .../manuf/base/sram_ft_individualize.c | 10 ---------- sw/device/silicon_creator/manuf/lib/BUILD | 1 - .../silicon_creator/manuf/lib/individualize_sw_cfg.c | 12 ------------ 3 files changed, 23 deletions(-) diff --git a/sw/device/silicon_creator/manuf/base/sram_ft_individualize.c b/sw/device/silicon_creator/manuf/base/sram_ft_individualize.c index 0156d16a5dd3c..145dd9f423360 100644 --- a/sw/device/silicon_creator/manuf/base/sram_ft_individualize.c +++ b/sw/device/silicon_creator/manuf/base/sram_ft_individualize.c @@ -182,8 +182,6 @@ static status_t patch_ast_config_value(void) { TRY(manuf_flash_info_field_read( &flash_ctrl_state, kFlashInfoFieldAstIndividPatchVal, &ast_patch_value, kFlashInfoFieldAstIndividPatchValSizeIn32BitWords)); - LOG_INFO("AST patch address offset = 0x%08x", ast_patch_addr_offset); - LOG_INFO("AST patch address value = 0x%08x", ast_patch_value); // Check the address is within range before programming. // Check the value is non-zero and not all ones before programming. @@ -197,14 +195,6 @@ static status_t patch_ast_config_value(void) { TOP_EARLGREY_AST_BASE_ADDR + ast_patch_addr_offset * sizeof(uint32_t), ast_patch_value); - // Read back AST calibration values loaded into CSRs. - LOG_INFO("AST Calibration Values (in CSRs):"); - for (size_t i = 0; i < kFlashInfoAstCalibrationDataSizeIn32BitWords; ++i) { - LOG_INFO( - "Word %d = 0x%08x", i, - abs_mmio_read32(TOP_EARLGREY_AST_BASE_ADDR + i * sizeof(uint32_t))); - } - return OK_STATUS(); } diff --git a/sw/device/silicon_creator/manuf/lib/BUILD b/sw/device/silicon_creator/manuf/lib/BUILD index 6a02cd569c681..f2ca111c23ca0 100644 --- a/sw/device/silicon_creator/manuf/lib/BUILD +++ b/sw/device/silicon_creator/manuf/lib/BUILD @@ -186,7 +186,6 @@ cc_library( "//sw/device/lib/crypto/include:datatypes", "//sw/device/lib/dif:flash_ctrl", "//sw/device/lib/dif:otp_ctrl", - "//sw/device/lib/runtime:log", "//sw/device/lib/testing:flash_ctrl_testutils", "//sw/device/lib/testing:otp_ctrl_testutils", ], diff --git a/sw/device/silicon_creator/manuf/lib/individualize_sw_cfg.c b/sw/device/silicon_creator/manuf/lib/individualize_sw_cfg.c index 551880333e66d..b9b97aad76ebe 100644 --- a/sw/device/silicon_creator/manuf/lib/individualize_sw_cfg.c +++ b/sw/device/silicon_creator/manuf/lib/individualize_sw_cfg.c @@ -9,7 +9,6 @@ #include "sw/device/lib/crypto/include/datatypes.h" #include "sw/device/lib/dif/dif_flash_ctrl.h" #include "sw/device/lib/dif/dif_otp_ctrl.h" -#include "sw/device/lib/runtime/log.h" #include "sw/device/lib/testing/flash_ctrl_testutils.h" #include "sw/device/lib/testing/otp_ctrl_testutils.h" #include "sw/device/silicon_creator/manuf/lib/flash_info_fields.h" @@ -89,9 +88,6 @@ static status_t otp_img_write(const dif_otp_ctrl_t *otp, kv[i].offset < kInvalidAstCfgOtpAddrHigh)) { continue; } - LOG_INFO( - "OTP Write: Partition (%d); Idx (%d); Offset (0x%x); Num Vals (%d)", - partition, i, kv[i].offset, kv[i].num_values); uint32_t offset; TRY(dif_otp_ctrl_relative_address(partition, kv[i].offset, &offset)); switch (kv[i].type) { @@ -301,9 +297,7 @@ status_t manuf_individualize_device_flash_data_default_cfg_check( status_t manuf_individualize_device_creator_sw_cfg_lock( const dif_otp_ctrl_t *otp_ctrl) { - LOG_INFO("Locking CreatorSwCfg partition."); TRY(lock_otp_partition(otp_ctrl, kDifOtpCtrlPartitionCreatorSwCfg)); - LOG_INFO("Done."); return OK_STATUS(); } @@ -346,9 +340,7 @@ status_t manuf_individualize_device_partition_expected_read( status_t manuf_individualize_device_owner_sw_cfg_lock( const dif_otp_ctrl_t *otp_ctrl) { - LOG_INFO("Locking OwnerSwCfg partition."); TRY(lock_otp_partition(otp_ctrl, kDifOtpCtrlPartitionOwnerSwCfg)); - LOG_INFO("Done."); return OK_STATUS(); } @@ -365,9 +357,7 @@ status_t manuf_individualize_device_rot_creator_auth_codesign( TRY(otp_img_write(otp_ctrl, kDifOtpCtrlPartitionRotCreatorAuthCodesign, kOtpKvRotCreatorAuthCodesign, kOtpKvRotCreatorAuthCodesignSize)); - LOG_INFO("Locking RotCreatorAuthCodesign partition."); TRY(lock_otp_partition(otp_ctrl, kDifOtpCtrlPartitionRotCreatorAuthCodesign)); - LOG_INFO("Done."); return OK_STATUS(); } @@ -375,9 +365,7 @@ status_t manuf_individualize_device_rot_creator_auth_state( const dif_otp_ctrl_t *otp_ctrl) { TRY(otp_img_write(otp_ctrl, kDifOtpCtrlPartitionRotCreatorAuthState, kOtpKvRotCreatorAuthState, kOtpKvRotCreatorAuthStateSize)); - LOG_INFO("Locking RotCreatorAuthState partition."); TRY(lock_otp_partition(otp_ctrl, kDifOtpCtrlPartitionRotCreatorAuthState)); - LOG_INFO("Done."); return OK_STATUS(); }