* fix warnings about signedness

lpcvoid · lpcvoid · commit 5eb6c28649fe · 2021-11-24T21:39:57.000+01:00
diff --git a/src/client.hpp b/src/client.hpp
@@ -160,7 +160,7 @@ namespace netlib {
           }
           ssize_t send_res = ::send(_socket.value().get_raw().value(), reinterpret_cast<const char*>(data.data()), data.size(), 0);
           if (send_res >= 0) {
-            if (send_res == data.size()) {
+            if (static_cast<std::size_t>(send_res) == data.size()) {
               return {static_cast<std::size_t>(send_res), {}};
             }
             return {send_res, std::errc::message_size};
diff --git a/src/server.hpp b/src/server.hpp
@@ -137,7 +137,7 @@ namespace netlib {
                                                reinterpret_cast<const char*>(greeting.answer.data()),
                                                greeting.answer.size(),
                                                0);
-                  if ((send_result != greeting.answer.size()) && (_cb_on_error)) {
+                  if ((static_cast<std::size_t>(send_result) != greeting.answer.size()) && (_cb_on_error)) {
                     std::cout << "server error accept" << std::endl;
                     _cb_on_error(new_endpoint, socket_get_last_error());
                   }
@@ -189,7 +189,7 @@ namespace netlib {
                     ssize_t send_result = ::send(
                         endpoint.socket.get_raw().value(),
                         reinterpret_cast<const char*>(response.answer.data()), response.answer.size(), 0);
-                    if (send_result != response.answer.size()) {
+                    if (static_cast<std::size_t>(send_result) != response.answer.size()) {
                       return socket_get_last_error();
                     }
                   }

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ namespace netlib {`
`160`	`160`	`}`
`161`	`161`	`ssize_t send_res = ::send(_socket.value().get_raw().value(), reinterpret_cast<const char*>(data.data()), data.size(), 0);`
`162`	`162`	`if (send_res >= 0) {`
`163`		`- if (send_res == data.size()) {`
	`163`	`+ if (static_cast<std::size_t>(send_res) == data.size()) {`
`164`	`164`	`return {static_cast<std::size_t>(send_res), {}};`
`165`	`165`	`}`
`166`	`166`	`return {send_res, std::errc::message_size};`
Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ namespace netlib {`
`137`	`137`	`reinterpret_cast<const char*>(greeting.answer.data()),`
`138`	`138`	`greeting.answer.size(),`
`139`	`139`	`0);`
`140`		`- if ((send_result != greeting.answer.size()) && (_cb_on_error)) {`
	`140`	`+ if ((static_cast<std::size_t>(send_result) != greeting.answer.size()) && (_cb_on_error)) {`
`141`	`141`	`std::cout << "server error accept" << std::endl;`
`142`	`142`	`_cb_on_error(new_endpoint, socket_get_last_error());`
`143`	`143`	`}`
`@@ -189,7 +189,7 @@ namespace netlib {`
`189`	`189`	`ssize_t send_result = ::send(`
`190`	`190`	`endpoint.socket.get_raw().value(),`
`191`	`191`	`reinterpret_cast<const char*>(response.answer.data()), response.answer.size(), 0);`
`192`		`- if (send_result != response.answer.size()) {`
	`192`	`+ if (static_cast<std::size_t>(send_result) != response.answer.size()) {`
`193`	`193`	`return socket_get_last_error();`
`194`	`194`	`}`
`195`	`195`	`}`