Not working in Sublime Text 3

[mikemassari]

Hi,
when I right-click on a method and choose PhpSimpleRefactor: extract method,
the console asks me to input the function name. I do it, press enter but nothing happens.
It says "refactoring completed" but the function isn't in the file.

Any suggestion?

[lucacri]

Interesting.
Can you send me the file you are working on? I think it might be an issue with the function you are trying to extract

[mikemassari]

https://gist.github.com/Michelemassari/3200ece914adc5a21138#file-gistfile1-php

It was pretty simple stuff just for testing the plugin.
I had a basic Laravel application set up, a sublime project file, and I'm using Sublime Text 3

Let me know if you fint it helpful.
Cheers

[ivannpaz]

@lucacri @Michelemassari If you take the Package file Installed Packages\PhpSimpleRefactor.sublime-package and extract it to a folder in your Packages such as Packages\PhpSimpleRefactor it does work.

[lucacri]

@ivannpaz can you create a PR to fix this? I'm not using ST3 at the moment

[ivannpaz]

Hi @lucacri,

I did some other extra changes (mainly refactoring) to allow for other commands provided by the PHP Refactoring Browser.

I will organise a bit and start pull-requesting in the coming hours/days if you want me to.

[lucacri]

@ivannpaz that's awesome! Go ahead, i'll merge them as soon as you send them

[lord2800]

So... it's now a year later, @ivannpaz were you able to follow up on this and I just haven't found it?

[forgetfulanthropod]

I also couldn't get it to work in sublime 3 and gave up on it for now.
The owner may want to consider taking this down?
My apologies if I just fudged it.

[lucacri]

@ivannpaz any update? I'd love to merge your version if possible

[vukanac]

Please check console output in Sublime, as result of above commands.
It should say what is going on.

[bbuunk]

PhpSimpleRefactor still not working at Sublime 3, paths are correct set in settings.

[vukanac]

I am on Lubuntu with Sublime Text 3, it should work with original version, but for Win I had to change some stuff,
Modified version
try this:

1. Go to Preferences > Browse Packages
2. Open terminal in that folder
3. git clone https://github.com/vukanac/PhpSimpleRefactor.git WukanacPhpSimpleRefactor
4. git checkout feature/config-patch-tool
5. read Readme.md and set Config in: WukanacPhpSimple > Settings-User
   for Win, with php and patch.exe in path, a refactor in bin folder
   {
   "php_path": "php",
   "refactor_path": "d:\bin\refactor.phar",
   "patch_path": "patch",
   "patch_opts": "--binary"
   }
   for Linux, phar is executable, patch is already in path. --binary is not required.
   {
   "php_path" : "",
   "refactor_path" : "/home/dev/bin/refactor.phar",
   "patch_path" : "patch",
   "patch_opts" : "--binary",
   }

This PhpSimpleRefactor is fantastic tool! Thanx!

[lucacri]

@vukanac would you mind send a PR with the changes you made? I am not using this plugin anymore (moved to PhpStorm) but i'd love for people to not have issues with it!

[bbuunk]

@vukanac Thank you it finally works was missing patch_path and patch_opts added that and viola!

[TonyGravagno]

If the author isn't using/maintaining this package anymore, I recommend adding a comment that it's deprecated so that people don't load it via the package control. Thanks.