Sample Pull Request Template

[mitulmanish]

What it does, and why

• Please briefly describe what this change does and the motivation behind the change

Please specify the type of change

Please select one:

• New Feature
• Bug Fix
• Refactoring
• Added tests for existing functionality
• Updated assets
• Updated copy(localised text)
• Updated localised strings using Phrase app pull

Jira Tickets

https://monese.atlassian.net/browse/your-ticket-number-here

Testing

Please select one:

• Have you added Unit tests
• I Didn't add Unit tests because _____________
• Please mention the steps required to test this change
  • Example:
    • Launch the app
    • Enable the feature flag
    • Go to the Cards tab
    • Make sure the CTA button has a green background color

UI Changes

• If you have developed a new shiny✨ feature, please add a screenshot of the feature.The screenshot could be taken from any device, also attach the link of the design on Zeplin.
• If you have fixed a bug, then please attach a Before and After screenshots, so that it's easy for the reviewers to spot the changes. Please add your Before and After screenshots using the table below, so they can be viewed side by side.
• Please use the template below 👇🏼 to arrange your screenshots in a table
  |Before|After|
  |---|---|
  |image-url-here|image-url-here|

Feature Flag 🚩

• Have you added information regarding enabling/disabling feature flag/flags

UI

Did you test this feature on an actual device or simulator ?

• Physical Device
• Simulator

Which iOS version does your feature support ?

• iOS 10
• iOS 11
• iOS 12
• iOS 13

Constrained related warnings

• Make sure any new UI you have created does not produce auto layout constraints ambiguity

Localisation 🌍

• Have you localised the strings ?

Introducing Cross Cutting concerns

• Have you asked review from Team members who might be affected by your change in this pull request