refactor: remove all legacy/backward compatibility code and docs

- Remove legacy format fallback from main_config_loader.go
- Remove JSON export functions (ExportConfigAsJSON, ExportConfigAsYAML)
- Remove ConfigTemplate and GetConfigTemplates functions
- Remove 'convert' command from config-validator CLI tool
- Remove all migration guides and legacy format references from docs
- Update test to verify main config requires workflow_configs
- Update FAQ to reflect current config structure
- Remove all references to JSON conversion and legacy formats

All tests passing (14/14 MainConfigLoader tests)

Author: cbullinger

examples-copier/cmd/config-validator/README.md

@@ -10,7 +10,6 @@ The `config-validator` tool helps you:
 - Validate workflow configuration files
 - Test pattern matching
 - Test path transformations
-- Convert legacy JSON configs to YAML
 - Debug configuration issues
 
 ## Installation
@@ -178,38 +177,6 @@ Variables used:
   name = main
 ```
 
-### convert
-
-Convert legacy JSON configuration to YAML format.
-
-**Usage:**
-```bash
-./config-validator convert -input <file> -output <file>
-```
-
-**Options:**
-- `-input` - Input JSON file (required)
-- `-output` - Output YAML file (required)
-
-**Example:**
-
-```bash
-./config-validator convert -input config.json -output workflow-config.yaml
-```
-
-**Output:**
-```
-✅ Conversion successful!
-
-Converted 2 legacy rules to YAML format.
-Output written to: workflow-config.yaml
-
-Next steps:
-1. Review the generated workflow-config.yaml
-2. Enhance with new features (regex patterns, path transforms)
-3. Validate: ./config-validator validate -config workflow-config.yaml
-```
-
 ## Common Use Cases
 
 ### Debugging Pattern Matching
@@ -271,9 +238,6 @@ Before deploying a new configuration:
 ### Migrating from JSON to YAML
 
 ```bash
-# Convert
-./config-validator convert -input config.json -output workflow-config.yaml
-
 # Validate
 ./config-validator validate -config workflow-config.yaml -v
 

examples-copier/cmd/config-validator/main.go

@@ -28,11 +28,7 @@ func main() {
 
 	initCmd := flag.NewFlagSet("init", flag.ExitOnError)
 	initTemplate := initCmd.String("template", "basic", "Template to use: basic, glob, or regex")
-	initOutput := initCmd.String("output", "copier-config.yaml", "Output file path")
-
-	convertCmd := flag.NewFlagSet("convert", flag.ExitOnError)
-	convertInput := convertCmd.String("input", "", "Input config file (required)")
-	convertOutput := convertCmd.String("output", "", "Output config file (required)")
+	initOutput := initCmd.String("output", "workflow-config.yaml", "Output file path")
 
 	if len(os.Args) < 2 {
 		printUsage()
@@ -71,40 +67,29 @@ func main() {
 		initCmd.Parse(os.Args[2:])
 		initConfig(*initTemplate, *initOutput)
 
-	case "convert":
-		convertCmd.Parse(os.Args[2:])
-		if *convertInput == "" || *convertOutput == "" {
-			fmt.Println("Error: -input and -output are required")
-			convertCmd.Usage()
-			os.Exit(1)
-		}
-		convertConfig(*convertInput, *convertOutput)
-
 	default:
 		printUsage()
 		os.Exit(1)
 	}
 }
 
 func printUsage() {
-	fmt.Println("Config Validator - Validate and test copier configurations")
+	fmt.Println("Config Validator - Validate and test copier workflow configurations")
 	fmt.Println()
 	fmt.Println("Usage:")
 	fmt.Println("  config-validator <command> [options]")
 	fmt.Println()
 	fmt.Println("Commands:")
-	fmt.Println("  validate       Validate a configuration file")
+	fmt.Println("  validate       Validate a workflow configuration file")
 	fmt.Println("  test-pattern   Test a pattern against a file path")
 	fmt.Println("  test-transform Test a path transformation")
-	fmt.Println("  init           Initialize a new config file from template")
-	fmt.Println("  convert        Convert between JSON and YAML formats")
+	fmt.Println("  init           Initialize a new workflow config file from template")
 	fmt.Println()
 	fmt.Println("Examples:")
-	fmt.Println("  config-validator validate -config copier-config.yaml -v")
+	fmt.Println("  config-validator validate -config .copier/workflows/config.yaml -v")
 	fmt.Println("  config-validator test-pattern -type glob -pattern 'examples/**/*.go' -file 'examples/go/main.go'")
 	fmt.Println("  config-validator test-transform -source 'examples/go/main.go' -template 'code/${filename}'")
-	fmt.Println("  config-validator init -template basic -output my-config.yaml")
-	fmt.Println("  config-validator convert -input config.json -output config.yaml")
+	fmt.Println("  config-validator init -template basic -output workflow-config.yaml")
 }
 
 func validateConfig(configFile string, verbose bool) {
@@ -230,42 +215,3 @@ func initConfig(templateName, output string) {
 	fmt.Printf("✅ Created config file: %s\n", output)
 	fmt.Printf("Template: %s\n", selectedTemplate.Description)
 }
-
-func convertConfig(input, output string) {
-	content, err := os.ReadFile(input)
-	if err != nil {
-		fmt.Printf("❌ Error reading input file: %v\n", err)
-		os.Exit(1)
-	}
-
-	loader := services.NewConfigLoader()
-	config, err := loader.LoadConfigFromContent(string(content), input)
-	if err != nil {
-		fmt.Printf("❌ Error parsing input file: %v\n", err)
-		os.Exit(1)
-	}
-
-	var outputContent string
-	if strings.HasSuffix(output, ".yaml") || strings.HasSuffix(output, ".yml") {
-		outputContent, err = services.ExportConfigAsYAML(config)
-	} else if strings.HasSuffix(output, ".json") {
-		outputContent, err = services.ExportConfigAsJSON(config)
-	} else {
-		fmt.Println("❌ Output file must have .yaml, .yml, or .json extension")
-		os.Exit(1)
-	}
-
-	if err != nil {
-		fmt.Printf("❌ Error converting config: %v\n", err)
-		os.Exit(1)
-	}
-
-	err = os.WriteFile(output, []byte(outputContent), 0644)
-	if err != nil {
-		fmt.Printf("❌ Error writing output file: %v\n", err)
-		os.Exit(1)
-	}
-
-	fmt.Printf("✅ Converted %s to %s\n", input, output)
-}
-

examples-copier/configs/copier-config-examples/MAIN-CONFIG-README.md

@@ -162,43 +162,6 @@ workflows:
 2. Trigger a webhook event (merge a PR in source repo)
 3. Verify workflows execute correctly
 
-## Migration Guide
-
-### From Legacy Format
-
-If you have an existing `copier-config.yaml`:
-
-#### Option 1: Keep Legacy Format (No Changes)
-
-Don't set `MAIN_CONFIG_FILE` - the app will continue using the legacy format.
-
-#### Option 2: Migrate to Main Config
-
-1. **Create main config file**:
-   ```yaml
-   defaults:
-     # Copy defaults from legacy config
-   
-   workflow_configs:
-     - source: "inline"
-       workflows:
-         # Copy workflows from legacy config
-   ```
-
-2. **Update env.yaml**:
-   ```yaml
-   MAIN_CONFIG_FILE: "main-config.yaml"
-   USE_MAIN_CONFIG: "true"
-   ```
-
-3. **Test thoroughly** before deploying
-
-#### Option 3: Gradual Migration
-
-1. Start with inline workflows in main config
-2. Gradually move workflows to separate files
-3. Eventually move to distributed workflow configs
-
 ## Best Practices
 
 ### 1. Organization

examples-copier/configs/copier-config-examples/QUICK-START-MAIN-CONFIG.md

@@ -242,25 +242,6 @@ workflows:
 4. **Add more workflows**: Expand your configuration
 5. **Use reusable components**: Extract common configs
 
-## Migration from Legacy Format
-
-Already using `copier-config.yaml`? You have options:
-
-### Option 1: Keep Legacy Format
-Don't change anything - legacy format still works!
-
-### Option 2: Migrate Gradually
-1. Set `MAIN_CONFIG_FILE` to new file
-2. Use inline workflows initially
-3. Gradually move to separate files
-
-### Option 3: Full Migration
-1. Create main config with workflow references
-2. Move workflows to source repos
-3. Update env.yaml
-4. Test thoroughly
-5. Deploy
-
 ## Support
 
 - **Documentation**: `MAIN-CONFIG-README.md`

examples-copier/configs/copier-config-examples/main-config-example.yaml

@@ -166,29 +166,6 @@ workflow_configs:
 #    - Clear separation between global and local settings
 #
 # ============================================================================
-# MIGRATION FROM LEGACY FORMAT
-# ============================================================================
-#
-# If you have an existing copier-config.yaml with workflows directly defined:
-#
-# OPTION 1: Keep using legacy format
-# - Don't set MAIN_CONFIG_FILE in env.yaml
-# - App will use legacy config loader
-# - No changes needed
-#
-# OPTION 2: Migrate to main config format
-# - Create this main config file
-# - Move workflows to separate workflow config files
-# - Set MAIN_CONFIG_FILE in env.yaml
-# - Set USE_MAIN_CONFIG=true in env.yaml
-#
-# OPTION 3: Hybrid approach
-# - Use inline workflows in main config
-# - Gradually migrate to separate workflow configs
-# - Start with simple workflows inline
-# - Move complex workflows to separate files
-#
-# ============================================================================
 # ENVIRONMENT VARIABLES
 # ============================================================================
 #

examples-copier/docs/ARCHITECTURE.md

@@ -243,7 +243,7 @@ targets:
 
 **Files:**
 - `types/config.go` - Configuration types with $ref support
-- `services/config_loader.go` - Configuration loader with YAML/JSON support
+- `services/config_loader.go` - Configuration loader
 - `services/main_config_loader.go` - Main config loader with reference resolution
 
 **Capabilities:**
@@ -412,10 +412,7 @@ config-validator test-transform \
   -template "code/${filename}"
 
 # Initialize new config from template
-config-validator init -template basic -output my-copier-config.yaml
-
-# Convert between formats
-config-validator convert -input config.json -output copier-config.yaml
+config-validator init -template basic -output my-workflow-config.yaml
 ```
 
 ### 11. Development/Testing Features

examples-copier/docs/FAQ.md

@@ -74,19 +74,11 @@ Yes. A file can match multiple workflows and be copied to multiple targets. This
 
 ### Where should I store the config file?
 
-**For production:** Store `copier-config.yaml` in your source repository (the repo being monitored for PRs).
+**Main config:** Store in a central config repository and set `MAIN_CONFIG_FILE` in env.yaml.
 
-**For local testing:** Store `copier-config.yaml` in the examples-copier directory and set `CONFIG_FILE=copier-config.yaml`.
+**Workflow configs:** Store in `.copier/workflows/config.yaml` in source repositories, or reference them from the main config.
 
-### How do I migrate from JSON to YAML?
-
-Use the config-validator tool:
-
-```bash
-./config-validator convert -input config.json -output copier-config.yaml
-```
-
-The tool will automatically convert your legacy JSON configuration to the new YAML format while preserving all settings.
+**For local testing:** Store config files in the examples-copier directory and set appropriate environment variables.
 
 ## Pattern Matching
 

examples-copier/services/config_loader.go

@@ -2,7 +2,6 @@ package services
 
 import (
 	"context"
-	"encoding/json"
 	"fmt"
 	"os"
 
@@ -147,58 +146,6 @@ func (cv *ConfigValidator) TestTransform(sourcePath string, template string, var
 	return transformer.Transform(sourcePath, template, variables)
 }
 
-// ExportConfigAsYAML exports a config as YAML string
-func ExportConfigAsYAML(config *types.YAMLConfig) (string, error) {
-	data, err := yaml.Marshal(config)
-	if err != nil {
-		return "", fmt.Errorf("failed to marshal config to YAML: %w", err)
-	}
-	return string(data), nil
-}
-
-// ExportConfigAsJSON exports a config as JSON string
-func ExportConfigAsJSON(config *types.YAMLConfig) (string, error) {
-	data, err := json.MarshalIndent(config, "", "  ")
-	if err != nil {
-		return "", fmt.Errorf("failed to marshal config to JSON: %w", err)
-	}
-	return string(data), nil
-}
-
-// ConfigTemplate represents a configuration template
-type ConfigTemplate struct {
-	Name        string
-	Description string
-	Content     string
-}
-
-// GetConfigTemplates returns available configuration templates
-func GetConfigTemplates() []ConfigTemplate {
-	return []ConfigTemplate{
-		{
-			Name:        "basic-workflow",
-			Description: "Basic workflow configuration",
-			Content: `workflows:
-  - name: "Copy examples"
-    source:
-      repo: "owner/source-repo"
-      branch: "main"
-    destination:
-      repo: "owner/target-repo"
-      branch: "main"
-    transformations:
-      - move:
-          from: "examples"
-          to: "code-examples"
-    commit_strategy:
-      type: "pull_request"
-      pr_title: "Update code examples"
-      pr_body: "Automated update from source repository"
-`,
-		},
-	}
-}
-
 // loadLocalConfigFile attempts to load config from a local file
 // This is useful for local testing and development
 func loadLocalConfigFile(filename string) (string, error) {

examples-copier/services/main_config_loader.go

@@ -75,22 +75,16 @@ func (mcl *DefaultMainConfigLoader) LoadMainConfigFromContent(ctx context.Contex
 		return nil, fmt.Errorf("main config file is empty")
 	}
 
-	// Try to parse as MainConfig first
+	// Parse as MainConfig
 	var mainConfig types.MainConfig
 	err := yaml.Unmarshal([]byte(content), &mainConfig)
 	if err != nil {
-		// If it fails, try parsing as legacy YAMLConfig
-		LogInfoCtx(ctx, "failed to parse as MainConfig, trying legacy YAMLConfig format", map[string]interface{}{
-			"error": err.Error(),
-		})
-		return mcl.configLoader.LoadConfigFromContent(content, config.ConfigFile)
+		return nil, fmt.Errorf("failed to parse main config: %w", err)
 	}
 
-	// Check if this is actually a MainConfig (has workflow_configs)
+	// Validate that workflow_configs is present
 	if len(mainConfig.WorkflowConfigs) == 0 {
-		// This is a legacy YAMLConfig format
-		LogInfoCtx(ctx, "detected legacy YAMLConfig format (no workflow_configs)", nil)
-		return mcl.configLoader.LoadConfigFromContent(content, config.ConfigFile)
+		return nil, fmt.Errorf("main config must have at least one workflow_config entry")
 	}
 
 	// Set defaults for main config