GODRIVER-3659 Add optin setting to await MinPoolSize population #2258
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements an opt-in setting to await minimum pool size population before running tests in the unified test runner. The change replaces a boolean flag with a configurable timeout duration in milliseconds, allowing tests to wait for connection pools to reach minPoolSize across all servers before proceeding.
Key Changes:
- Replaced
AwaitMinPoolSizeboolean flag withAwaitMinPoolSizeMStimeout configuration - Enhanced connection tracking to monitor ready connections per server address
- Added event history reset capability after pool population is complete
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/integration/unified/entity.go | Updated entity options to use millisecond-based timeout instead of boolean flag; reformatted code structure |
| internal/integration/unified/client_entity.go | Implemented per-server connection tracking, moved and enhanced pool size waiting logic with configurable timeout, added event history reset |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prestonvasquez
added
the
review-priority-normal
API Change ReportNo changes found! |
prestonvasquez
force-pushed
the
cicd/godriver-3659-support-awaitMinPoolSizeMS-in-unified-spec-runner
branch
from
e9a03c9 to
fce4695
Compare
🧪 Performance ResultsCommit SHA: 8a0716cThere were no significant changes to the performance to report for version 69336dd537d7280007e86322. For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
prestonvasquez
force-pushed
the
cicd/godriver-3659-support-awaitMinPoolSizeMS-in-unified-spec-runner
branch
2 times, most recently
from
9fe075a to
19124b5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prestonvasquez
force-pushed
the
cicd/godriver-3659-support-awaitMinPoolSizeMS-in-unified-spec-runner
branch
from
5e3207c to
399718c
Compare
github-actions
bot
added
dependencies
prestonvasquez
force-pushed
the
cicd/godriver-3659-support-awaitMinPoolSizeMS-in-unified-spec-runner
branch
from
399718c to
5e3207c
Compare
prestonvasquez
force-pushed
the
cicd/godriver-3659-support-awaitMinPoolSizeMS-in-unified-spec-runner
branch
from
5e3207c to
8a0716c
Compare
prestonvasquez
added
ci/cd
and removed
ci/cd
dependencies
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
GODRIVER-3659
Naive implementation of #2235