"npm test" crashes out

[Pomax]

Running npm test with a webmaker_oauth2_test database created in postgresql, and the login service running on port 3000, generates a whole bunch of errors around lib/accounts.js line 37 which parses the login response.

A console.log of the data it tries to parse shows that it dies when it gets the value "not json" as body, which is a little confusing because it's unclear where that's coming from. The test mock server generates it, it seems like, but it's unclear why it does so - does the login.webmaker.org service generate that same string in any circumstance?

[cadecairos]

Oh, haha this isn't a bug, it's overly verbose logging by hapi. Those errors are from tests that make sure if the response from login isn't json, the server doesn't just crash.

[Pomax]

npm sure suggests this is really bad:

89 tests complete
Test duration: 468 ms
The following leaks were detected:Reflect
Coverage: 95.89% (45/1096)
lib/account.js missing coverage on line(s): 31, 173, 179
lib/oauth-db.js missing coverage on line(s): 16, 17, 18, 26, 27, 37, 38, 66, 67, 81, 82, 93, 94, 98, 99, 123, 124, 138, 139
web/server.js missing coverage on line(s): 30, 31, 32, 47, 48, 57, 117, 118, 120, 123, 124, 127, 129, 253, 254, 519, 520, 521, 522, 523, 525, 591, 592


npm ERR! Darwin 15.5.0
npm ERR! argv "/usr/local/Cellar/node/6.2.2/bin/node" "/usr/local/bin/npm" "run" "test:server"
npm ERR! node v6.2.2
npm ERR! npm  v3.9.5
npm ERR! code ELIFECYCLE
npm ERR! id.webmaker.org@1.0.0 test:server: `npm run test:setup && lab -t 95`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the id.webmaker.org@1.0.0 test:server script 'npm run test:setup && lab -t 95'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the id.webmaker.org package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run test:setup && lab -t 95
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs id.webmaker.org
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls id.webmaker.org
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Pomax/Documents/git/id.webmaker.org/npm-debug.log
npm ERR! Test failed.  See above for more details.

which would definitely cause problems for CI

[cadecairos]

That's unrelated to the errors. Has code landed recently that would cause that leak?

[cadecairos]

FYI Runs fine in node 4.4.7

[Pomax]

Hm, yeah I'm running this with node6, I wonder what changed between the two to cause this