Introduce aura_instance_id parameter #959
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
FlorentinD
commented
Sep 18, 2025
FlorentinD
force-pushed
the
gds-session-override-instance-id
branch
from
38a229e to
e52a088
Compare
Contributor
Author
|
this is needed in 2 main cases:
|
FlorentinD
force-pushed
the
gds-session-override-instance-id
branch
from
e52a088 to
56f2b6e
Compare
FlorentinD
commented
Oct 2, 2025
FlorentinD
force-pushed
the
gds-session-override-instance-id
branch
from
56f2b6e to
de87abc
Compare
allow to explicitly pass it. This is important if the original Aura instance id not part of the uri. Such as for multi-db support ref GDSA-283
FlorentinD
force-pushed
the
gds-session-override-instance-id
branch
from
de87abc to
d789559
Compare
DarthMax
approved these changes
Nov 28, 2025
Comment on lines
+6
to
+17
| def hosted_in_aura(db_runner: Neo4jQueryRunner) -> bool: | ||
| return ( | ||
| db_runner.run_retryable_cypher(""" | ||
| CALL dbms.components() YIELD name, versions | ||
| WHERE name = "Neo4j Kernel" | ||
| UNWIND versions as v | ||
| WITH name, v | ||
| WHERE v ENDS WITH "aura" | ||
| RETURN count(*) <> 0 | ||
| """).squeeze() | ||
| is True | ||
| ) |
Contributor
There was a problem hiding this comment.
The formatting here is very strange
| database: str | None = None | ||
| # Optional: typed authentication, used instead of username/password. Supports for example a token. See https://neo4j.com/docs/python-manual/current/connect-advanced/#authentication-methods | ||
| auth: Auth | None = None | ||
| aura_instance_id: str | None = None |
Contributor
There was a problem hiding this comment.
Could it be a either or thing between this and the uri? If the instance id is set we can try to guess the URI?
| f"Aura instance with id `{db_connection.aura_instance_id}` could not be found. Please verify that the instance id is correct and that you have access to the Aura instance." | ||
| ) | ||
| else: | ||
| raise ValueError( |
Contributor
There was a problem hiding this comment.
This is a strange place for this error. I think it would be more clear if we checked if the aura_instance_id variable is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to explicitly pass it.
This is important if the original Aura instance id not part of the uri. Such as for multi-db support
ref GDSA-283