PhpFile::addNamespace() & removeNamespace() - passing objects is deprecated (BC break)

Author: dg

src/PhpGenerator/PhpFile.php

@@ -125,10 +125,12 @@ public function addFunction(string $name): GlobalFunction
 	 */
 	public function addNamespace(string|PhpNamespace $namespace): PhpNamespace
 	{
-		$res = $namespace instanceof PhpNamespace
-			? ($this->namespaces[$namespace->getName()] = $namespace)
-			: ($this->namespaces[$namespace] ??= new PhpNamespace($namespace));
-
+		if ($namespace instanceof PhpNamespace) {
+			trigger_error('Passing PhpNamespace object to ' . __METHOD__ . '() is deprecated, use add() instead.', E_USER_DEPRECATED);
+			$res = $this->namespaces[$namespace->getName()] = $namespace;
+		} else {
+			$res = $this->namespaces[$namespace] ??= new PhpNamespace($namespace);
+		}
 		$this->refreshBracketedSyntax();
 		return $res;
 	}
@@ -139,7 +141,13 @@ public function addNamespace(string|PhpNamespace $namespace): PhpNamespace
 	 */
 	public function removeNamespace(string|PhpNamespace $namespace): static
 	{
-		$name = $namespace instanceof PhpNamespace ? $namespace->getName() : $namespace;
+		if ($namespace instanceof PhpNamespace) {
+			trigger_error('Passing PhpNamespace object to ' . __METHOD__ . '() is deprecated, use string name instead.', E_USER_DEPRECATED);
+			$name = $namespace->getName();
+		} else {
+			$name = $namespace;
+		}
+
 		unset($this->namespaces[$name]);
 		return $this;
 	}

tests/PhpGenerator/PhpFile.addNamespace.phpt

@@ -11,7 +11,7 @@ $namespace->addClass('Bar');
 
 $phpFile = new PhpFile;
 $phpFile->addNamespace('Foo');
-$phpFile->addNamespace($namespace); // overwrite
+@$phpFile->addNamespace($namespace); // deprecated overwrite
 
 
 same(