PhpNamespace::add() passes self to ClassLike (BC break)

Author: dg

src/PhpGenerator/Factory.php

@@ -62,7 +62,7 @@ private function createClassObject(\ReflectionClass &$from): ClassLike
 			$class->setReadOnly(PHP_VERSION_ID >= 80200 && $from->isReadOnly());
 		}
 
-		$class->setNamespace(new PhpNamespace($from->getNamespaceName()));
+		(new PhpNamespace($from->getNamespaceName()))->add($class);
 		return $class;
 	}
 

src/PhpGenerator/PhpNamespace.php

@@ -277,6 +277,7 @@ public function add(ClassType|InterfaceType|TraitType|EnumType|GlobalFunction $i
 			}
 
 			$this->classes[$lower] = $item;
+			$item->setNamespace($this);
 		}
 
 		return $this;

tests/PhpGenerator/ClassType.from.phpt

@@ -9,6 +9,7 @@ declare(strict_types=1);
 use Nette\PhpGenerator\ClassType;
 use Nette\PhpGenerator\Factory;
 use Nette\PhpGenerator\InterfaceType;
+use Tester\Assert;
 
 require __DIR__ . '/../bootstrap.php';
 require __DIR__ . '/fixtures/classes.php';
@@ -31,3 +32,7 @@ $res[] = ClassType::from(Abc\Class9::class);
 $res[] = ClassType::from(Abc\Class10::class);
 
 sameFile(__DIR__ . '/expected/ClassType.from.expect', implode("\n", $res));
+
+// class is in namespace
+$c = ClassType::from(Abc\Class10::class);
+Assert::same($c, $c->getNamespace()->getClass('Class10'));

tests/PhpGenerator/PhpNamespace.add.phpt

@@ -40,8 +40,9 @@ test('adding classes preserves their original namespaces', function () {
 		(string) $namespace,
 	);
 
-	Assert::null($classA->getNamespace());
-	Assert::same('X', $classB->getNamespace()->getName());
+	// namespaces are updated to target namespace
+	Assert::same($namespace, $classA->getNamespace());
+	Assert::same($namespace, $classB->getNamespace());
 });