Skip to content

Unexpected number of simulations with multiple cores #7

@kalenkovich

Description

@kalenkovich

It seems that parameter B of BFDA.sim sets the number of simulations per core and not the total number of simulations. This behavior was unexpected to me. While the help for BFDA.sim does not explicitly stay which way it is, it does say that B "should be dividable by the numbers of cores" which implies that B is the total number of simulations. I think that either the behavior or the docs should be changed. Personally, I would go for the behavior.

Steps to reproduce:

library(BFDA)

sim.H1 <- BFDA.sim(
  expected.ES = 0.5, type = "t.between", alternative = "greater",
  n.max = 20,
  B = 4, cores = 2
)

n_simulations <- length(unique(sim.H1$sim$id))
n_simulations

Output:

8

Expected output:

4

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions