Replays for runs that are not server record

[Jeftaei]

One of the main ideas in the beginning of the project was saving the replay of every time, which unfortunately doesnt seem too practical, however we can continue saving all server record replays without issue

It DOES seem possible to grab replays of times that arent world record, but im not exactly sure what bhoptimer function we would have to grab it from, or if we even can, worst case scenario we can just track input data when a run starts, but id rather not track the replay than make that

[Jeftaei]

Removing this from release, its not extremely worth it right now and i dont think its required for a release version, it would be nice but until a system to filter out replays is fully made this doesnt need to be added

[mourningsickness]

if you want to save replays that aren't WR, do something like this using OnFinishPre maybe: https://github.com/KawaiiClan/bhoptimer-savestate/blob/1cb2b94252ec7aadd8cbf7acd0838cef80d20546/shavit-savestate.sp#L343

[mourningsickness]

actually, you should be able to get the frame cache straight from the timer snapshot that is forwarded through OnFinishPre and do whatever you want from there.. ie. save to a file, upload, etc.

[dowoge]

@mourningsickness Hypothetically speaking do you think you could give us a hand with these sourcepawn issues... Jeft and I are just as clueless as eachother and someone who knows what they're doing would help tremendously... 🙏

[mourningsickness]

@mourningsickness Hypothetically speaking do you think you could give us a hand with these sourcepawn issues... Jeft and I are just as clueless as eachother and someone who knows what they're doing would help tremendously... 🙏

is this something you want? every run's replay being sent?

if so, the lag the server endures when sending the replay due to the encoding HAS to be fixed.. i mean, it has to be anyway, it's terrible.. but especially before this is implemented.

[mourningsickness]

only reason i ask if it's something you want is because jeft said in the OP that it doesn't seem practical. did he mean getting the replay frame cache? or storing them on your end? if the former, it is so easy to do with the timer forwards.. if the latter, it might be not worth it idk. just lmk

[Jeftaei]

only reason i ask if it's something you want is because jeft said in the OP that it doesn't seem practical. did he mean getting the replay frame cache? or storing them on your end? if the former, it is so easy to do with the timer forwards.. if the latter, it might be not worth it idk. just lmk

I meant it didnt seem practical to store all of them

What will probably end up happening api side is replays will be ignored if they are too far from the wr on a map, or maybe top 10 times only and any wr replay will always be accepted.

if so, the lag the server endures when sending the replay due to the encoding HAS to be fixed.. i mean, it has to be anyway, it's terrible.. but especially before this is implemented.

Once the fix is finished, i can pre-check if a time meets the requirements to have a replay and let the plugin know before it sends the replay along

From there its just figuring out storage concerns with replays, over the past ~1-2 months the server record replays add up to about 1gb, but thats without cleaning up old/beaten replays.

Ideas are a bit all over the place right now

[mourningsickness]

gotcha, yea it can definitely be handled on the plugin side initially once something like !wrsj is implemented. it can/should update that on each map completion as well (using the Shavit_OnFinish forward). honstly, i think a wr command, the server getting the current map's times on map load, and having the top left text is the most important thing right now. handling replays and such comes after the basic functions are done imo.

once you figure out the logistics of how you want it to work, i can help make the plugin and make PRs. don't forget to finalize a name.. (and remember whirlrekrs.com (^: while thinking lol)