Skip to content

Conversation

@fandreuz
Copy link
Contributor

@fandreuz fandreuz commented Dec 7, 2025

Young and old generation are part of a heap, so they should be non-static.

Passes tier1 and tier2 (fastdebug).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367541: Parallel: Make young and old generation fields nonstatic in ParallelScavengeHeap (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28689/head:pull/28689
$ git checkout pull/28689

Update a local copy of the PR:
$ git checkout pull/28689
$ git pull https://git.openjdk.org/jdk.git pull/28689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28689

View PR using the GUI difftool:
$ git pr show -t 28689

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28689.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2025

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 7, 2025

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367541: Parallel: Make young and old generation fields nonstatic in ParallelScavengeHeap

Reviewed-by: ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3500150: 8373094: javac may fail because of unattributed break in a loop
  • 7da9153: 8369950: TLS connection to IPv6 address fails with BCJSSE due to IllegalArgumentException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 7, 2025
@openjdk
Copy link

openjdk bot commented Dec 7, 2025

@fandreuz The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2025

Webrevs

Copy link
Member

@albertnetymk albertnetymk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Collectively reviewed at UU.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2025
@fandreuz
Copy link
Contributor Author

fandreuz commented Dec 8, 2025

Thanks for the review @albertnetymk.

@fandreuz
Copy link
Contributor Author

fandreuz commented Dec 8, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

Going to push as commit a659479.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 3500150: 8373094: javac may fail because of unattributed break in a loop
  • 7da9153: 8369950: TLS connection to IPv6 address fails with BCJSSE due to IllegalArgumentException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2025
@openjdk openjdk bot closed this Dec 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@fandreuz Pushed as commit a659479.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants