From cb672ddc785faf22fa85d0512bd56316ec2fe543 Mon Sep 17 00:00:00 2001 From: Chuck Greb Date: Fri, 28 Mar 2014 03:29:24 -0400 Subject: [PATCH 01/12] Extracts configurable networking layer. * Extracts HttpEngine interface. * Uses LwHttp as default networking client. * Implements alternate networking client using OkHttp. --- vtm/build.gradle | 5 ++ .../org/oscim/tiling/source/HttpEngine.java | 19 +++++ vtm/src/org/oscim/tiling/source/LwHttp.java | 9 +-- .../org/oscim/tiling/source/OkHttpEngine.java | 70 +++++++++++++++++++ .../tiling/source/UrlTileDataSource.java | 4 +- .../oscim/tiling/source/UrlTileSource.java | 13 ++++ .../source/bitmap/BitmapTileSource.java | 2 +- .../source/oscimap4/OSciMap4TileSource.java | 3 +- .../tiling/source/UrlTileSourceTest.java | 58 +++++++++++++++ .../source/bitmap/BitmapTileSourceTest.java | 48 +++++++++++++ .../oscimap4/OSciMap4TileSourceTest.java | 42 +++++++++++ 11 files changed, 264 insertions(+), 9 deletions(-) create mode 100644 vtm/src/org/oscim/tiling/source/HttpEngine.java create mode 100644 vtm/src/org/oscim/tiling/source/OkHttpEngine.java create mode 100644 vtm/test/org/oscim/tiling/source/UrlTileSourceTest.java create mode 100644 vtm/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java create mode 100644 vtm/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java diff --git a/vtm/build.gradle b/vtm/build.gradle index 457474275..adb2f2b06 100644 --- a/vtm/build.gradle +++ b/vtm/build.gradle @@ -5,11 +5,16 @@ configurations { providedCompile } dependencies { compile 'org.slf4j:slf4j-api:1.7.6' + compile 'com.squareup.okhttp:okhttp:1.5.2' providedCompile 'com.google.code.findbugs:annotations:2.0.1' + testCompile 'junit:junit:4.11' + testCompile 'org.mockito:mockito-all:1.9.5' + testCompile 'org.easytesting:fest-assert-core:2.0M10' } sourceSets { main.java.srcDirs = ['src'] + test.java.srcDirs = ['test'] main.resources.srcDirs = ['resources'] main.compileClasspath += configurations.providedCompile } diff --git a/vtm/src/org/oscim/tiling/source/HttpEngine.java b/vtm/src/org/oscim/tiling/source/HttpEngine.java new file mode 100644 index 000000000..bf3f32401 --- /dev/null +++ b/vtm/src/org/oscim/tiling/source/HttpEngine.java @@ -0,0 +1,19 @@ +package org.oscim.tiling.source; + +import org.oscim.core.Tile; + +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; + +public interface HttpEngine { + InputStream read() throws IOException; + + boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOException; + + void close(); + + void setCache(OutputStream os); + + boolean requestCompleted(boolean success); +} diff --git a/vtm/src/org/oscim/tiling/source/LwHttp.java b/vtm/src/org/oscim/tiling/source/LwHttp.java index 66f959d9d..fd8484817 100644 --- a/vtm/src/org/oscim/tiling/source/LwHttp.java +++ b/vtm/src/org/oscim/tiling/source/LwHttp.java @@ -35,11 +35,8 @@ /** * Lightweight HTTP connection for tile loading. Does not do redirects, * https, full header parsing or stuff. - * - * TODO extract API interface to be used by UrlTileSource so that one - * could also use HttpUrlConnection, etc. */ -public class LwHttp { +public class LwHttp implements HttpEngine { static final Logger log = LoggerFactory.getLogger(LwHttp.class); static final boolean dbg = false; @@ -331,6 +328,7 @@ public InputStream read() throws IOException { return is; } + @Override public boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOException { if (mSocket != null) { @@ -404,6 +402,7 @@ private boolean lwHttpConnect() throws IOException { return true; } + @Override public void close() { if (mSocket == null) return; @@ -417,6 +416,7 @@ public void close() { mResponseStream = null; } + @Override public void setCache(OutputStream os) { if (mResponseStream == null) return; @@ -424,6 +424,7 @@ public void setCache(OutputStream os) { mResponseStream.setCache(os); } + @Override public boolean requestCompleted(boolean success) { if (mResponseStream == null) return false; diff --git a/vtm/src/org/oscim/tiling/source/OkHttpEngine.java b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java new file mode 100644 index 000000000..e68d31a08 --- /dev/null +++ b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java @@ -0,0 +1,70 @@ +package org.oscim.tiling.source; + +import com.squareup.okhttp.OkHttpClient; + +import org.oscim.core.Tile; + +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.net.HttpURLConnection; +import java.net.URL; + +public class OkHttpEngine implements HttpEngine { + private final URL baseUrl; + private final OkHttpClient client; + private InputStream inputStream; + + public OkHttpEngine(URL baseUrl) { + this.baseUrl = baseUrl; + this.client = new OkHttpClient(); + } + + @Override + public InputStream read() throws IOException { + return inputStream; + } + + @Override + public boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOException { + final URL requestUrl = new URL(baseUrl.toString() + + "/" + + Byte.toString(tile.zoomLevel) + + "/" + + tile.tileX + + "/" + + tile.tileY + + ".vtm"); + + final HttpURLConnection connection = client.open(requestUrl); + + try { + inputStream = connection.getInputStream(); + } catch (Exception e) { + e.printStackTrace(); + } + + return true; + } + + @Override + public void close() { + if (inputStream != null) { + try { + inputStream.close(); + } catch (IOException e) { + e.printStackTrace(); + } + } + } + + @Override + public void setCache(OutputStream os) { + // TODO: Evaluate OkHttp response cache and determine if additional caching is required. + } + + @Override + public boolean requestCompleted(boolean success) { + return true; + } +} diff --git a/vtm/src/org/oscim/tiling/source/UrlTileDataSource.java b/vtm/src/org/oscim/tiling/source/UrlTileDataSource.java index f26c90c00..a97272c3e 100644 --- a/vtm/src/org/oscim/tiling/source/UrlTileDataSource.java +++ b/vtm/src/org/oscim/tiling/source/UrlTileDataSource.java @@ -38,12 +38,12 @@ public class UrlTileDataSource implements ITileDataSource { static final Logger log = LoggerFactory.getLogger(UrlTileDataSource.class); - protected final LwHttp mConn; + protected final HttpEngine mConn; protected final ITileDecoder mTileDecoder; protected final UrlTileSource mTileSource; protected final boolean mUseCache; - public UrlTileDataSource(UrlTileSource tileSource, ITileDecoder tileDecoder, LwHttp conn) { + public UrlTileDataSource(UrlTileSource tileSource, ITileDecoder tileDecoder, HttpEngine conn) { mTileDecoder = tileDecoder; mTileSource = tileSource; mUseCache = (tileSource.tileCache != null); diff --git a/vtm/src/org/oscim/tiling/source/UrlTileSource.java b/vtm/src/org/oscim/tiling/source/UrlTileSource.java index 89515d14f..d6ff2b994 100644 --- a/vtm/src/org/oscim/tiling/source/UrlTileSource.java +++ b/vtm/src/org/oscim/tiling/source/UrlTileSource.java @@ -26,6 +26,7 @@ public abstract class UrlTileSource extends TileSource { private final URL mUrl; private byte[] mExt; + private HttpEngine httpEngine; public UrlTileSource(String urlString) { URL url = null; @@ -107,4 +108,16 @@ public int formatTilePath(Tile tile, byte[] buf, int pos) { public URL getUrl() { return mUrl; } + + public void setHttpEngine(HttpEngine httpEngine) { + this.httpEngine = httpEngine; + } + + public HttpEngine getHttpEngine() { + if (httpEngine == null) { + httpEngine = new LwHttp(getUrl()); + } + + return httpEngine; + } } diff --git a/vtm/src/org/oscim/tiling/source/bitmap/BitmapTileSource.java b/vtm/src/org/oscim/tiling/source/bitmap/BitmapTileSource.java index 92a718de5..40197f631 100644 --- a/vtm/src/org/oscim/tiling/source/bitmap/BitmapTileSource.java +++ b/vtm/src/org/oscim/tiling/source/bitmap/BitmapTileSource.java @@ -32,7 +32,7 @@ public BitmapTileSource(String url, int zoomMin, int zoomMax) { @Override public ITileDataSource getDataSource() { - return new UrlTileDataSource(this, new BitmapTileDecoder(), new LwHttp(getUrl())); + return new UrlTileDataSource(this, new BitmapTileDecoder(), getHttpEngine()); } public class BitmapTileDecoder implements ITileDecoder { diff --git a/vtm/src/org/oscim/tiling/source/oscimap4/OSciMap4TileSource.java b/vtm/src/org/oscim/tiling/source/oscimap4/OSciMap4TileSource.java index b5dbc5a8d..3d2788a7f 100644 --- a/vtm/src/org/oscim/tiling/source/oscimap4/OSciMap4TileSource.java +++ b/vtm/src/org/oscim/tiling/source/oscimap4/OSciMap4TileSource.java @@ -17,7 +17,6 @@ package org.oscim.tiling.source.oscimap4; import org.oscim.tiling.ITileDataSource; -import org.oscim.tiling.source.LwHttp; import org.oscim.tiling.source.UrlTileDataSource; import org.oscim.tiling.source.UrlTileSource; @@ -34,6 +33,6 @@ public OSciMap4TileSource(String url) { @Override public ITileDataSource getDataSource() { - return new UrlTileDataSource(this, new TileDecoder(), new LwHttp(getUrl())); + return new UrlTileDataSource(this, new TileDecoder(), getHttpEngine()); } } diff --git a/vtm/test/org/oscim/tiling/source/UrlTileSourceTest.java b/vtm/test/org/oscim/tiling/source/UrlTileSourceTest.java new file mode 100644 index 000000000..b708cb404 --- /dev/null +++ b/vtm/test/org/oscim/tiling/source/UrlTileSourceTest.java @@ -0,0 +1,58 @@ +package org.oscim.tiling.source; + +import com.squareup.okhttp.OkHttpClient; + +import org.junit.Before; +import org.junit.Test; +import org.oscim.tiling.ITileDataSource; + +import static org.fest.assertions.api.Assertions.assertThat; + +public class UrlTileSourceTest { + private UrlTileSource tileSource; + + @Before + public void setUp() throws Exception { + tileSource = new TestTileSource("http://example.org/tiles/vtm"); + } + + @Test + public void shouldNotBeNull() throws Exception { + assertThat(tileSource).isNotNull(); + } + + @Test + public void shouldUseDefaultHttpEngine() throws Exception { + TestTileDataSource dataSource = (TestTileDataSource) tileSource.getDataSource(); + assertThat(dataSource.getConnection()).isInstanceOf(LwHttp.class); + } + + @Test + public void shouldUseCustomHttpEngine() throws Exception { + tileSource.setHttpEngine(new OkHttpEngine(tileSource.getUrl())); + TestTileDataSource dataSource = (TestTileDataSource) tileSource.getDataSource(); + assertThat(dataSource.getConnection()).isInstanceOf(OkHttpEngine.class); + } + + class TestTileSource extends UrlTileSource { + public TestTileSource(String urlString) { + super(urlString); + } + + @Override + public ITileDataSource getDataSource() { + return new TestTileDataSource(this, null, getHttpEngine()); + } + } + + class TestTileDataSource extends UrlTileDataSource { + public TestTileDataSource(UrlTileSource tileSource, ITileDecoder tileDecoder, + HttpEngine conn) { + super(tileSource, tileDecoder, conn); + } + + public HttpEngine getConnection() { + return mConn; + } + } +} diff --git a/vtm/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java b/vtm/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java new file mode 100644 index 000000000..8fde2545a --- /dev/null +++ b/vtm/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java @@ -0,0 +1,48 @@ +package org.oscim.tiling.source.bitmap; + +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mockito; +import org.oscim.tiling.ITileDataSource; +import org.oscim.tiling.source.LwHttp; +import org.oscim.tiling.source.OkHttpEngine; + +import static org.fest.assertions.api.Assertions.assertThat; + +public class BitmapTileSourceTest { + private BitmapTileSource tileSource; + + @Before + public void setUp() throws Exception { + tileSource = new TestBitmapTileSource("http://tile.openstreetmap.org", 0, 18); + } + + @Test + public void shouldNotBeNull() throws Exception { + assertThat(tileSource).isNotNull(); + } + + @Test + public void shouldUseLwHttp() throws Exception { + LwHttp lwHttp = Mockito.mock(LwHttp.class); + tileSource.setHttpEngine(lwHttp); + ITileDataSource dataSource = tileSource.getDataSource(); + dataSource.destroy(); + Mockito.verify(lwHttp).close(); + } + + @Test + public void shouldUseOkHttp() throws Exception { + OkHttpEngine okHttp = Mockito.mock(OkHttpEngine.class); + tileSource.setHttpEngine(okHttp); + ITileDataSource dataSource = tileSource.getDataSource(); + dataSource.destroy(); + Mockito.verify(okHttp).close(); + } + + class TestBitmapTileSource extends BitmapTileSource { + public TestBitmapTileSource(String url, int zoomMin, int zoomMax) { + super(url, zoomMin, zoomMax); + } + } +} diff --git a/vtm/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java b/vtm/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java new file mode 100644 index 000000000..711cd3108 --- /dev/null +++ b/vtm/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java @@ -0,0 +1,42 @@ +package org.oscim.tiling.source.oscimap4; + +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mockito; +import org.oscim.tiling.ITileDataSource; +import org.oscim.tiling.source.LwHttp; +import org.oscim.tiling.source.OkHttpEngine; + +import static org.fest.assertions.api.Assertions.assertThat; + +public class OSciMap4TileSourceTest { + private OSciMap4TileSource tileSource; + + @Before + public void setUp() throws Exception { + tileSource = new OSciMap4TileSource("http://www.example.org/tiles/vtm"); + } + + @Test + public void shouldNotBeNull() throws Exception { + assertThat(tileSource).isNotNull(); + } + + @Test + public void shouldUseLwHttp() throws Exception { + LwHttp lwHttp = Mockito.mock(LwHttp.class); + tileSource.setHttpEngine(lwHttp); + ITileDataSource dataSource = tileSource.getDataSource(); + dataSource.destroy(); + Mockito.verify(lwHttp).close(); + } + + @Test + public void shouldUseOkHttp() throws Exception { + OkHttpEngine okHttp = Mockito.mock(OkHttpEngine.class); + tileSource.setHttpEngine(okHttp); + ITileDataSource dataSource = tileSource.getDataSource(); + dataSource.destroy(); + Mockito.verify(okHttp).close(); + } +} From 377f1987ae9cc8224ce1557bfee59690411e6c1f Mon Sep 17 00:00:00 2001 From: Chuck Greb Date: Fri, 28 Mar 2014 15:57:31 -0400 Subject: [PATCH 02/12] Tests OkHttp integration --- vtm/build.gradle | 1 + .../org/oscim/tiling/source/OkHttpEngine.java | 7 +- .../oscim/tiling/source/OkHttpEngineTest.java | 97 +++++++++++++++++++ 3 files changed, 104 insertions(+), 1 deletion(-) create mode 100644 vtm/test/org/oscim/tiling/source/OkHttpEngineTest.java diff --git a/vtm/build.gradle b/vtm/build.gradle index adb2f2b06..f27d0b200 100644 --- a/vtm/build.gradle +++ b/vtm/build.gradle @@ -10,6 +10,7 @@ dependencies { testCompile 'junit:junit:4.11' testCompile 'org.mockito:mockito-all:1.9.5' testCompile 'org.easytesting:fest-assert-core:2.0M10' + testCompile 'com.squareup.okhttp:mockwebserver:1.5.2' } sourceSets { diff --git a/vtm/src/org/oscim/tiling/source/OkHttpEngine.java b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java index e68d31a08..6c5dc4237 100644 --- a/vtm/src/org/oscim/tiling/source/OkHttpEngine.java +++ b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java @@ -27,6 +27,10 @@ public InputStream read() throws IOException { @Override public boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOException { + if (tile == null) { + throw new IllegalArgumentException("Tile cannot be null."); + } + final URL requestUrl = new URL(baseUrl.toString() + "/" + Byte.toString(tile.zoomLevel) @@ -65,6 +69,7 @@ public void setCache(OutputStream os) { @Override public boolean requestCompleted(boolean success) { - return true; + close(); + return success; } } diff --git a/vtm/test/org/oscim/tiling/source/OkHttpEngineTest.java b/vtm/test/org/oscim/tiling/source/OkHttpEngineTest.java new file mode 100644 index 000000000..d97aef2c3 --- /dev/null +++ b/vtm/test/org/oscim/tiling/source/OkHttpEngineTest.java @@ -0,0 +1,97 @@ +package org.oscim.tiling.source; + +import com.squareup.okhttp.mockwebserver.MockResponse; +import com.squareup.okhttp.mockwebserver.MockWebServer; +import com.squareup.okhttp.mockwebserver.RecordedRequest; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.oscim.core.Tile; +import org.oscim.tiling.source.oscimap4.OSciMap4TileSource; + +import java.io.BufferedReader; +import java.io.IOException; +import java.io.InputStream; +import java.io.InputStreamReader; +import java.net.URL; + +import static org.fest.assertions.api.Assertions.assertThat; + +public class OkHttpEngineTest { + private OkHttpEngine engine; + private MockWebServer server; + private MockResponse mockResponse; + + @Before + public void setUp() throws Exception { + mockResponse = new MockResponse(); + mockResponse.setBody("TEST RESPONSE".getBytes()); + server = new MockWebServer(); + server.enqueue(mockResponse); + server.play(); + engine = new OkHttpEngine(server.getUrl("/tiles/vtm")); + } + + @After + public void tearDown() throws Exception { + server.shutdown(); + } + + @Test + public void shouldNotBeNull() throws Exception { + assertThat(engine).isNotNull(); + } + + @Test(expected = IllegalArgumentException.class) + public void sendRequest_shouldRejectNullTile() throws Exception { + engine.sendRequest(null, null); + } + + @Test + public void sendRequest_shouldAppendXYZToPath() throws Exception { + engine.sendRequest(new OSciMap4TileSource("http://www.example.org/tiles/vtm"), + new Tile(1, 2, new Integer(3).byteValue())); + + RecordedRequest request = server.takeRequest(); + assertThat(request.getPath()).isEqualTo("/tiles/vtm/3/1/2.vtm"); + } + + @Test + public void read_shouldReturnResponseStream() throws Exception { + engine.sendRequest(new OSciMap4TileSource("http://www.example.org/tiles/vtm"), + new Tile(1, 2, new Integer(3).byteValue())); + + InputStream responseStream = engine.read(); + String response = new BufferedReader(new InputStreamReader(responseStream)).readLine(); + assertThat(response).isEqualTo("TEST RESPONSE"); + } + + @Test(expected = IOException.class) + public void close_shouldCloseInputStream() throws Exception { + engine.sendRequest(new OSciMap4TileSource("http://www.example.org/tiles/vtm"), + new Tile(1, 2, new Integer(3).byteValue())); + engine.close(); + + // Calling read after the stream is closed should throw an exception. + InputStream responseStream = engine.read(); + responseStream.read(); + } + + @Test(expected = IOException.class) + public void requestCompleted_shouldCloseInputStream() throws Exception { + engine.sendRequest(new OSciMap4TileSource("http://www.example.org/tiles/vtm"), + new Tile(1, 2, new Integer(3).byteValue())); + engine.requestCompleted(true); + + // Calling read after the stream is closed should throw an exception. + InputStream responseStream = engine.read(); + responseStream.read(); + } + + @Test + public void requestCompleted_shouldReturnValueGiven() throws Exception { + assertThat(engine.requestCompleted(true)).isTrue(); + assertThat(engine.requestCompleted(false)).isFalse(); + } +} From 20d76abc291484af747abadcaaa63e9d32aa0652 Mon Sep 17 00:00:00 2001 From: Hannes Janetzek Date: Sat, 29 Mar 2014 01:35:59 +0100 Subject: [PATCH 03/12] create HttpEngine instances for each loader thread --- .../org/oscim/tiling/source/HttpEngine.java | 19 +++++--- .../org/oscim/tiling/source/OkHttpEngine.java | 44 ++++++++++++------- .../oscim/tiling/source/UrlTileSource.java | 12 ++--- 3 files changed, 46 insertions(+), 29 deletions(-) diff --git a/vtm/src/org/oscim/tiling/source/HttpEngine.java b/vtm/src/org/oscim/tiling/source/HttpEngine.java index bf3f32401..a843a1d66 100644 --- a/vtm/src/org/oscim/tiling/source/HttpEngine.java +++ b/vtm/src/org/oscim/tiling/source/HttpEngine.java @@ -1,19 +1,24 @@ package org.oscim.tiling.source; -import org.oscim.core.Tile; - import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; +import org.oscim.core.Tile; + public interface HttpEngine { - InputStream read() throws IOException; - boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOException; + InputStream read() throws IOException; + + boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOException; + + void close(); - void close(); + void setCache(OutputStream os); - void setCache(OutputStream os); + boolean requestCompleted(boolean success); - boolean requestCompleted(boolean success); + public interface Factory { + public HttpEngine create(); + } } diff --git a/vtm/src/org/oscim/tiling/source/OkHttpEngine.java b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java index 6c5dc4237..2f4c73498 100644 --- a/vtm/src/org/oscim/tiling/source/OkHttpEngine.java +++ b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java @@ -1,23 +1,35 @@ package org.oscim.tiling.source; -import com.squareup.okhttp.OkHttpClient; - -import org.oscim.core.Tile; - import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; import java.net.HttpURLConnection; import java.net.URL; +import org.oscim.core.Tile; + +import com.squareup.okhttp.OkHttpClient; + public class OkHttpEngine implements HttpEngine { - private final URL baseUrl; private final OkHttpClient client; + + public static class OkHttpFactory implements HttpEngine.Factory { + private final OkHttpClient client; + + public OkHttpFactory() { + this.client = new OkHttpClient(); + } + + @Override + public HttpEngine create() { + return new OkHttpEngine(client); + } + } + private InputStream inputStream; - public OkHttpEngine(URL baseUrl) { - this.baseUrl = baseUrl; - this.client = new OkHttpClient(); + public OkHttpEngine(OkHttpClient client) { + this.client = client; } @Override @@ -31,14 +43,14 @@ public boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOExcepti throw new IllegalArgumentException("Tile cannot be null."); } - final URL requestUrl = new URL(baseUrl.toString() - + "/" - + Byte.toString(tile.zoomLevel) - + "/" - + tile.tileX - + "/" - + tile.tileY - + ".vtm"); + final URL requestUrl = new URL(tileSource.getUrl() + + "/" + + Byte.toString(tile.zoomLevel) + + "/" + + tile.tileX + + "/" + + tile.tileY + + ".vtm"); final HttpURLConnection connection = client.open(requestUrl); diff --git a/vtm/src/org/oscim/tiling/source/UrlTileSource.java b/vtm/src/org/oscim/tiling/source/UrlTileSource.java index d6ff2b994..3d00bbd46 100644 --- a/vtm/src/org/oscim/tiling/source/UrlTileSource.java +++ b/vtm/src/org/oscim/tiling/source/UrlTileSource.java @@ -26,7 +26,7 @@ public abstract class UrlTileSource extends TileSource { private final URL mUrl; private byte[] mExt; - private HttpEngine httpEngine; + private HttpEngine.Factory mHttpFactory; public UrlTileSource(String urlString) { URL url = null; @@ -109,15 +109,15 @@ public URL getUrl() { return mUrl; } - public void setHttpEngine(HttpEngine httpEngine) { - this.httpEngine = httpEngine; + public void setHttpEngine(HttpEngine.Factory httpFactory) { + mHttpFactory = httpFactory; } public HttpEngine getHttpEngine() { - if (httpEngine == null) { - httpEngine = new LwHttp(getUrl()); + if (mHttpFactory == null) { + return new LwHttp(getUrl()); } - return httpEngine; + return mHttpFactory.create(); } } From 1aa740fed50a7ff6c9ac84611fe14ff4549238ca Mon Sep 17 00:00:00 2001 From: Hannes Janetzek Date: Sat, 29 Mar 2014 01:42:30 +0100 Subject: [PATCH 04/12] example: testing OkHttp --- .../src/org/oscim/android/test/BaseMapActivity.java | 8 +++++--- .../org/oscim/android/test/BitmapTileMapActivity.java | 10 ++++++---- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/vtm-android-example/src/org/oscim/android/test/BaseMapActivity.java b/vtm-android-example/src/org/oscim/android/test/BaseMapActivity.java index 8f74553f3..64020f980 100644 --- a/vtm-android-example/src/org/oscim/android/test/BaseMapActivity.java +++ b/vtm-android-example/src/org/oscim/android/test/BaseMapActivity.java @@ -22,7 +22,8 @@ import org.oscim.core.MapPosition; import org.oscim.layers.tile.vector.VectorTileLayer; import org.oscim.theme.VtmThemes; -import org.oscim.tiling.TileSource; +import org.oscim.tiling.source.OkHttpEngine.OkHttpFactory; +import org.oscim.tiling.source.UrlTileSource; import org.oscim.tiling.source.oscimap4.OSciMap4TileSource; import android.os.Bundle; @@ -31,11 +32,11 @@ public class BaseMapActivity extends MapActivity { - final static boolean USE_CACHE = true; + final static boolean USE_CACHE = false; MapView mMapView; VectorTileLayer mBaseLayer; - TileSource mTileSource; + UrlTileSource mTileSource; private TileCache mCache; @@ -58,6 +59,7 @@ public void onCreate(Bundle savedInstanceState) { registerMapView(mMapView); mTileSource = new OSciMap4TileSource(); + mTileSource.setHttpEngine(new OkHttpFactory()); if (USE_CACHE) { mCache = new TileCache(this, null, "tile.db"); diff --git a/vtm-android-example/src/org/oscim/android/test/BitmapTileMapActivity.java b/vtm-android-example/src/org/oscim/android/test/BitmapTileMapActivity.java index 035b88121..e27491f89 100644 --- a/vtm-android-example/src/org/oscim/android/test/BitmapTileMapActivity.java +++ b/vtm-android-example/src/org/oscim/android/test/BitmapTileMapActivity.java @@ -21,22 +21,23 @@ import org.oscim.layers.TileGridLayer; import org.oscim.layers.tile.bitmap.BitmapTileLayer; import org.oscim.renderer.MapRenderer; -import org.oscim.tiling.TileSource; +import org.oscim.tiling.source.OkHttpEngine.OkHttpFactory; +import org.oscim.tiling.source.bitmap.BitmapTileSource; import org.oscim.tiling.source.bitmap.DefaultSources; import android.os.Bundle; public class BitmapTileMapActivity extends MapActivity { - private final static boolean USE_CACHE = true; - private final TileSource mTileSource; + private final static boolean USE_CACHE = false; + private final BitmapTileSource mTileSource; protected BitmapTileLayer mBitmapLayer; public BitmapTileMapActivity() { mTileSource = new DefaultSources.OpenStreetMap(); } - public BitmapTileMapActivity(TileSource tileSource) { + public BitmapTileMapActivity(BitmapTileSource tileSource) { mTileSource = tileSource; } @@ -61,6 +62,7 @@ public void onCreate(Bundle savedInstanceState) { mTileSource.setCache(mCache); } + mTileSource.setHttpEngine(new OkHttpFactory()); mBitmapLayer = new BitmapTileLayer(mMap, mTileSource); mMap.layers().add(mBitmapLayer); } From 4053628376de47703d1296a63a23707657136d9d Mon Sep 17 00:00:00 2001 From: Hannes Janetzek Date: Sat, 29 Mar 2014 12:54:12 +0100 Subject: [PATCH 05/12] move tests to separate project --- settings.gradle | 1 + vtm-tests/build.gradle | 15 +++++++++++++++ .../oscim/tiling/source/OkHttpEngineTest.java | 0 .../oscim/tiling/source/UrlTileSourceTest.java | 0 .../source/bitmap/BitmapTileSourceTest.java | 16 ++++++++-------- .../source/oscimap4/OSciMap4TileSourceTest.java | 0 vtm/build.gradle | 5 ----- 7 files changed, 24 insertions(+), 13 deletions(-) create mode 100644 vtm-tests/build.gradle rename {vtm => vtm-tests}/test/org/oscim/tiling/source/OkHttpEngineTest.java (100%) rename {vtm => vtm-tests}/test/org/oscim/tiling/source/UrlTileSourceTest.java (100%) rename {vtm => vtm-tests}/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java (74%) rename {vtm => vtm-tests}/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java (100%) diff --git a/settings.gradle b/settings.gradle index 3cbd0ee17..06ecb65de 100644 --- a/settings.gradle +++ b/settings.gradle @@ -1,4 +1,5 @@ include ':vtm' +include ':vtm-tests' include ':vtm-extras' include ':vtm-android' include ':vtm-android-example' diff --git a/vtm-tests/build.gradle b/vtm-tests/build.gradle new file mode 100644 index 000000000..3acb62855 --- /dev/null +++ b/vtm-tests/build.gradle @@ -0,0 +1,15 @@ +apply plugin: 'java' +apply plugin: 'maven' + +dependencies { + compile project(':vtm') + testCompile 'junit:junit:4.11' + testCompile 'org.mockito:mockito-all:1.9.5' + testCompile 'org.easytesting:fest-assert-core:2.0M10' + testCompile 'com.squareup.okhttp:mockwebserver:1.5.2' +} + +sourceSets { + main.java.srcDirs = ['src'] + test.java.srcDirs = ['test'] +} diff --git a/vtm/test/org/oscim/tiling/source/OkHttpEngineTest.java b/vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java similarity index 100% rename from vtm/test/org/oscim/tiling/source/OkHttpEngineTest.java rename to vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java diff --git a/vtm/test/org/oscim/tiling/source/UrlTileSourceTest.java b/vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java similarity index 100% rename from vtm/test/org/oscim/tiling/source/UrlTileSourceTest.java rename to vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java diff --git a/vtm/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java b/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java similarity index 74% rename from vtm/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java rename to vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java index 8fde2545a..34f87ce56 100644 --- a/vtm/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java +++ b/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java @@ -1,13 +1,13 @@ package org.oscim.tiling.source.bitmap; +import static org.fest.assertions.api.Assertions.assertThat; + import org.junit.Before; import org.junit.Test; import org.mockito.Mockito; import org.oscim.tiling.ITileDataSource; -import org.oscim.tiling.source.LwHttp; -import org.oscim.tiling.source.OkHttpEngine; - -import static org.fest.assertions.api.Assertions.assertThat; +import org.oscim.tiling.source.OkHttpEngine.OkHttpFactory; +import org.oscim.tiling.source.UrlTileDataSource; public class BitmapTileSourceTest { private BitmapTileSource tileSource; @@ -24,7 +24,7 @@ public void shouldNotBeNull() throws Exception { @Test public void shouldUseLwHttp() throws Exception { - LwHttp lwHttp = Mockito.mock(LwHttp.class); + LwHttpFactory lwHttp = Mockito.mock(LwHttpFactory.class); tileSource.setHttpEngine(lwHttp); ITileDataSource dataSource = tileSource.getDataSource(); dataSource.destroy(); @@ -33,11 +33,11 @@ public void shouldUseLwHttp() throws Exception { @Test public void shouldUseOkHttp() throws Exception { - OkHttpEngine okHttp = Mockito.mock(OkHttpEngine.class); + OkHttpFactory okHttp = Mockito.mock(OkHttpFactory.class); tileSource.setHttpEngine(okHttp); - ITileDataSource dataSource = tileSource.getDataSource(); + UrlTileDataSource dataSource = (UrlTileDataSource) tileSource.getDataSource(); dataSource.destroy(); - Mockito.verify(okHttp).close(); + //Mockito.verify(dataSource.mConn).close(); } class TestBitmapTileSource extends BitmapTileSource { diff --git a/vtm/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java b/vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java similarity index 100% rename from vtm/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java rename to vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java diff --git a/vtm/build.gradle b/vtm/build.gradle index f27d0b200..6f148d819 100644 --- a/vtm/build.gradle +++ b/vtm/build.gradle @@ -7,15 +7,10 @@ dependencies { compile 'org.slf4j:slf4j-api:1.7.6' compile 'com.squareup.okhttp:okhttp:1.5.2' providedCompile 'com.google.code.findbugs:annotations:2.0.1' - testCompile 'junit:junit:4.11' - testCompile 'org.mockito:mockito-all:1.9.5' - testCompile 'org.easytesting:fest-assert-core:2.0M10' - testCompile 'com.squareup.okhttp:mockwebserver:1.5.2' } sourceSets { main.java.srcDirs = ['src'] - test.java.srcDirs = ['test'] main.resources.srcDirs = ['resources'] main.compileClasspath += configurations.providedCompile } From 0e823eb17a72d7aaa0ca26aaf10c510504961bac Mon Sep 17 00:00:00 2001 From: Chuck Greb Date: Mon, 31 Mar 2014 13:09:06 -0400 Subject: [PATCH 06/12] Fixes HttpEngine tests --- .../oscim/tiling/source/OkHttpEngineTest.java | 11 +++---- .../tiling/source/UrlTileSourceTest.java | 4 +-- .../source/bitmap/BitmapTileSourceTest.java | 32 +++++++++++++------ .../oscimap4/OSciMap4TileSourceTest.java | 21 ++++++++++-- 4 files changed, 47 insertions(+), 21 deletions(-) diff --git a/vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java b/vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java index d97aef2c3..45ff6b899 100644 --- a/vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java +++ b/vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java @@ -14,7 +14,6 @@ import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; -import java.net.URL; import static org.fest.assertions.api.Assertions.assertThat; @@ -30,7 +29,7 @@ public void setUp() throws Exception { server = new MockWebServer(); server.enqueue(mockResponse); server.play(); - engine = new OkHttpEngine(server.getUrl("/tiles/vtm")); + engine = (OkHttpEngine) new OkHttpEngine.OkHttpFactory().create(); } @After @@ -50,7 +49,7 @@ public void sendRequest_shouldRejectNullTile() throws Exception { @Test public void sendRequest_shouldAppendXYZToPath() throws Exception { - engine.sendRequest(new OSciMap4TileSource("http://www.example.org/tiles/vtm"), + engine.sendRequest(new OSciMap4TileSource(server.getUrl("/tiles/vtm").toString()), new Tile(1, 2, new Integer(3).byteValue())); RecordedRequest request = server.takeRequest(); @@ -59,7 +58,7 @@ public void sendRequest_shouldAppendXYZToPath() throws Exception { @Test public void read_shouldReturnResponseStream() throws Exception { - engine.sendRequest(new OSciMap4TileSource("http://www.example.org/tiles/vtm"), + engine.sendRequest(new OSciMap4TileSource(server.getUrl("/tiles/vtm").toString()), new Tile(1, 2, new Integer(3).byteValue())); InputStream responseStream = engine.read(); @@ -69,7 +68,7 @@ public void read_shouldReturnResponseStream() throws Exception { @Test(expected = IOException.class) public void close_shouldCloseInputStream() throws Exception { - engine.sendRequest(new OSciMap4TileSource("http://www.example.org/tiles/vtm"), + engine.sendRequest(new OSciMap4TileSource(server.getUrl("/tiles/vtm").toString()), new Tile(1, 2, new Integer(3).byteValue())); engine.close(); @@ -80,7 +79,7 @@ public void close_shouldCloseInputStream() throws Exception { @Test(expected = IOException.class) public void requestCompleted_shouldCloseInputStream() throws Exception { - engine.sendRequest(new OSciMap4TileSource("http://www.example.org/tiles/vtm"), + engine.sendRequest(new OSciMap4TileSource(server.getUrl("/tiles/vtm").toString()), new Tile(1, 2, new Integer(3).byteValue())); engine.requestCompleted(true); diff --git a/vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java b/vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java index b708cb404..395738c6a 100644 --- a/vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java +++ b/vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java @@ -1,7 +1,5 @@ package org.oscim.tiling.source; -import com.squareup.okhttp.OkHttpClient; - import org.junit.Before; import org.junit.Test; import org.oscim.tiling.ITileDataSource; @@ -29,7 +27,7 @@ public void shouldUseDefaultHttpEngine() throws Exception { @Test public void shouldUseCustomHttpEngine() throws Exception { - tileSource.setHttpEngine(new OkHttpEngine(tileSource.getUrl())); + tileSource.setHttpEngine(new OkHttpEngine.OkHttpFactory()); TestTileDataSource dataSource = (TestTileDataSource) tileSource.getDataSource(); assertThat(dataSource.getConnection()).isInstanceOf(OkHttpEngine.class); } diff --git a/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java b/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java index 34f87ce56..f0f93560e 100644 --- a/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java +++ b/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java @@ -6,7 +6,9 @@ import org.junit.Test; import org.mockito.Mockito; import org.oscim.tiling.ITileDataSource; -import org.oscim.tiling.source.OkHttpEngine.OkHttpFactory; +import org.oscim.tiling.source.HttpEngine; +import org.oscim.tiling.source.LwHttp; +import org.oscim.tiling.source.OkHttpEngine; import org.oscim.tiling.source.UrlTileDataSource; public class BitmapTileSourceTest { @@ -14,7 +16,7 @@ public class BitmapTileSourceTest { @Before public void setUp() throws Exception { - tileSource = new TestBitmapTileSource("http://tile.openstreetmap.org", 0, 18); + tileSource = new BitmapTileSource("http://tile.openstreetmap.org", 0, 18); } @Test @@ -24,8 +26,8 @@ public void shouldNotBeNull() throws Exception { @Test public void shouldUseLwHttp() throws Exception { - LwHttpFactory lwHttp = Mockito.mock(LwHttpFactory.class); - tileSource.setHttpEngine(lwHttp); + LwHttp lwHttp = Mockito.mock(LwHttp.class); + tileSource.setHttpEngine(new TestHttpFactory(lwHttp)); ITileDataSource dataSource = tileSource.getDataSource(); dataSource.destroy(); Mockito.verify(lwHttp).close(); @@ -33,16 +35,26 @@ public void shouldUseLwHttp() throws Exception { @Test public void shouldUseOkHttp() throws Exception { - OkHttpFactory okHttp = Mockito.mock(OkHttpFactory.class); - tileSource.setHttpEngine(okHttp); + OkHttpEngine okHttp = Mockito.mock(OkHttpEngine.class); + tileSource.setHttpEngine(new TestHttpFactory(okHttp)); UrlTileDataSource dataSource = (UrlTileDataSource) tileSource.getDataSource(); dataSource.destroy(); - //Mockito.verify(dataSource.mConn).close(); + Mockito.verify(okHttp).close(); } - class TestBitmapTileSource extends BitmapTileSource { - public TestBitmapTileSource(String url, int zoomMin, int zoomMax) { - super(url, zoomMin, zoomMax); + /** + * Test factory that allows the specific {@link HttpEngine} instance to be set. + */ + class TestHttpFactory implements HttpEngine.Factory { + final HttpEngine engine; + + public TestHttpFactory(HttpEngine engine) { + this.engine = engine; + } + + @Override + public HttpEngine create() { + return engine; } } } diff --git a/vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java b/vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java index 711cd3108..060d0c77e 100644 --- a/vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java +++ b/vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java @@ -4,6 +4,7 @@ import org.junit.Test; import org.mockito.Mockito; import org.oscim.tiling.ITileDataSource; +import org.oscim.tiling.source.HttpEngine; import org.oscim.tiling.source.LwHttp; import org.oscim.tiling.source.OkHttpEngine; @@ -25,7 +26,7 @@ public void shouldNotBeNull() throws Exception { @Test public void shouldUseLwHttp() throws Exception { LwHttp lwHttp = Mockito.mock(LwHttp.class); - tileSource.setHttpEngine(lwHttp); + tileSource.setHttpEngine(new TestHttpFactory(lwHttp)); ITileDataSource dataSource = tileSource.getDataSource(); dataSource.destroy(); Mockito.verify(lwHttp).close(); @@ -34,9 +35,25 @@ public void shouldUseLwHttp() throws Exception { @Test public void shouldUseOkHttp() throws Exception { OkHttpEngine okHttp = Mockito.mock(OkHttpEngine.class); - tileSource.setHttpEngine(okHttp); + tileSource.setHttpEngine(new TestHttpFactory(okHttp)); ITileDataSource dataSource = tileSource.getDataSource(); dataSource.destroy(); Mockito.verify(okHttp).close(); } + + /** + * Test factory that allows the specific {@link HttpEngine} instance to be set. + */ + class TestHttpFactory implements HttpEngine.Factory { + final HttpEngine engine; + + public TestHttpFactory(HttpEngine engine) { + this.engine = engine; + } + + @Override + public HttpEngine create() { + return engine; + } + } } From 6f3c950b96319a76702fd48a01dbae8f77003007 Mon Sep 17 00:00:00 2001 From: Hannes Janetzek Date: Tue, 1 Apr 2014 03:25:00 +0200 Subject: [PATCH 07/12] okhttp: use tileSource.getTileUrl() --- .../org/oscim/tiling/source/OkHttpEngine.java | 32 ++++++++++--------- .../oscim/tiling/source/UrlTileSource.java | 19 +++++++---- 2 files changed, 30 insertions(+), 21 deletions(-) diff --git a/vtm/src/org/oscim/tiling/source/OkHttpEngine.java b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java index 2f4c73498..d8ae79512 100644 --- a/vtm/src/org/oscim/tiling/source/OkHttpEngine.java +++ b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java @@ -43,23 +43,25 @@ public boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOExcepti throw new IllegalArgumentException("Tile cannot be null."); } - final URL requestUrl = new URL(tileSource.getUrl() - + "/" - + Byte.toString(tile.zoomLevel) - + "/" - + tile.tileX - + "/" - + tile.tileY - + ".vtm"); - - final HttpURLConnection connection = client.open(requestUrl); - - try { - inputStream = connection.getInputStream(); - } catch (Exception e) { - e.printStackTrace(); + StringBuilder sb = new StringBuilder(); + sb.append(tileSource.getUrl()); + String path = tileSource.getTileUrl(tile); + if (path == null) { + sb.append('/'); + sb.append(tile.zoomLevel); + sb.append('/'); + sb.append(tile.tileX); + sb.append('/'); + sb.append(tile.tileY); + sb.append(tileSource.getExtension()); + } else { + sb.append(path); } + final HttpURLConnection connection = client.open(new URL(sb.toString())); + + inputStream = connection.getInputStream(); + return true; } diff --git a/vtm/src/org/oscim/tiling/source/UrlTileSource.java b/vtm/src/org/oscim/tiling/source/UrlTileSource.java index 3d00bbd46..6fee96a6c 100644 --- a/vtm/src/org/oscim/tiling/source/UrlTileSource.java +++ b/vtm/src/org/oscim/tiling/source/UrlTileSource.java @@ -25,7 +25,9 @@ public abstract class UrlTileSource extends TileSource { private final URL mUrl; - private byte[] mExt; + private byte[] mExtBytes; + private String mExtString; + private HttpEngine.Factory mHttpFactory; public UrlTileSource(String urlString) { @@ -55,11 +57,12 @@ public void close() { } protected void setExtension(String ext) { + mExtString = ext; if (ext == null) { - mExt = null; + mExtBytes = null; return; } - mExt = ext.getBytes(); + mExtBytes = ext.getBytes(); } protected void setMimeType(String string) { @@ -98,11 +101,11 @@ public int formatTilePath(Tile tile, byte[] buf, int pos) { pos = LwHttp.writeInt(tile.tileX, pos, buf); buf[pos++] = '/'; pos = LwHttp.writeInt(tile.tileY, pos, buf); - if (mExt == null) + if (mExtBytes == null) return pos; - System.arraycopy(mExt, 0, buf, pos, mExt.length); - return pos + mExt.length; + System.arraycopy(mExtBytes, 0, buf, pos, mExtBytes.length); + return pos + mExtBytes.length; } public URL getUrl() { @@ -120,4 +123,8 @@ public HttpEngine getHttpEngine() { return mHttpFactory.create(); } + + public String getExtension() { + return mExtString == null ? "" : mExtString; + } } From 412181101366fd5c829dea49dd72659088785fb6 Mon Sep 17 00:00:00 2001 From: Hannes Janetzek Date: Wed, 2 Apr 2014 06:53:47 +0200 Subject: [PATCH 08/12] api: UrlTileSource - use replacement string for tilePath - move 'low-level' formatTilePath to LwHttp - implement LwHttpFactory --- .../source/geojson/GeoJsonTileSource.java | 9 +- .../source/mapnik/MapnikVectorTileSource.java | 4 +- .../source/oscimap/OSciMap1TileSource.java | 7 +- .../source/oscimap2/OSciMap2TileSource.java | 7 +- .../org/oscim/tiling/source/HttpEngine.java | 5 +- vtm/src/org/oscim/tiling/source/LwHttp.java | 66 +++++++--- .../org/oscim/tiling/source/OkHttpEngine.java | 41 +++--- .../tiling/source/UrlTileDataSource.java | 2 +- .../oscim/tiling/source/UrlTileSource.java | 121 ++++++++---------- .../source/bitmap/BitmapTileSource.java | 11 +- .../tiling/source/bitmap/DefaultSources.java | 55 ++------ .../source/oscimap4/OSciMap4TileSource.java | 3 +- 12 files changed, 154 insertions(+), 177 deletions(-) diff --git a/vtm-extras/src/org/oscim/tiling/source/geojson/GeoJsonTileSource.java b/vtm-extras/src/org/oscim/tiling/source/geojson/GeoJsonTileSource.java index e381f6a18..440562f51 100644 --- a/vtm-extras/src/org/oscim/tiling/source/geojson/GeoJsonTileSource.java +++ b/vtm-extras/src/org/oscim/tiling/source/geojson/GeoJsonTileSource.java @@ -22,27 +22,24 @@ import org.oscim.core.MapElement; import org.oscim.core.Tag; import org.oscim.tiling.ITileDataSource; -import org.oscim.tiling.source.LwHttp; import org.oscim.tiling.source.UrlTileDataSource; import org.oscim.tiling.source.UrlTileSource; public abstract class GeoJsonTileSource extends UrlTileSource { public GeoJsonTileSource(String url) { - super(url); - setExtension(".json"); + super(url, "/{Z}/{X}/{Y}.json"); } public GeoJsonTileSource(String url, int zoomMin, int zoomMax) { - super(url, zoomMin, zoomMax); - setExtension(".json"); + super(url, "/{Z}/{X}/{Y}.json", zoomMin, zoomMax); } @Override public ITileDataSource getDataSource() { Map opt = new HashMap(); opt.put("Accept-Encoding", "gzip"); - return new UrlTileDataSource(this, new GeoJsonTileDecoder(this), new LwHttp(getUrl(), opt)); + return new UrlTileDataSource(this, new GeoJsonTileDecoder(this), getHttpEngine()); } public Tag getFeatureTag() { diff --git a/vtm-extras/src/org/oscim/tiling/source/mapnik/MapnikVectorTileSource.java b/vtm-extras/src/org/oscim/tiling/source/mapnik/MapnikVectorTileSource.java index abb551ada..a977a6814 100644 --- a/vtm-extras/src/org/oscim/tiling/source/mapnik/MapnikVectorTileSource.java +++ b/vtm-extras/src/org/oscim/tiling/source/mapnik/MapnikVectorTileSource.java @@ -25,12 +25,12 @@ public class MapnikVectorTileSource extends UrlTileSource { public MapnikVectorTileSource() { - super("http://d1s11ojcu7opje.cloudfront.net/dev/764e0b8d"); + super("http://d1s11ojcu7opje.cloudfront.net/dev/764e0b8d", ""); } @Override public ITileDataSource getDataSource() { - return new UrlTileDataSource(this, new TileDecoder(), new LwHttp(getUrl())); + return new UrlTileDataSource(this, new TileDecoder(), getHttpEngine()); } public int formatTilePath(Tile tile, byte[] path, int pos) { diff --git a/vtm-extras/src/org/oscim/tiling/source/oscimap/OSciMap1TileSource.java b/vtm-extras/src/org/oscim/tiling/source/oscimap/OSciMap1TileSource.java index 50ae2b269..326265197 100644 --- a/vtm-extras/src/org/oscim/tiling/source/oscimap/OSciMap1TileSource.java +++ b/vtm-extras/src/org/oscim/tiling/source/oscimap/OSciMap1TileSource.java @@ -17,7 +17,6 @@ package org.oscim.tiling.source.oscimap; import org.oscim.tiling.ITileDataSource; -import org.oscim.tiling.source.LwHttp; import org.oscim.tiling.source.UrlTileDataSource; import org.oscim.tiling.source.UrlTileSource; @@ -28,13 +27,11 @@ public class OSciMap1TileSource extends UrlTileSource { public OSciMap1TileSource(String url) { - super(url); - setExtension(".osmtile"); - setMimeType("application/osmtile"); + super(url, "/{Z}/{X}/{Y}.osmtile"); } @Override public ITileDataSource getDataSource() { - return new UrlTileDataSource(this, new TileDecoder(), new LwHttp(getUrl())); + return new UrlTileDataSource(this, new TileDecoder(), getHttpEngine()); } } diff --git a/vtm-extras/src/org/oscim/tiling/source/oscimap2/OSciMap2TileSource.java b/vtm-extras/src/org/oscim/tiling/source/oscimap2/OSciMap2TileSource.java index 77f881e29..54aa0bf97 100644 --- a/vtm-extras/src/org/oscim/tiling/source/oscimap2/OSciMap2TileSource.java +++ b/vtm-extras/src/org/oscim/tiling/source/oscimap2/OSciMap2TileSource.java @@ -27,7 +27,6 @@ import org.oscim.core.Tile; import org.oscim.tiling.ITileDataSink; import org.oscim.tiling.ITileDataSource; -import org.oscim.tiling.source.LwHttp; import org.oscim.tiling.source.PbfDecoder; import org.oscim.tiling.source.UrlTileDataSource; import org.oscim.tiling.source.UrlTileSource; @@ -37,14 +36,12 @@ public class OSciMap2TileSource extends UrlTileSource { public OSciMap2TileSource(String url) { - super(url); - setExtension(".osmtile"); - setMimeType("application/osmtile"); + super(url, "/{Z}/{X}/{Y}.osmtile"); } @Override public ITileDataSource getDataSource() { - return new UrlTileDataSource(this, new TileDecoder(), new LwHttp(getUrl())); + return new UrlTileDataSource(this, new TileDecoder(), getHttpEngine()); } static class TileDecoder extends PbfDecoder { diff --git a/vtm/src/org/oscim/tiling/source/HttpEngine.java b/vtm/src/org/oscim/tiling/source/HttpEngine.java index a843a1d66..3483b6aad 100644 --- a/vtm/src/org/oscim/tiling/source/HttpEngine.java +++ b/vtm/src/org/oscim/tiling/source/HttpEngine.java @@ -10,7 +10,7 @@ public interface HttpEngine { InputStream read() throws IOException; - boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOException; + boolean sendRequest(Tile tile) throws IOException; void close(); @@ -19,6 +19,7 @@ public interface HttpEngine { boolean requestCompleted(boolean success); public interface Factory { - public HttpEngine create(); + public abstract HttpEngine create(UrlTileSource tileSource); } + } diff --git a/vtm/src/org/oscim/tiling/source/LwHttp.java b/vtm/src/org/oscim/tiling/source/LwHttp.java index fd8484817..4aaa51483 100644 --- a/vtm/src/org/oscim/tiling/source/LwHttp.java +++ b/vtm/src/org/oscim/tiling/source/LwHttp.java @@ -24,7 +24,6 @@ import java.net.Socket; import java.net.SocketAddress; import java.net.URL; -import java.util.Map; import java.util.Map.Entry; import org.oscim.core.Tile; @@ -40,6 +39,8 @@ public class LwHttp implements HttpEngine { static final Logger log = LoggerFactory.getLogger(LwHttp.class); static final boolean dbg = false; + private final UrlTileSource mTileSource; + private final static byte[] HEADER_HTTP_OK = "200 OK".getBytes(); //private final static byte[] HEADER_CONTENT_TYPE = "Content-Type".getBytes(); private final static byte[] HEADER_CONTENT_LENGTH = "Content-Length".getBytes(); @@ -68,16 +69,9 @@ public class LwHttp implements HttpEngine { private final byte[] REQUEST_GET_END; private final byte[] mRequestBuffer; - /** - * @param url - * Base url for tiles - */ - public LwHttp(URL url) { - this(url, null); - } - - public LwHttp(URL url, Map header) { - + private LwHttp(UrlTileSource tileSource) { + mTileSource = tileSource; + URL url = tileSource.getUrl(); int port = url.getPort(); if (port < 0) port = 80; @@ -89,9 +83,9 @@ public LwHttp(URL url, Map header) { REQUEST_GET_START = ("GET " + path).getBytes(); String addRequest = ""; - if (header != null) { + if (tileSource.getRequestHeader() != null) { StringBuffer sb = new StringBuffer(); - for (Entry l : header.entrySet()) + for (Entry l : tileSource.getRequestHeader().entrySet()) sb.append('\n').append(l.getKey()).append(": ").append(l.getValue()); addRequest = sb.toString(); } @@ -329,7 +323,7 @@ public InputStream read() throws IOException { } @Override - public boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOException { + public boolean sendRequest(Tile tile) throws IOException { if (mSocket != null) { if (mMaxReq-- <= 0) @@ -358,7 +352,7 @@ else if (System.nanoTime() - mLastRequest > RESPONSE_TIMEOUT) byte[] request = mRequestBuffer; int pos = REQUEST_GET_START.length; - pos = tileSource.formatTilePath(tile, request, pos); + pos = formatTilePath(mTileSource, tile, request, pos); int len = REQUEST_GET_END.length; System.arraycopy(REQUEST_GET_END, 0, request, pos, len); @@ -499,4 +493,46 @@ private static boolean check(byte[] string, byte[] buffer, return true; } + + /** + * Write tile url - the low level, no-allocations method, + * + * override getTileUrl() for custom url formatting using + * Strings + * + * @param tile the Tile + * @param buf to write url string + * @param pos current position + * @return new position + */ + public int formatTilePath(UrlTileSource tileSource, Tile tile, byte[] buf, int pos) { + String p = tileSource.formatTilePath(tile); + log.debug("path {}", p); + //if (p != null) { + byte[] b = p.getBytes(); + System.arraycopy(b, 0, buf, pos, b.length); + return pos + b.length; + //} + // + // buf[pos++] = '/'; + // pos = LwHttp.writeInt(tile.zoomLevel, pos, buf); + // buf[pos++] = '/'; + // pos = LwHttp.writeInt(tile.tileX, pos, buf); + // buf[pos++] = '/'; + // pos = LwHttp.writeInt(tile.tileY, pos, buf); + // byte[] ext = tileSource.mExtBytes; + // if (ext == null) + // return pos; + // + // System.arraycopy(ext, 0, buf, pos, ext.length); + // return pos + ext.length; + } + + public static class LwHttpFactory implements HttpEngine.Factory { + + @Override + public HttpEngine create(UrlTileSource tileSource) { + return new LwHttp(tileSource); + } + } } diff --git a/vtm/src/org/oscim/tiling/source/OkHttpEngine.java b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java index d8ae79512..7e39ad739 100644 --- a/vtm/src/org/oscim/tiling/source/OkHttpEngine.java +++ b/vtm/src/org/oscim/tiling/source/OkHttpEngine.java @@ -4,6 +4,7 @@ import java.io.InputStream; import java.io.OutputStream; import java.net.HttpURLConnection; +import java.net.MalformedURLException; import java.net.URL; import org.oscim.core.Tile; @@ -11,25 +12,27 @@ import com.squareup.okhttp.OkHttpClient; public class OkHttpEngine implements HttpEngine { - private final OkHttpClient client; + private final OkHttpClient mClient; + private final UrlTileSource mTileSource; public static class OkHttpFactory implements HttpEngine.Factory { - private final OkHttpClient client; + private final OkHttpClient mClient; public OkHttpFactory() { - this.client = new OkHttpClient(); + mClient = new OkHttpClient(); } @Override - public HttpEngine create() { - return new OkHttpEngine(client); + public HttpEngine create(UrlTileSource tileSource) { + return new OkHttpEngine(mClient, tileSource); } } private InputStream inputStream; - public OkHttpEngine(OkHttpClient client) { - this.client = client; + public OkHttpEngine(OkHttpClient client, UrlTileSource tileSource) { + mClient = client; + mTileSource = tileSource; } @Override @@ -37,28 +40,18 @@ public InputStream read() throws IOException { return inputStream; } + HttpURLConnection openConnection(Tile tile) throws MalformedURLException { + return mClient.open(new URL(mTileSource.getUrl() + + mTileSource.formatTilePath(tile))); + } + @Override - public boolean sendRequest(UrlTileSource tileSource, Tile tile) throws IOException { + public boolean sendRequest(Tile tile) throws IOException { if (tile == null) { throw new IllegalArgumentException("Tile cannot be null."); } - StringBuilder sb = new StringBuilder(); - sb.append(tileSource.getUrl()); - String path = tileSource.getTileUrl(tile); - if (path == null) { - sb.append('/'); - sb.append(tile.zoomLevel); - sb.append('/'); - sb.append(tile.tileX); - sb.append('/'); - sb.append(tile.tileY); - sb.append(tileSource.getExtension()); - } else { - sb.append(path); - } - - final HttpURLConnection connection = client.open(new URL(sb.toString())); + final HttpURLConnection connection = openConnection(tile); inputStream = connection.getInputStream(); diff --git a/vtm/src/org/oscim/tiling/source/UrlTileDataSource.java b/vtm/src/org/oscim/tiling/source/UrlTileDataSource.java index a97272c3e..4cf814cf2 100644 --- a/vtm/src/org/oscim/tiling/source/UrlTileDataSource.java +++ b/vtm/src/org/oscim/tiling/source/UrlTileDataSource.java @@ -75,7 +75,7 @@ public void query(MapTile tile, ITileDataSink sink) { TileWriter cacheWriter = null; try { InputStream is; - if (!mConn.sendRequest(mTileSource, tile)) { + if (!mConn.sendRequest(tile)) { log.debug("{} Request failed", tile); } else if ((is = mConn.read()) == null) { log.debug("{} Network Error", tile); diff --git a/vtm/src/org/oscim/tiling/source/UrlTileSource.java b/vtm/src/org/oscim/tiling/source/UrlTileSource.java index 6fee96a6c..b7546ba3e 100644 --- a/vtm/src/org/oscim/tiling/source/UrlTileSource.java +++ b/vtm/src/org/oscim/tiling/source/UrlTileSource.java @@ -18,32 +18,44 @@ import java.net.MalformedURLException; import java.net.URL; +import java.util.Map; import org.oscim.core.Tile; import org.oscim.tiling.TileSource; +import org.oscim.tiling.source.LwHttp.LwHttpFactory; public abstract class UrlTileSource extends TileSource { private final URL mUrl; - private byte[] mExtBytes; - private String mExtString; + private final String[] mTilePath; private HttpEngine.Factory mHttpFactory; + private Map mRequestHeaders; + + public UrlTileSource(String url, String tilePath, int zoomMin, int zoomMax) { + this(url, tilePath); + mZoomMin = zoomMin; + mZoomMax = zoomMax; + } + + /** + * @param urlString 'http://example.com/' + * @param tilePath replacement string for tile coordinates, + * e.g. '{Z}/{X}/{Y}.png' + */ + public UrlTileSource(String urlString, String tilePath) { + + if (tilePath == null) + throw new IllegalArgumentException("tilePath cannot be null."); - public UrlTileSource(String urlString) { URL url = null; try { url = new URL(urlString); } catch (MalformedURLException e) { - e.printStackTrace(); + throw new IllegalArgumentException(e); } mUrl = url; - } - - public UrlTileSource(String url, int zoomMin, int zoomMax) { - this(url); - mZoomMin = zoomMin; - mZoomMax = zoomMax; + mTilePath = tilePath.split("\\{|\\}"); } @Override @@ -56,75 +68,52 @@ public void close() { } - protected void setExtension(String ext) { - mExtString = ext; - if (ext == null) { - mExtBytes = null; - return; - } - mExtBytes = ext.getBytes(); - } - - protected void setMimeType(String string) { - - } - - /** - * Create url path for tile - */ - protected String getTileUrl(Tile tile) { - return null; + public URL getUrl() { + return mUrl; } - /** - * Write tile url - the low level, no-allocations method, - * - * override getTileUrl() for custom url formatting using - * Strings - * - * @param tile the Tile - * @param buf to write url string - * @param pos current position - * @return new position - */ - public int formatTilePath(Tile tile, byte[] buf, int pos) { - String p = getTileUrl(tile); - if (p != null) { - byte[] b = p.getBytes(); - System.arraycopy(b, 0, buf, pos, b.length); - return pos + b.length; + public String formatTilePath(Tile tile) { + // TODO only use the actual replacement positions. + + StringBuilder sb = new StringBuilder(); + for (String b : mTilePath) { + if (b.length() == 1) { + switch (b.charAt(0)) { + case 'X': + sb.append(tile.tileX); + continue; + case 'Y': + sb.append(tile.tileY); + continue; + case 'Z': + sb.append(tile.zoomLevel); + continue; + default: + break; + } + } + sb.append(b); } + return sb.toString(); + } - buf[pos++] = '/'; - pos = LwHttp.writeInt(tile.zoomLevel, pos, buf); - buf[pos++] = '/'; - pos = LwHttp.writeInt(tile.tileX, pos, buf); - buf[pos++] = '/'; - pos = LwHttp.writeInt(tile.tileY, pos, buf); - if (mExtBytes == null) - return pos; - - System.arraycopy(mExtBytes, 0, buf, pos, mExtBytes.length); - return pos + mExtBytes.length; + public void setHttpEngine(HttpEngine.Factory httpFactory) { + mHttpFactory = httpFactory; } - public URL getUrl() { - return mUrl; + public void setHttpRequestHeaders(Map options) { + mRequestHeaders = options; } - public void setHttpEngine(HttpEngine.Factory httpFactory) { - mHttpFactory = httpFactory; + protected Map getRequestHeader() { + return mRequestHeaders; } public HttpEngine getHttpEngine() { if (mHttpFactory == null) { - return new LwHttp(getUrl()); + mHttpFactory = new LwHttpFactory(); } - return mHttpFactory.create(); - } - - public String getExtension() { - return mExtString == null ? "" : mExtString; + return mHttpFactory.create(this); } } diff --git a/vtm/src/org/oscim/tiling/source/bitmap/BitmapTileSource.java b/vtm/src/org/oscim/tiling/source/bitmap/BitmapTileSource.java index 40197f631..3e2fc0553 100644 --- a/vtm/src/org/oscim/tiling/source/bitmap/BitmapTileSource.java +++ b/vtm/src/org/oscim/tiling/source/bitmap/BitmapTileSource.java @@ -26,8 +26,15 @@ public class BitmapTileSource extends UrlTileSource { * implement getUrlString() for custom formatting. */ public BitmapTileSource(String url, int zoomMin, int zoomMax) { - super(url, zoomMin, zoomMax); - setExtension(".png"); + super(url, "/{Z}/{X}/{Y}.png", zoomMin, zoomMax); + } + + public BitmapTileSource(String url, int zoomMin, int zoomMax, String extension) { + super(url, "/{Z}/{X}/{Y}" + extension, zoomMin, zoomMax); + } + + public BitmapTileSource(String url, String tilePath, int zoomMin, int zoomMax) { + super(url, tilePath, zoomMin, zoomMax); } @Override diff --git a/vtm/src/org/oscim/tiling/source/bitmap/DefaultSources.java b/vtm/src/org/oscim/tiling/source/bitmap/DefaultSources.java index 92fea620f..f74d51195 100644 --- a/vtm/src/org/oscim/tiling/source/bitmap/DefaultSources.java +++ b/vtm/src/org/oscim/tiling/source/bitmap/DefaultSources.java @@ -1,6 +1,5 @@ package org.oscim.tiling.source.bitmap; -import org.oscim.core.Tile; import org.oscim.layers.tile.bitmap.BitmapTileLayer.FadeStep; /** @@ -35,15 +34,13 @@ public StamenWatercolor() { public static class ImagicoLandcover extends BitmapTileSource { public ImagicoLandcover() { - super("http://www.imagico.de/map/tiles/landcover", 0, 6); - setExtension(".jpg"); + super("http://www.imagico.de/map/tiles/landcover", 0, 6, ".jpg"); } } public static class MapQuestAerial extends BitmapTileSource { public MapQuestAerial() { - super("http://otile1.mqcdn.com/tiles/1.0.0/sat", 0, 8); - setExtension(".jpg"); + super("http://otile1.mqcdn.com/tiles/1.0.0/sat", 0, 8, ".jpg"); } @Override @@ -64,38 +61,17 @@ public FadeStep[] getFadeSteps() { } public static class ArcGISWorldShaded extends BitmapTileSource { - private final StringBuilder sb = new StringBuilder(32); - public ArcGISWorldShaded() { - super("http://server.arcgisonline.com/ArcGIS/rest/services", 0, 13); - } - - @Override - public synchronized String getTileUrl(Tile tile) { - sb.setLength(0); - //sb.append("/World_Imagery/MapServer/tile/"); - sb.append("/World_Shaded_Relief/MapServer/tile/"); - sb.append(tile.zoomLevel); - sb.append('/').append(tile.tileY); - sb.append('/').append(tile.tileX); - return sb.toString(); + super("http://server.arcgisonline.com/ArcGIS/rest/services" + + "/World_Shaded_Relief/MapServer/tile/", + "{Z}/{Y}/{X}", 0, 13); } } public static class HillShadeHD extends BitmapTileSource { - private final StringBuilder sb = new StringBuilder(32); - public HillShadeHD() { - super("http://129.206.74.245:8004/tms_hs.ashx", 2, 16); - } - - @Override - public synchronized String getTileUrl(Tile tile) { - sb.setLength(0); - sb.append("?x=").append(tile.tileX); - sb.append("&y=").append(tile.tileY); - sb.append("&z=").append(tile.zoomLevel); - return sb.toString(); + super("http://129.206.74.245:8004/tms_hs.ashx", + "?x={X}&y={Y}&z={Z}", 2, 16); } } @@ -104,23 +80,8 @@ public synchronized String getTileUrl(Tile tile) { * https://developers.google.com/maps/faq */ public static class GoogleMaps extends BitmapTileSource { - private final StringBuilder sb = new StringBuilder(60); - public GoogleMaps(String hostName) { - super(hostName, 1, 20); //jpeg for sat - } - - @Override - public synchronized String getTileUrl(Tile tile) { - sb.setLength(0); - sb.append("/vt/x="); //lyrs=y& - sb.append(tile.tileX); - sb.append("&y="); - sb.append(tile.tileY); - sb.append("&z="); - sb.append(tile.zoomLevel); - sb.append("&s=Galileo&scale=2"); - return sb.toString(); + super(hostName, "/vt/x={X}&y={Y}&z={Z}&s=Galileo&scale=2", 1, 20); //jpeg for sat } } diff --git a/vtm/src/org/oscim/tiling/source/oscimap4/OSciMap4TileSource.java b/vtm/src/org/oscim/tiling/source/oscimap4/OSciMap4TileSource.java index 3d2788a7f..d98597ccb 100644 --- a/vtm/src/org/oscim/tiling/source/oscimap4/OSciMap4TileSource.java +++ b/vtm/src/org/oscim/tiling/source/oscimap4/OSciMap4TileSource.java @@ -27,8 +27,7 @@ public OSciMap4TileSource() { } public OSciMap4TileSource(String url) { - super(url); - setExtension(".vtm"); + super(url, "/{Z}/{X}/{Y}.vtm"); } @Override From b330ea98142ac43e3a22cfa6e37582fc483a02aa Mon Sep 17 00:00:00 2001 From: Hannes Janetzek Date: Wed, 2 Apr 2014 06:54:54 +0200 Subject: [PATCH 09/12] gradle: make okhttp optional --- vtm-android-example/build.gradle | 1 + vtm/build.gradle | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/vtm-android-example/build.gradle b/vtm-android-example/build.gradle index b77ab2f14..e05f9b8bf 100644 --- a/vtm-android-example/build.gradle +++ b/vtm-android-example/build.gradle @@ -14,6 +14,7 @@ dependencies { compile project(':vtm-jeo') compile project(':vtm-extras') compile project(':vtm-themes') + compile 'com.squareup.okhttp:okhttp:1.5.2' } android { diff --git a/vtm/build.gradle b/vtm/build.gradle index 6f148d819..6df7c2046 100644 --- a/vtm/build.gradle +++ b/vtm/build.gradle @@ -5,7 +5,7 @@ configurations { providedCompile } dependencies { compile 'org.slf4j:slf4j-api:1.7.6' - compile 'com.squareup.okhttp:okhttp:1.5.2' + providedCompile 'com.squareup.okhttp:okhttp:1.5.2' providedCompile 'com.google.code.findbugs:annotations:2.0.1' } From b42f1fa8e8812d51e2e79890242190f2e88c8146 Mon Sep 17 00:00:00 2001 From: Hannes Janetzek Date: Wed, 2 Apr 2014 07:07:30 +0200 Subject: [PATCH 10/12] fix tests --- vtm-tests/build.gradle | 1 + .../oscim/tiling/source/OkHttpEngineTest.java | 35 +++++++++---------- .../tiling/source/UrlTileSourceTest.java | 12 +++---- .../source/bitmap/BitmapTileSourceTest.java | 6 ++-- .../oscimap4/OSciMap4TileSourceTest.java | 10 +++--- 5 files changed, 33 insertions(+), 31 deletions(-) diff --git a/vtm-tests/build.gradle b/vtm-tests/build.gradle index 3acb62855..02235b8a2 100644 --- a/vtm-tests/build.gradle +++ b/vtm-tests/build.gradle @@ -3,6 +3,7 @@ apply plugin: 'maven' dependencies { compile project(':vtm') + compile 'com.squareup.okhttp:okhttp:1.5.2' testCompile 'junit:junit:4.11' testCompile 'org.mockito:mockito-all:1.9.5' testCompile 'org.easytesting:fest-assert-core:2.0M10' diff --git a/vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java b/vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java index 45ff6b899..ddc1e083d 100644 --- a/vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java +++ b/vtm-tests/test/org/oscim/tiling/source/OkHttpEngineTest.java @@ -1,8 +1,11 @@ package org.oscim.tiling.source; -import com.squareup.okhttp.mockwebserver.MockResponse; -import com.squareup.okhttp.mockwebserver.MockWebServer; -import com.squareup.okhttp.mockwebserver.RecordedRequest; +import static org.fest.assertions.api.Assertions.assertThat; + +import java.io.BufferedReader; +import java.io.IOException; +import java.io.InputStream; +import java.io.InputStreamReader; import org.junit.After; import org.junit.Before; @@ -10,12 +13,9 @@ import org.oscim.core.Tile; import org.oscim.tiling.source.oscimap4.OSciMap4TileSource; -import java.io.BufferedReader; -import java.io.IOException; -import java.io.InputStream; -import java.io.InputStreamReader; - -import static org.fest.assertions.api.Assertions.assertThat; +import com.squareup.okhttp.mockwebserver.MockResponse; +import com.squareup.okhttp.mockwebserver.MockWebServer; +import com.squareup.okhttp.mockwebserver.RecordedRequest; public class OkHttpEngineTest { private OkHttpEngine engine; @@ -29,7 +29,8 @@ public void setUp() throws Exception { server = new MockWebServer(); server.enqueue(mockResponse); server.play(); - engine = (OkHttpEngine) new OkHttpEngine.OkHttpFactory().create(); + engine = (OkHttpEngine) new OkHttpEngine.OkHttpFactory() + .create(new OSciMap4TileSource(server.getUrl("/tiles/vtm").toString())); } @After @@ -44,13 +45,12 @@ public void shouldNotBeNull() throws Exception { @Test(expected = IllegalArgumentException.class) public void sendRequest_shouldRejectNullTile() throws Exception { - engine.sendRequest(null, null); + engine.sendRequest(null); } @Test public void sendRequest_shouldAppendXYZToPath() throws Exception { - engine.sendRequest(new OSciMap4TileSource(server.getUrl("/tiles/vtm").toString()), - new Tile(1, 2, new Integer(3).byteValue())); + engine.sendRequest(new Tile(1, 2, new Integer(3).byteValue())); RecordedRequest request = server.takeRequest(); assertThat(request.getPath()).isEqualTo("/tiles/vtm/3/1/2.vtm"); @@ -58,8 +58,7 @@ public void sendRequest_shouldAppendXYZToPath() throws Exception { @Test public void read_shouldReturnResponseStream() throws Exception { - engine.sendRequest(new OSciMap4TileSource(server.getUrl("/tiles/vtm").toString()), - new Tile(1, 2, new Integer(3).byteValue())); + engine.sendRequest(new Tile(1, 2, new Integer(3).byteValue())); InputStream responseStream = engine.read(); String response = new BufferedReader(new InputStreamReader(responseStream)).readLine(); @@ -68,8 +67,7 @@ public void read_shouldReturnResponseStream() throws Exception { @Test(expected = IOException.class) public void close_shouldCloseInputStream() throws Exception { - engine.sendRequest(new OSciMap4TileSource(server.getUrl("/tiles/vtm").toString()), - new Tile(1, 2, new Integer(3).byteValue())); + engine.sendRequest(new Tile(1, 2, new Integer(3).byteValue())); engine.close(); // Calling read after the stream is closed should throw an exception. @@ -79,8 +77,7 @@ public void close_shouldCloseInputStream() throws Exception { @Test(expected = IOException.class) public void requestCompleted_shouldCloseInputStream() throws Exception { - engine.sendRequest(new OSciMap4TileSource(server.getUrl("/tiles/vtm").toString()), - new Tile(1, 2, new Integer(3).byteValue())); + engine.sendRequest(new Tile(1, 2, new Integer(3).byteValue())); engine.requestCompleted(true); // Calling read after the stream is closed should throw an exception. diff --git a/vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java b/vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java index 395738c6a..b52eb8305 100644 --- a/vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java +++ b/vtm-tests/test/org/oscim/tiling/source/UrlTileSourceTest.java @@ -1,17 +1,17 @@ package org.oscim.tiling.source; +import static org.fest.assertions.api.Assertions.assertThat; + import org.junit.Before; import org.junit.Test; import org.oscim.tiling.ITileDataSource; -import static org.fest.assertions.api.Assertions.assertThat; - public class UrlTileSourceTest { private UrlTileSource tileSource; @Before public void setUp() throws Exception { - tileSource = new TestTileSource("http://example.org/tiles/vtm"); + tileSource = new TestTileSource("http://example.org/tiles/vtm", "/{Z}/{X}/{Z}.vtm"); } @Test @@ -33,8 +33,8 @@ public void shouldUseCustomHttpEngine() throws Exception { } class TestTileSource extends UrlTileSource { - public TestTileSource(String urlString) { - super(urlString); + public TestTileSource(String urlString, String tilePath) { + super(urlString, tilePath); } @Override @@ -45,7 +45,7 @@ public ITileDataSource getDataSource() { class TestTileDataSource extends UrlTileDataSource { public TestTileDataSource(UrlTileSource tileSource, ITileDecoder tileDecoder, - HttpEngine conn) { + HttpEngine conn) { super(tileSource, tileDecoder, conn); } diff --git a/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java b/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java index f0f93560e..8381a1d2a 100644 --- a/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java +++ b/vtm-tests/test/org/oscim/tiling/source/bitmap/BitmapTileSourceTest.java @@ -10,6 +10,7 @@ import org.oscim.tiling.source.LwHttp; import org.oscim.tiling.source.OkHttpEngine; import org.oscim.tiling.source.UrlTileDataSource; +import org.oscim.tiling.source.UrlTileSource; public class BitmapTileSourceTest { private BitmapTileSource tileSource; @@ -43,7 +44,8 @@ public void shouldUseOkHttp() throws Exception { } /** - * Test factory that allows the specific {@link HttpEngine} instance to be set. + * Test factory that allows the specific {@link HttpEngine} instance to be + * set. */ class TestHttpFactory implements HttpEngine.Factory { final HttpEngine engine; @@ -53,7 +55,7 @@ public TestHttpFactory(HttpEngine engine) { } @Override - public HttpEngine create() { + public HttpEngine create(UrlTileSource tileSource) { return engine; } } diff --git a/vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java b/vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java index 060d0c77e..542769658 100644 --- a/vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java +++ b/vtm-tests/test/org/oscim/tiling/source/oscimap4/OSciMap4TileSourceTest.java @@ -1,5 +1,7 @@ package org.oscim.tiling.source.oscimap4; +import static org.fest.assertions.api.Assertions.assertThat; + import org.junit.Before; import org.junit.Test; import org.mockito.Mockito; @@ -7,8 +9,7 @@ import org.oscim.tiling.source.HttpEngine; import org.oscim.tiling.source.LwHttp; import org.oscim.tiling.source.OkHttpEngine; - -import static org.fest.assertions.api.Assertions.assertThat; +import org.oscim.tiling.source.UrlTileSource; public class OSciMap4TileSourceTest { private OSciMap4TileSource tileSource; @@ -42,7 +43,8 @@ public void shouldUseOkHttp() throws Exception { } /** - * Test factory that allows the specific {@link HttpEngine} instance to be set. + * Test factory that allows the specific {@link HttpEngine} instance to be + * set. */ class TestHttpFactory implements HttpEngine.Factory { final HttpEngine engine; @@ -52,7 +54,7 @@ public TestHttpFactory(HttpEngine engine) { } @Override - public HttpEngine create() { + public HttpEngine create(UrlTileSource tileSource) { return engine; } } From 1890cad555f8d218a18071a3800642ce726d9799 Mon Sep 17 00:00:00 2001 From: Hannes Janetzek Date: Wed, 2 Apr 2014 07:37:57 +0200 Subject: [PATCH 11/12] gwt: update UrlTileSource --- .../emu/org/oscim/tiling/source/LwHttp.java | 57 ++++++++++++++----- .../tiling/source/UrlTileDataSource.java | 8 +-- .../source/bitmap/BitmapTileSource.java | 19 ++++--- .../source/geojson/GeoJsonTileSource.java | 3 +- .../tiling/source/JsonTileDataSource.java | 6 +- 5 files changed, 60 insertions(+), 33 deletions(-) diff --git a/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/LwHttp.java b/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/LwHttp.java index b42cd8310..3af96e530 100644 --- a/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/LwHttp.java +++ b/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/LwHttp.java @@ -16,9 +16,11 @@ import java.io.IOException; import java.io.InputStream; +import java.io.OutputStream; import java.net.URL; import org.oscim.core.Tile; +import org.oscim.layers.tile.MapTile; import com.google.gwt.typedarrays.client.Uint8ArrayNative; import com.google.gwt.typedarrays.shared.Uint8Array; @@ -26,20 +28,20 @@ import com.google.gwt.xhr.client.XMLHttpRequest; import com.google.gwt.xhr.client.XMLHttpRequest.ResponseType; -public class LwHttp { +public class LwHttp implements HttpEngine { //static final Logger log = LoggerFactory.getLogger(LwHttp.class); private final String mUrlPath; - private final byte[] mRequestBuffer; private int mContentLength = -1; private XMLHttpRequest mHttpRequest; private ReadyStateChangeHandler mResponseHandler; - public LwHttp(URL url) { + public LwHttp(UrlTileSource tileSource) { + mTileSource = tileSource; + URL url = tileSource.getUrl(); mUrlPath = url.toString(); - mRequestBuffer = new byte[1024]; } static class Buffer extends InputStream { @@ -67,17 +69,11 @@ public void close() { mHttpRequest.abort(); } - private UrlTileDataSource mDataSource; + private UrlTileSource mTileSource; - public boolean sendRequest(Tile tile, UrlTileDataSource dataSource) throws IOException { - mDataSource = dataSource; + public boolean sendRequest(MapTile tile, final UrlTileDataSource dataSource) throws IOException { - byte[] request = mRequestBuffer; - int pos = 0; - - pos = dataSource.getTileSource().formatTilePath(tile, request, pos); - - String url = mUrlPath + (new String(request, 0, pos)); + String url = mUrlPath + mTileSource.formatTilePath(tile); mHttpRequest = XMLHttpRequest.create(); mHttpRequest.open("GET", url); @@ -97,9 +93,9 @@ public void onReadyStateChange(XMLHttpRequest xhr) { if (status == 200) { Uint8Array buf = Uint8ArrayNative.create(xhr.getResponseArrayBuffer()); - mDataSource.process(new Buffer(buf)); + dataSource.process(new Buffer(buf)); } else { - mDataSource.process(null); + dataSource.process(null); } } } @@ -150,4 +146,35 @@ public void requestCompleted() { public int getContentLength() { return mContentLength; } + + public static class LwHttpFactory implements HttpEngine.Factory { + + @Override + public HttpEngine create(UrlTileSource tileSource) { + return new LwHttp(tileSource); + } + } + + @Override + public InputStream read() throws IOException { + // TODO Auto-generated method stub + return null; + } + + @Override + public void setCache(OutputStream os) { + // TODO Auto-generated method stub + } + + @Override + public boolean requestCompleted(boolean success) { + // TODO Auto-generated method stub + return false; + } + + @Override + public boolean sendRequest(Tile tile) throws IOException { + // TODO Auto-generated method stub + return false; + } } diff --git a/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/UrlTileDataSource.java b/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/UrlTileDataSource.java index f9afeb800..5f344d043 100644 --- a/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/UrlTileDataSource.java +++ b/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/UrlTileDataSource.java @@ -35,10 +35,10 @@ public class UrlTileDataSource implements ITileDataSource { protected final ITileDecoder mTileDecoder; protected final UrlTileSource mTileSource; - public UrlTileDataSource(UrlTileSource tileSource, ITileDecoder tileDecoder, LwHttp conn) { + public UrlTileDataSource(UrlTileSource tileSource, ITileDecoder tileDecoder, HttpEngine conn) { mTileSource = tileSource; mTileDecoder = tileDecoder; - mConn = conn; + mConn = (LwHttp) conn; } UrlTileSource getTileSource() { @@ -80,12 +80,12 @@ public void continueLoading() { log.debug("{} failed", tile); // FIXME - mConn.requestCompleted(); + mConn.requestCompleted(true); sink.completed(win ? SUCCESS : FAILED); } else { // FIXME - mConn.requestCompleted(); + mConn.requestCompleted(false); sink.completed(FAILED); } diff --git a/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/bitmap/BitmapTileSource.java b/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/bitmap/BitmapTileSource.java index 87801f572..f8af2cafe 100644 --- a/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/bitmap/BitmapTileSource.java +++ b/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/bitmap/BitmapTileSource.java @@ -31,9 +31,17 @@ public class BitmapTileSource extends UrlTileSource { * Use e.g. setExtension(".jpg") to overide ending or * implement getUrlString() for custom formatting. */ + public BitmapTileSource(String url, int zoomMin, int zoomMax) { - super(url, zoomMin, zoomMax); - setExtension(".png"); + super(url, "/{Z}/{X}/{Y}.png", zoomMin, zoomMax); + } + + public BitmapTileSource(String url, int zoomMin, int zoomMax, String extension) { + super(url, "/{Z}/{X}/{Y}" + extension, zoomMin, zoomMax); + } + + public BitmapTileSource(String url, String tilePath, int zoomMin, int zoomMax) { + super(url, tilePath, zoomMin, zoomMax); } @Override @@ -41,10 +49,9 @@ public ITileDataSource getDataSource() { return new BitmapTileDataSource(this); } - public static class BitmapTileDataSource implements ITileDataSource { + public class BitmapTileDataSource implements ITileDataSource { protected final UrlTileSource mTileSource; - private final byte[] mRequestBuffer = new byte[1024]; public BitmapTileDataSource(BitmapTileSource bitmapTileSource) { mTileSource = bitmapTileSource; @@ -53,10 +60,8 @@ public BitmapTileDataSource(BitmapTileSource bitmapTileSource) { @Override public void query(final MapTile tile, final ITileDataSink sink) { - int pos = mTileSource.formatTilePath(tile, mRequestBuffer, 0); - String url = mTileSource.getUrl() - + (new String(mRequestBuffer, 0, pos)); + + BitmapTileSource.this.formatTilePath(tile); SafeUri uri = UriUtils.fromTrustedString(url); diff --git a/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/geojson/GeoJsonTileSource.java b/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/geojson/GeoJsonTileSource.java index 2e5c2c8b6..934f8dc37 100644 --- a/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/geojson/GeoJsonTileSource.java +++ b/vtm-web/src/org/oscim/gdx/emu/org/oscim/tiling/source/geojson/GeoJsonTileSource.java @@ -30,8 +30,7 @@ public abstract class GeoJsonTileSource extends UrlTileSource { static final Logger log = LoggerFactory.getLogger(GeoJsonTileSource.class); public GeoJsonTileSource(String url) { - super(url); - setExtension(".json"); + super(url, "/{Z}/{X}/{Y}.json"); } @Override diff --git a/vtm-web/src/org/oscim/tiling/source/JsonTileDataSource.java b/vtm-web/src/org/oscim/tiling/source/JsonTileDataSource.java index f4b257e0f..35511ecc5 100644 --- a/vtm-web/src/org/oscim/tiling/source/JsonTileDataSource.java +++ b/vtm-web/src/org/oscim/tiling/source/JsonTileDataSource.java @@ -41,8 +41,6 @@ public class JsonTileDataSource implements ITileDataSource { protected final GeoJsonTileDecoder mTileDecoder; protected final UrlTileSource mTileSource; - private final byte[] mRequestBuffer = new byte[1024]; - public JsonTileDataSource(GeoJsonTileSource tileSource) { mTileSource = tileSource; mTileDecoder = new GeoJsonTileDecoder(tileSource); @@ -61,10 +59,8 @@ public void query(MapTile tile, ITileDataSink sink) { mSink = sink; try { - int pos = mTileSource.formatTilePath(tile, mRequestBuffer, 0); - String url = mTileSource.getUrl() - + (new String(mRequestBuffer, 0, pos)); + + mTileSource.formatTilePath(tile); doGet(url); } catch (Exception e) { From 7305dc844514277438a6ea445afca618de600276 Mon Sep 17 00:00:00 2001 From: Chuck Greb Date: Thu, 3 Apr 2014 16:33:40 -0400 Subject: [PATCH 12/12] Fix compile error due to jeo API update --- vtm-jeo/src/org/oscim/theme/carto/RenderTheme.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vtm-jeo/src/org/oscim/theme/carto/RenderTheme.java b/vtm-jeo/src/org/oscim/theme/carto/RenderTheme.java index 5fb4ea01d..d9a647ebe 100644 --- a/vtm-jeo/src/org/oscim/theme/carto/RenderTheme.java +++ b/vtm-jeo/src/org/oscim/theme/carto/RenderTheme.java @@ -93,7 +93,7 @@ public RenderTheme() { } // get map background - RuleList rules = mStyle.getRules().selectByName("Map", false); + RuleList rules = mStyle.getRules().selectByName("Map", false, false); if (!rules.isEmpty()) { Rule rule = rules.collapse(); RGB bgColor = rule.color(null, BACKGROUND_COLOR, null);