From 25b1ba83ec685126a026edbd86ef2fec2b0caf2e Mon Sep 17 00:00:00 2001 From: david-binda Date: Thu, 5 Nov 2015 18:40:51 +0100 Subject: [PATCH] Load config.js only on Optimizely Config screen Loading config.js on all admin screens causes that tooltips are enabled on all of them and it can lead to some unwanted visual bugs. Eg.: https://wordpress.org/support/topic/annoying-popup-in-edit-screen --- optimizely.php | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/optimizely.php b/optimizely.php index b5f662e..c545cbf 100644 --- a/optimizely.php +++ b/optimizely.php @@ -45,6 +45,9 @@ * Enqueues Optimizely scripts required by the admin dashboard. */ function optimizely_enqueue_scripts() { + + $screen = get_current_screen(); + // Core scripts wp_enqueue_script( 'jquery' ); wp_enqueue_script( 'underscore' ); @@ -56,7 +59,12 @@ function optimizely_enqueue_scripts() { wp_enqueue_script( 'optimizely_api', plugins_url( 'optimizely.js', __FILE__ ), array( 'jquery' ) ); wp_enqueue_script( 'optimizely_editor', plugins_url( 'edit.js', __FILE__ ), array( 'jquery' ) ); wp_localize_script( 'optimizely_editor', 'wpAjaxUrl', admin_url( 'admin-ajax.php' ) ); - wp_enqueue_script( 'optimizely_config', plugins_url( 'config.js', __FILE__ ), array( 'jquery' ) ); + + //load config.js on optimizely config screen only + if ( null !== $screen && true === isset( $screen->id ) && 'toplevel_page_optimizely-config' === $screen->id ) { + wp_enqueue_script( 'optimizely_config', plugins_url( 'config.js', __FILE__ ), array( 'jquery' ) ); + } + wp_enqueue_script( 'optimizely_results', plugins_url( 'results.js', __FILE__ ), array( 'jquery', 'jquery-ui-core', 'jquery-ui-tabs','jquery-ui-progressbar','jquery-ui-tooltip', 'underscore' ) ); wp_localize_script( 'optimizely_editor', 'optimizelySettings', array( 'token' => get_option( 'optimizely_token' ), @@ -108,4 +116,4 @@ function optimizely_can_create_experiments() { return get_option( 'optimizely_token', false ); } -?> \ No newline at end of file +?>