[BUG] Lint reports an error

[hannesa2]

I guess you don't run lint during the pull request pipeline, otherwise you would see during

./gradlew :owncloudApp:lintDebug

this

              Lint found 1 errors, 847 warnings. First failure:

/Users/hannes/git/owncloud-android/owncloudApp/src/main/java/com/owncloud/android/extensions/FragmentExt.kt:89: Error: Wrong usage of repeatOnLifecycle from ManageAccountsDialogFragment.onStart. [RepeatOnLifecycleWrongUsage from androidx.lifecycle]
repeatOnLifecycle(lifecycleState) {
^

 Explanation for issues of type "RepeatOnLifecycleWrongUsage":
 The repeatOnLifecycle APIs should be used when the View is created,        
         that is in the onCreate lifecycle method for Activities, or
 onViewCreated in                 case you're using Fragments.

 Vendor: Android Open Source Project
 Identifier: androidx.lifecycle
 Feedback: https://issuetracker.google.com/issues/new?component=413132

[jesmrec]

About the warnings, we are working in adding an static code analyzer to the CI system. We hope it'll be ready soon to help to avoid/fix such amount of warnings.

Will take a look to the error.

Thanks for reporting

[hannesa2]

I guess you still don't run ./gradlew lint in your CI
On recent master 3caa33f , there are still issues

[jesmrec]

i executed lint locally and my result was green, but anyway, you are right. We are moving our pipelines from BitRise to GitHub Actions, and the lint part is missing there. Another workflow for lint could be a good idea. We'll take this as a nice improvement to do, or, if you'd like to contribute on that you know you are welcome 🥇

[hannesa2]

We are moving our pipelines from BitRise to GitHub Actions

Finally after 5 years ! #2816
This was one reason why I reduced my affords here to a minimum

[jesmrec]

well, lint was integrated and runing on bitrise, as well as the other jobs running on CI. Now everything running in GA... not five years but i can understand your disappointment.