fix: fix the incorrect file retrieval method to obtain files from S3 #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor file reading logic to use Storage provider and pathlib for file path handling. Signed-off-by: Shirasawa <764798966@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor file reading logic to use Storage provider and pathlib for file path handling.
Currently, using S3 as file storage prevents files from being retrieved. For example, when generating images using the Gemini 3 Image Pro model, no image context information will be available.
Therefore, I modified the code to follow the same logic as the
/v1/files/{file-id}/contentAPI:https://github.com/open-webui/open-webui/blob/main/backend/open_webui/routers/files.py#L559