remove p_mode param from ensure_flow_compiled, auto-detect via is_local()

Author: jumski

pkgs/core/schemas/0100_function_ensure_flow_compiled.sql

@@ -1,10 +1,9 @@
 -- Ensure a flow is compiled in the database
--- Handles both development (auto-recompile) and production (fail on mismatch) modes
+-- Auto-detects environment via is_local(): local -> auto-recompile, production -> fail on mismatch
 -- Returns: { status: 'compiled' | 'verified' | 'recompiled' | 'mismatch', differences: text[] }
 create or replace function pgflow.ensure_flow_compiled(
   p_flow_slug text,
-  p_shape jsonb,
-  p_mode text default 'production'  -- 'development' | 'production'
+  p_shape jsonb
 )
 returns jsonb
 language plpgsql
@@ -16,6 +15,7 @@ DECLARE
   v_flow_exists boolean;
   v_db_shape jsonb;
   v_differences text[];
+  v_is_local boolean;
 BEGIN
   -- Generate lock key from flow_slug (deterministic hash)
   v_lock_key := hashtext(p_flow_slug);
@@ -28,7 +28,7 @@ BEGIN
   SELECT EXISTS(SELECT 1 FROM pgflow.flows AS flow WHERE flow.flow_slug = p_flow_slug)
   INTO v_flow_exists;
 
-  -- 2. If flow missing: compile (both modes)
+  -- 2. If flow missing: compile (both environments)
   IF NOT v_flow_exists THEN
     PERFORM pgflow._create_flow_from_shape(p_flow_slug, p_shape);
     RETURN jsonb_build_object('status', 'compiled', 'differences', '[]'::jsonb);
@@ -45,14 +45,16 @@ BEGIN
     RETURN jsonb_build_object('status', 'verified', 'differences', '[]'::jsonb);
   END IF;
 
-  -- 6. Shapes differ - handle by mode
-  IF p_mode = 'development' THEN
-    -- Recompile in dev mode: full deletion + fresh compile
+  -- 6. Shapes differ - auto-detect environment via is_local()
+  v_is_local := pgflow.is_local();
+
+  IF v_is_local THEN
+    -- Recompile in local/dev: full deletion + fresh compile
     PERFORM pgflow.delete_flow_and_data(p_flow_slug);
     PERFORM pgflow._create_flow_from_shape(p_flow_slug, p_shape);
     RETURN jsonb_build_object('status', 'recompiled', 'differences', to_jsonb(v_differences));
   ELSE
-    -- Fail in production mode
+    -- Fail in production
     RETURN jsonb_build_object('status', 'mismatch', 'differences', to_jsonb(v_differences));
   END IF;
 END;

pkgs/core/src/database-types.ts

@@ -449,7 +449,7 @@ export type Database = {
         Returns: undefined
       }
       ensure_flow_compiled: {
-        Args: { p_flow_slug: string; p_mode?: string; p_shape: Json }
+        Args: { p_flow_slug: string; p_shape: Json }
         Returns: Json
       }
       fail_task: {

pkgs/core/supabase/migrations/20251204121149_pgflow_temp_ensure_flow_compiled_auto_detect.sql

@@ -0,0 +1,53 @@
+-- Create "ensure_flow_compiled" function
+CREATE FUNCTION "pgflow"."ensure_flow_compiled" ("p_flow_slug" text, "p_shape" jsonb) RETURNS jsonb LANGUAGE plpgsql SET "search_path" = '' AS $$
+DECLARE
+  v_lock_key int;
+  v_flow_exists boolean;
+  v_db_shape jsonb;
+  v_differences text[];
+  v_is_local boolean;
+BEGIN
+  -- Generate lock key from flow_slug (deterministic hash)
+  v_lock_key := hashtext(p_flow_slug);
+
+  -- Acquire transaction-level advisory lock
+  -- Serializes concurrent compilation attempts for same flow
+  PERFORM pg_advisory_xact_lock(1, v_lock_key);
+
+  -- 1. Check if flow exists
+  SELECT EXISTS(SELECT 1 FROM pgflow.flows AS flow WHERE flow.flow_slug = p_flow_slug)
+  INTO v_flow_exists;
+
+  -- 2. If flow missing: compile (both environments)
+  IF NOT v_flow_exists THEN
+    PERFORM pgflow._create_flow_from_shape(p_flow_slug, p_shape);
+    RETURN jsonb_build_object('status', 'compiled', 'differences', '[]'::jsonb);
+  END IF;
+
+  -- 3. Get current shape from DB
+  v_db_shape := pgflow._get_flow_shape(p_flow_slug);
+
+  -- 4. Compare shapes
+  v_differences := pgflow._compare_flow_shapes(p_shape, v_db_shape);
+
+  -- 5. If shapes match: return verified
+  IF array_length(v_differences, 1) IS NULL THEN
+    RETURN jsonb_build_object('status', 'verified', 'differences', '[]'::jsonb);
+  END IF;
+
+  -- 6. Shapes differ - auto-detect environment via is_local()
+  v_is_local := pgflow.is_local();
+
+  IF v_is_local THEN
+    -- Recompile in local/dev: full deletion + fresh compile
+    PERFORM pgflow.delete_flow_and_data(p_flow_slug);
+    PERFORM pgflow._create_flow_from_shape(p_flow_slug, p_shape);
+    RETURN jsonb_build_object('status', 'recompiled', 'differences', to_jsonb(v_differences));
+  ELSE
+    -- Fail in production
+    RETURN jsonb_build_object('status', 'mismatch', 'differences', to_jsonb(v_differences));
+  END IF;
+END;
+$$;
+-- Drop "ensure_flow_compiled" function
+DROP FUNCTION "pgflow"."ensure_flow_compiled" (text, jsonb, text);

pkgs/core/supabase/migrations/atlas.sum

@@ -1,4 +1,4 @@
-h1:RyA/4WAtZP28l0qVRPF/DF2ly/POIsQa6ZTCzP/f/NA=
+h1:yxd4cxxBB1FQxy4di5uP35UlrYaVGt4psR4ds/CblpQ=
 20250429164909_pgflow_initial.sql h1:I3n/tQIg5Q5nLg7RDoU3BzqHvFVjmumQxVNbXTPG15s=
 20250517072017_pgflow_fix_poll_for_tasks_to_use_separate_statement_for_polling.sql h1:wTuXuwMxVniCr3ONCpodpVWJcHktoQZIbqMZ3sUHKMY=
 20250609105135_pgflow_add_start_tasks_and_started_status.sql h1:ggGanW4Wyt8Kv6TWjnZ00/qVb3sm+/eFVDjGfT8qyPg=
@@ -17,3 +17,4 @@ h1:RyA/4WAtZP28l0qVRPF/DF2ly/POIsQa6ZTCzP/f/NA=
 20251130164844_pgflow_temp_options_in_shape.sql h1:lbMDdu15QiBElTsvl7g0dI7flvyjngK9g68VDnCE0S0=
 20251201105311_pgflow_temp_advisory_lock_for_compilation.sql h1:OmRtiaPYjPuq9P87Px2PH06gdKhHZ0Ro6GfjjS0G+Rs=
 20251204115929_pgflow_temp_is_local.sql h1:pjOFO6k8FCmbxp6S7U3fPImsqW81WwdLwq/UZK74BG4=
+20251204121149_pgflow_temp_ensure_flow_compiled_auto_detect.sql h1:TM+Pge1hNJmE//Chz9LkQGOFKSvsMYW/sU9R9g47GZY=

pkgs/core/supabase/tests/ensure_flow_compiled/auto_recompiles_when_local.test.sql

@@ -0,0 +1,44 @@
+begin;
+select plan(3);
+select pgflow_tests.reset_db();
+
+-- Setup: Simulate local environment
+select set_config('app.settings.jwt_secret', 'super-secret-jwt-token-with-at-least-32-characters-long', true);
+
+-- Setup: Create flow with different shape
+select pgflow.create_flow('local_flow');
+select pgflow.add_step('local_flow', 'old_step');
+
+-- Test: Different shape should auto-recompile when is_local()=true (no p_mode param)
+select is(
+  (
+    select result->>'status'
+    from pgflow.ensure_flow_compiled(
+      'local_flow',
+      '{
+        "steps": [
+          {"slug": "new_step", "stepType": "single", "dependencies": []}
+        ]
+      }'::jsonb
+    ) as result
+  ),
+  'recompiled',
+  'Should auto-recompile when is_local()=true'
+);
+
+-- Verify old step is gone
+select is(
+  (select count(*)::int from pgflow.steps where flow_slug = 'local_flow' and step_slug = 'old_step'),
+  0,
+  'Old step should be deleted'
+);
+
+-- Verify new step exists
+select is(
+  (select count(*)::int from pgflow.steps where flow_slug = 'local_flow' and step_slug = 'new_step'),
+  1,
+  'New step should be created'
+);
+
+select finish();
+rollback;

pkgs/core/supabase/tests/ensure_flow_compiled/fails_on_production_mismatch.test.sql renamed to pkgs/core/supabase/tests/ensure_flow_compiled/fails_mismatch_when_not_local.test.sql

@@ -2,48 +2,49 @@ begin;
 select plan(3);
 select pgflow_tests.reset_db();
 
+-- Setup: Simulate production environment (not local)
+select set_config('app.settings.jwt_secret', 'production-jwt-secret-that-differs-from-local', true);
+
 -- Setup: Create flow with different shape
-select pgflow.create_flow('prod_flow');
-select pgflow.add_step('prod_flow', 'old_step');
+select pgflow.create_flow('prod_flow_auto');
+select pgflow.add_step('prod_flow_auto', 'old_step');
 
--- Test: Different shape in production mode should return mismatch
+-- Test: Different shape should return mismatch when is_local()=false (no p_mode param)
 select is(
   (
     select result->>'status'
     from pgflow.ensure_flow_compiled(
-      'prod_flow',
+      'prod_flow_auto',
       '{
         "steps": [
           {"slug": "new_step", "stepType": "single", "dependencies": []}
         ]
-      }'::jsonb,
-      'production'
+      }'::jsonb
     ) as result
   ),
   'mismatch',
-  'Should return mismatch status in production mode'
+  'Should return mismatch status when is_local()=false'
 );
 
 -- Verify differences are returned
 select ok(
   (
     select jsonb_array_length(result->'differences') > 0
     from pgflow.ensure_flow_compiled(
-      'prod_flow',
+      'prod_flow_auto',
       '{
         "steps": [
           {"slug": "new_step", "stepType": "single", "dependencies": []}
         ]
-      }'::jsonb,
-      'production'
+      }'::jsonb
     ) as result
   ),
   'Should return differences for production mismatch'
 );
 
 -- Verify database was NOT modified
 select is(
-  (select step_slug from pgflow.steps where flow_slug = 'prod_flow'),
+  (select step_slug from pgflow.steps where flow_slug = 'prod_flow_auto'),
   'old_step',
   'Database should not be modified on production mismatch'
 );