Skip to content

About the style name prefix in the ToImportedIconProvider icon names #291

@plantec

Description

@plantec

a mail from @Ducasse in the bloc mailing list:
could we avoid to have round_spatialaudio
I would prefer to get less _ as possible in method selector.

my answer:
Regarding round_spatialaudio, it is from the set of svg icons source.
Is is generated code and I prefer keep it like that for the icons.
It keeps track of the name of the style directory where the icon was stored.

after thinking more:
ToImportedIconProvider subclasses are normally generated classes from a source file.
Regarding SVG, the icon directory with all icon files is in a style directory.
Style/Icons

For now, icon files are imported as a class method of a ToImportedIconProvider.
The name of the method reflects the directory organization with the style prefix and the the original file name separated with a underscore bar ''.
While the use of '
' is possible here, it denotes a modeling issue.
Since each style has it own dedicated classe (ToIconRoundStyle for the round style), why not add the generated icon methods in a style subclass ?
This means that we would have a ToMaterialDesignIconRoundStyle.

What do you think @Ducasse @tesonep @tinchodias

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is neededquestionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions