From 072c0cba6e75f74560d8d9c9e1d56e1db997ca7f Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 1 Jan 2026 17:33:08 +0000 Subject: [PATCH 1/2] docs: fix grammatical errors in README - Replace "by permitting to add" with "by allowing you to add" - Clarify config file search sentence for better readability - Fix word order in "If is present a baseline file" - Add missing "to" in "we want protect our domain" (2 occurrences) --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 882dc41a..6bba557f 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ # Introduction -PHPArkitect helps you to keep your PHP codebase coherent and solid, by permitting to add some architectural constraint check to your workflow. +PHPArkitect helps you to keep your PHP codebase coherent and solid, by allowing you to add architectural constraint checks to your workflow. You can express the constraint that you want to enforce, in simple and readable PHP code, for example: ```php @@ -51,7 +51,7 @@ To use this tool you need to launch a command via Bash: phparkitect check ``` -With this command `phparkitect` will search all rules in the root of your project the default config file called `phparkitect.php`. +With this command `phparkitect` will search for the default config file called `phparkitect.php` in the root of your project. You can also specify your configuration file using `--config` option like this: ``` @@ -77,7 +77,7 @@ phparkitect check --generate-baseline=my-baseline.json It will produce a json file with the current list of violations. -If is present a baseline file with the default name will be used automatically. +If a baseline file with the default name is present, it will be used automatically. To use a different baseline file, run the `check` command with the `use-baseline` parameter as follows: @@ -139,7 +139,7 @@ return static function (Config $config): void { $rules[] = Rule::allClasses() ->that(new ResideInOneOfTheseNamespaces('App\Domain')) ->should(new NotHaveDependencyOutsideNamespace('App\Domain')) - ->because('we want protect our domain'); + ->because('we want to protect our domain'); $config ->add($mvcClassSet, ...$rules); @@ -369,7 +369,7 @@ You can add multiple parameters, the violation will happen when one of them matc $rules[] = Rule::allClasses() ->that(new ResideInOneOfTheseNamespaces('App\Domain')) ->should(new NotHaveDependencyOutsideNamespace('App\Domain', ['Ramsey\Uuid'], true)) - ->because('we want protect our domain except for Ramsey\Uuid'); + ->because('we want to protect our domain except for Ramsey\Uuid'); ``` ### Not have a name matching a pattern From 16669de053c94d92e12dbfe3338306d54ff50f87 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 1 Jan 2026 17:35:29 +0000 Subject: [PATCH 2/2] docs: fix code block formatting issues MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Move explanatory text outside code blocks for Extend rule - Move explanatory text outside code blocks for NotExtend rule - Format notes as italic text for better visual distinction - Fix grammar: "match" → "matches" in NotExtend note --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 6bba557f..79f31b46 100644 --- a/README.md +++ b/README.md @@ -195,10 +195,10 @@ $rules[] = Rule::allClasses() ->that(new ResideInOneOfTheseNamespaces('App\Controller')) ->should(new Extend('App\Controller\AbstractController')) ->because('we want to be sure that all controllers extend AbstractController'); - -You can add multiple parameters, the violation will happen when none of them match ``` +*Note: You can add multiple parameters; the violation will happen when none of them match.* + ### Has an attribute (requires PHP >= 8.0) ```php @@ -359,10 +359,10 @@ $rules[] = Rule::allClasses() ->that(new ResideInOneOfTheseNamespaces('App\Controller\Admin')) ->should(new NotExtend('App\Controller\AbstractController')) ->because('we want to be sure that all admin controllers not extend AbstractController for security reasons'); - -You can add multiple parameters, the violation will happen when one of them match ``` +*Note: You can add multiple parameters; the violation will happen when one of them matches.* + ### Don't have dependency outside a namespace ```php