Skip to content

Commit fe22ccf

Browse files
author
Lars Janssen
committed
Moved delete SNS tests into 22_SameNameSiblings
1 parent 79bf632 commit fe22ccf

File tree

3 files changed

+5
-28
lines changed

3 files changed

+5
-28
lines changed

tests/10_Writing/DeleteMethodsSnsTest.php renamed to tests/22_SameNameSiblings/DeleteMethodsTest.php

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,19 @@
11
<?php
2-
namespace PHPCR\Tests\Writing;
2+
namespace PHPCR\Tests\SameNameSiblings;
33

44
require_once(__DIR__ . '/../../inc/BaseCase.php');
55

66
/**
77
* Test for deleting same name siblings (SNS).
88
*
9-
* The fixtures needed for this test can only be loaded for transports that
10-
* support SNS.
11-
*
129
* At this point, we are only testing for the ability to delete existing SNS;
1310
* creating or manipulating them is not supported.
1411
*/
15-
class DeleteMethodsSnsTest extends \PHPCR\Test\BaseCase
12+
class DeleteMethodsTest extends \PHPCR\Test\BaseCase
1613
{
17-
static public function setupBeforeClass($fixtures = '10_Writing/delete')
14+
static public function setupBeforeClass($fixtures = '22_SameNameSiblings/delete')
1815
{
19-
parent::setupBeforeClass(null);
20-
21-
if (! self::includeSameNameSiblings()) {
22-
self::markTestSkipped();
23-
}
24-
25-
self::$staticSharedFixture['ie']->import('10_Writing/deletesns');
16+
parent::setupBeforeClass($fixtures);
2617
}
2718

2819
public function setUp()
@@ -145,20 +136,6 @@ public function testDeleteManyNodes()
145136
}
146137
}
147138

148-
/**
149-
* Determine if tests for deleting same name siblings should be included
150-
*
151-
* @return bool
152-
*/
153-
private static function includeSameNameSiblings()
154-
{
155-
// Special case; we should really use getRepository()->getDescriptor()
156-
// but in this case we don't support creating same name siblings,
157-
// but need to be able to delete them.
158-
$session = self::$staticSharedFixture['session'];
159-
return 'Jackalope\Transport\Jackrabbit\Client' == get_class($session->getTransport());
160-
}
161-
162139
/**
163140
* @param $session
164141
* @param $parentPath

tests/22_SameNameSiblings/TODO

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Create tests...
1+
Create more tests...
22

0 commit comments

Comments
 (0)