From e4a09078cf98e8448259fae81a61139d034b7e6b Mon Sep 17 00:00:00 2001 From: bart-pywalker <65918941+bart-pywalker@users.noreply.github.com> Date: Mon, 28 Nov 2022 10:49:03 -0500 Subject: [PATCH 1/7] Update extract-attributes.js added playsinline attribute into supportedAttributes array --- components/dash-html-components/scripts/extract-attributes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/dash-html-components/scripts/extract-attributes.js b/components/dash-html-components/scripts/extract-attributes.js index 37490cc77f..331ffc95e0 100644 --- a/components/dash-html-components/scripts/extract-attributes.js +++ b/components/dash-html-components/scripts/extract-attributes.js @@ -24,7 +24,7 @@ const supportedAttributes = ['accept', 'accessKey', 'action', 'allow', 'keyParams', 'keyType', 'kind', 'label', 'lang', 'list', 'loop', 'low', 'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media', 'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name', -'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'poster', +'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'playsinline', 'poster', 'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required', 'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling', 'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src', From c7313e253549f5276954e7963aa8e84066de7c8b Mon Sep 17 00:00:00 2001 From: bart-pywalker <65918941+bart-pywalker@users.noreply.github.com> Date: Mon, 28 Nov 2022 11:10:45 -0500 Subject: [PATCH 2/7] Add playsinline into attributes.json dash-html-components/scripts/data/attributes.json --- .../dash-html-components/scripts/data/attributes.json | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/components/dash-html-components/scripts/data/attributes.json b/components/dash-html-components/scripts/data/attributes.json index 309b1b354f..45a77821c4 100644 --- a/components/dash-html-components/scripts/data/attributes.json +++ b/components/dash-html-components/scripts/data/attributes.json @@ -526,6 +526,12 @@ ], "description": "Provides a hint to the user of what can be entered in the field." }, + "playsinline": { + "elements": [ + "video" + ], + "description": "Sets the video to be played inline / within the element's playback area." + }, "poster": { "elements": [ "video" @@ -1143,4 +1149,4 @@ "value" ] } -} \ No newline at end of file +} From 69863b601451e3f528398be815ccde5bd221343d Mon Sep 17 00:00:00 2001 From: bart-pywalker <65918941+bart-pywalker@users.noreply.github.com> Date: Mon, 28 Nov 2022 11:20:07 -0500 Subject: [PATCH 3/7] added playsinline into generate-components.js added playsinline into BOOLEAN_PROPERTIES array in dash-html-components/scripts/generate-components.js --- components/dash-html-components/scripts/generate-components.js | 1 + 1 file changed, 1 insertion(+) diff --git a/components/dash-html-components/scripts/generate-components.js b/components/dash-html-components/scripts/generate-components.js index 13532f88b8..f8d1dae163 100644 --- a/components/dash-html-components/scripts/generate-components.js +++ b/components/dash-html-components/scripts/generate-components.js @@ -32,6 +32,7 @@ const BOOLEAN_PROPERTIES = [ 'noModule', 'noValidate', 'open', + 'playsinline', 'readonly', 'required', 'reversed', From 81415fb21524d661e899e36a69e389d32b522b40 Mon Sep 17 00:00:00 2001 From: bart-pywalker <65918941+bart-pywalker@users.noreply.github.com> Date: Wed, 14 Dec 2022 21:25:15 -0500 Subject: [PATCH 4/7] changed playsinline to playsInline adjusted playsinline to playsInline to reflect React camelcasing --- components/dash-html-components/scripts/generate-components.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/dash-html-components/scripts/generate-components.js b/components/dash-html-components/scripts/generate-components.js index f8d1dae163..80573ea125 100644 --- a/components/dash-html-components/scripts/generate-components.js +++ b/components/dash-html-components/scripts/generate-components.js @@ -32,7 +32,7 @@ const BOOLEAN_PROPERTIES = [ 'noModule', 'noValidate', 'open', - 'playsinline', + 'playsInline', 'readonly', 'required', 'reversed', From eba0b3f60665eb9045e9fafc47b36b214f571c43 Mon Sep 17 00:00:00 2001 From: bart-pywalker <65918941+bart-pywalker@users.noreply.github.com> Date: Wed, 14 Dec 2022 21:30:26 -0500 Subject: [PATCH 5/7] update attribues.json file for playsInline --- components/dash-html-components/scripts/data/attributes.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/dash-html-components/scripts/data/attributes.json b/components/dash-html-components/scripts/data/attributes.json index 45a77821c4..b24ef3fa32 100644 --- a/components/dash-html-components/scripts/data/attributes.json +++ b/components/dash-html-components/scripts/data/attributes.json @@ -526,7 +526,7 @@ ], "description": "Provides a hint to the user of what can be entered in the field." }, - "playsinline": { + "playsInline": { "elements": [ "video" ], From 86b573782c5388f858fc521257baec224491d874 Mon Sep 17 00:00:00 2001 From: bart-pywalker <65918941+bart-pywalker@users.noreply.github.com> Date: Wed, 14 Dec 2022 21:32:26 -0500 Subject: [PATCH 6/7] extract-attributes.js - playsInline camelcasing --- components/dash-html-components/scripts/extract-attributes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/dash-html-components/scripts/extract-attributes.js b/components/dash-html-components/scripts/extract-attributes.js index 331ffc95e0..9e387b3b65 100644 --- a/components/dash-html-components/scripts/extract-attributes.js +++ b/components/dash-html-components/scripts/extract-attributes.js @@ -24,7 +24,7 @@ const supportedAttributes = ['accept', 'accessKey', 'action', 'allow', 'keyParams', 'keyType', 'kind', 'label', 'lang', 'list', 'loop', 'low', 'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media', 'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name', -'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'playsinline', 'poster', +'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'playsInline', 'poster', 'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required', 'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling', 'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src', From cb958d1a2ed42bc2b8d20bcb7656235d5c1ca031 Mon Sep 17 00:00:00 2001 From: bart-pywalker <65918941+bart-pywalker@users.noreply.github.com> Date: Wed, 4 Jan 2023 09:03:02 -0500 Subject: [PATCH 7/7] removed changes to attributes.json this is an generated file ... restoring it to it's original state --- .../dash-html-components/scripts/data/attributes.json | 6 ------ 1 file changed, 6 deletions(-) diff --git a/components/dash-html-components/scripts/data/attributes.json b/components/dash-html-components/scripts/data/attributes.json index b24ef3fa32..42c8f87da7 100644 --- a/components/dash-html-components/scripts/data/attributes.json +++ b/components/dash-html-components/scripts/data/attributes.json @@ -526,12 +526,6 @@ ], "description": "Provides a hint to the user of what can be entered in the field." }, - "playsInline": { - "elements": [ - "video" - ], - "description": "Sets the video to be played inline / within the element's playback area." - }, "poster": { "elements": [ "video"