-
Notifications
You must be signed in to change notification settings - Fork 26
feat: add metadata to bundle uploads #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nealrichardson
wants to merge
7
commits into
main
Choose a base branch
from
bundle-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nealrichardson
commented
Dec 4, 2025
nealrichardson
commented
Dec 4, 2025
3ef15a8 to
fb4f734
Compare
fb4f734 to
95d35e9
Compare
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Allow adding metadata to bundle uploads, a (potentially) new API in Connect.
If you're in a git checkout, it will attempt to set the
source,source_repo,source_branch, andsource_commitfields that are already known to Connect. It is also possible to provide additional key-value pairs, or override the values of those fields, using the--metadataCLI flag. Or suppress metadata detection with--no-metadata.If you're on an older version of Connect that does not support this API, or specify the
--no-metadataflag, the old bundle upload API will be used, and nothing is changed.Type of Change
Approach
I've lost the exact prompt now, but I basically gave Claude the API docs for the new API, described the behavior I wanted (see "Intent"), and let it go. It seemed to get it in one shot, except that rsconnect-python was not using the v1 bundle APIs yet. So I stashed that, did #731, and then reapplied the changes.
Automated Tests
There are mocked tests for what looks like all of the new behavior, but we don't have general integration tests in this repo that would test this behavior. The extended nightly integration tests in the connect repo should exercise the new APIs, if not confirm that they're sending the correct information.
I manually against a local Connect server with the new API and confirmed both that I could add extra fields with
--metadataand that git commit info is picked up from the environment.Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.