From e10aa8169f07991f44ccabd149f4335b34ed035e Mon Sep 17 00:00:00 2001 From: jnsiemer Date: Thu, 11 Dec 2025 12:59:47 +0000 Subject: [PATCH 1/2] Quick fix of doc comment --- src/utils/sample/binomial.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utils/sample/binomial.rs b/src/utils/sample/binomial.rs index 93efe8f8..7c96669b 100644 --- a/src/utils/sample/binomial.rs +++ b/src/utils/sample/binomial.rs @@ -30,7 +30,7 @@ use rand_distr::{Binomial, Distribution}; /// let sample = bin_sampler.sample(); /// /// assert!(0 <= sample); -/// assert!(sample < n); +/// assert!(sample <= n); /// ``` pub struct BinomialSampler { distr: Binomial, @@ -105,7 +105,7 @@ impl BinomialSampler { /// let sample = bin_sampler.sample(); /// /// assert!(0 <= sample); - /// assert!(sample < n); + /// assert!(sample <= n); /// ``` pub fn sample(&mut self) -> Z { Z::from(self.distr.sample(&mut self.rng)) From b1ad93f282485432c45286d5dd988f04f02f5d05 Mon Sep 17 00:00:00 2001 From: jnsiemer Date: Thu, 11 Dec 2025 18:32:10 +0000 Subject: [PATCH 2/2] Revise doc-comment --- src/utils/sample/binomial.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/utils/sample/binomial.rs b/src/utils/sample/binomial.rs index 7c96669b..e857de4c 100644 --- a/src/utils/sample/binomial.rs +++ b/src/utils/sample/binomial.rs @@ -91,8 +91,7 @@ impl BinomialSampler { Ok(Self { distr, rng }) } - /// Computes a uniformly chosen [`Z`] sample in `[0, interval_size)` - /// using rejection sampling that accepts samples with probability at least 1/2. + /// Samples a [`Z`] according to the binomial distribution `Bin(n, p)`. /// /// # Examples /// ```