Reduce memory allocations in message parsing hot paths #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurre
force-pushed
the
main
branch
2 times, most recently
from
6cd5003 to
39ad3e0
Compare
Benchmark results: - GetString: 20.7→9.4 ns/op (-54%), 24→8 B/op (-67%), 2→1 allocs (-50%) - ParseMessage: 318→321 ns/op (0 B/op, 0 allocs, no regression) - RepeatingGroupRead: 1198 ns/op, 870 B/op, 11 allocs Changes: - GetString: removed FIXString intermediate allocation - RepeatingGroup: cached tag ordering closure (was N allocations per Read) - ConditionallyRequiredFieldMissing: strconv.Itoa vs fmt.Sprintf - GetTime: fixed recursive RLock by using getBytesNoLock - Removed unused getFieldNoLock function 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Reduce memory allocations through: - sync.Pool for Message objects (AcquireMessage/ReleaseMessage) - Pre-allocate FieldMap.tagLookup map with capacity 16 - Pre-allocate RepeatingGroup.groups slice using expectedGroupSize Benchmark comparison (new message per parse): | Benchmark | Time | Memory | Allocs | |----------------------|-------------|-------------|----------| | ParseMessageNew | 1670 ns/op | 5336 B/op | 28 | | ParseMessagePool | 482 ns/op | 176 B/op | 2 | Improvements with pool: - 3.5x faster - 30x less memory per operation - 14x fewer allocations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allocation optimizations:
Hot path improvements:
Benchmark Results