Skip to content

Check associated type where-clauses for lifetimes #149714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
reddevilmidzy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check associated type where-clauses for lifetimes #149714

reddevilmidzy wants to merge 1 commit into from
+67 −1

Conversation

@reddevilmidzy
Copy link
Contributor

@reddevilmidzy reddevilmidzy commented Dec 6, 2025 •
edited
Loading

resolves: #148627
resolves: #149233

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fmease fmease assigned fmease and unassigned nnethercote Dec 7, 2025
fmease
fmease requested changes Dec 7, 2025
View reviewed changes
Copy link
Member

@fmease fmease left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

View changes since this review

compiler/rustc_ast_passes/src/feature_gate.rs
Copy link
Member

@fmease fmease Dec 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating what visit_generics is doing & manually visiting the after_where_clause, could you instead please

  1. remove the existing visit_generics implementation entirely (the entire fn)
  2. remove check_ty_alias_after_where_clause again
  3. instead implement visit_where_predicate_kind so it's calling check_late_bound_lifetime_defs with the expected arguments, followed by visit::walk_where_predicate_kind(…) to continue the recursion
    • this should work because we automatically visit both before & after where clauses (due to derive(Walkable)) (and if that doesn't happen, then that's a bug)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease requested changes

Assignees

@fmease fmease

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE: path with Res::Err but no error emitted ICE Res::Err but no error emitted

4 participants

@reddevilmidzy @rustbot @fmease @nnethercote