implement Step for PhysAddr and PhysFrame
#567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll have very similar harnesses for PhysAddr, so let's use a module to avoid name conflicts.
The Step implementation uses unsafe. The kani harnesses should give us some confidence that the unsafe code is correct.
These harnesses check that PhysFrame behaves like PhysAddr with the steps scaled by the page size.
josephlr
reviewed
Nov 20, 2025
Contributor
josephlr
left a comment
josephlr
left a comment
There was a problem hiding this comment.
I did a quick look, while nothing seems wrong, there are two things I want to take a closer look at:
- How the Physical Address stuff interacts with the memory encryption bit. If the C-bit isn't bit 52 (it's usually bit 47), could a valid physical address underflow into an invalid physical address?
- how the
kani::proofstuff works.
Member
Author
No because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Stepimplementations forPhysAddrandPhysFrame. This PR also adds kani harnesses to prove the correctness of these new implementations and the unsafe code within them.Closes #212