-
Notifications
You must be signed in to change notification settings - Fork 88
Add article for day 7 #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: website
Are you sure you want to change the base?
Conversation
|
let's merge on Tuesday, to give time for review feedback (which I've requested on Discord) |
merlinorg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I nit-picked the word "splitted" to "split" because it's irregular and that's the standard form.
docs/2025/puzzles/day07.md
Outdated
| Parsing the input is quite straighforward. First let's define a type alias so that we have a meaningful type name for our value: | ||
|
|
||
| ```scala | ||
| type Manifold = Array[Array[Char]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pedantically this could remain Array[String] because String supports zipWithIndex, indexOf etc, just like a collection of chars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah... Actually I think it crossed my mind at some point, should I update it or do we leave it like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it 😁.
| - [Solution](https://github.com/rmarbeck/advent2025/blob/main/day07/src/main/scala/Solution.scala) by [Raphaël Marbeck](https://github.com/rmarbeck) | ||
|
|
||
| - [Solution](https://github.com/Philippus/adventofcode/blob/main/src/main/scala/adventofcode2025/Day07.scala) by [Philippus Baalman](https://github.com/philippus) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you meant to remove these lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not mean to... Must have been a bad copy paste on my part. Sorry and thanks for noticing it.
I restored them.
Co-authored-by: Merlin Hughes <merlin@merlin.org>
|
@merlinorg thanks for the corrections and suggestions! |
No description provided.