From d15a5a311000356e8e6512a918a2cad0bc315261 Mon Sep 17 00:00:00 2001
From: Roman Dobosz <rdobosz@redhat.com>
Date: Wed, 19 Nov 2025 13:48:21 +0100
Subject: [PATCH] Fixing GH actions.

---
 .ansible-lint                      |  3 +++
 .github/workflows/ansible-lint.yml | 24 +++++++++++++++++-------
 playbooks/install_stack.yaml       |  2 +-
 playbooks/prepare_stack.yaml       |  1 +
 4 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/.ansible-lint b/.ansible-lint
index 708c6ea..a208cbe 100644
--- a/.ansible-lint
+++ b/.ansible-lint
@@ -27,3 +27,6 @@ mock_roles:
 skip_list:
   # Variables names from within roles should use role_name_ as a prefix
   - var-naming[no-role-prefix]
+  - key-order[play]
+  - fqcn[action-core]
+  - var-naming[no-reserved]
diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml
index fd8b251..6336b62 100644
--- a/.github/workflows/ansible-lint.yml
+++ b/.github/workflows/ansible-lint.yml
@@ -1,15 +1,25 @@
 name: Ansible Lint
+
 on:
   pull_request:
     paths:
-    - playbooks/**.yaml
+      - playbooks/**.yaml
 jobs:
   build:
     runs-on: ubuntu-latest
+
     steps:
-    - name: checks-out the repository under $GITHUB_WORKSPACE
-      uses: actions/checkout@v3
-    - name: run ansible-lint
-      uses: ansible/ansible-lint-action@main
-      with:
-        path: playbooks/
+
+      - name: checks-out the repository under $GITHUB_WORKSPACE
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Install ansible-lint
+        run: python3 -m pip install ansible-dev-tools --user
+
+      - name: Install dependency
+        run: ansible-galaxy collection install ansible.posix community.general tripleo.operator containers.podman community.crypto
+
+      - name: Run lint
+        run: ansible-lint playbooks/**
diff --git a/playbooks/install_stack.yaml b/playbooks/install_stack.yaml
index 636ab20..aa0e241 100644
--- a/playbooks/install_stack.yaml
+++ b/playbooks/install_stack.yaml
@@ -535,7 +535,7 @@
         - sriov_interface is defined or dpdk_interface is defined or kernel_args is defined
       block:
         - name: Reboot the node
-          become_user: root
+          become: true
           ansible.builtin.reboot:
         - name: Pause for 2 minutes to let all containers to start and OpenStack to be ready
           ansible.builtin.pause:
diff --git a/playbooks/prepare_stack.yaml b/playbooks/prepare_stack.yaml
index e5a05e4..8f47bb7 100644
--- a/playbooks/prepare_stack.yaml
+++ b/playbooks/prepare_stack.yaml
@@ -1,4 +1,5 @@
 ---
+
 - hosts: standalone
   become: true
   become_user: stack