Using functions in the fields list

[justincy]

Something like this is possible:

Solicit.Repsponse.ok(conn, struct, [:one, :another, something: Module.function/1])

But it's weird that the full struct is passed in to that function:

solicit/lib/response.ex

Lines 542 to 543 in fdbaeeb

	{field, generate} when is_function(generate, 1) ->
	{field, generate.(struct)}

Should we instead be passing Map.get(struct, field)? Seems more appropriate.

[matthew-kerle]

Something like this is possible:

Solicit.Repsponse.ok(conn, struct, [:one, :another, something: Module.function/1])

But it's weird that the full struct is passed in to that function:

solicit/lib/response.ex

Lines 542 to 543 in fdbaeeb

	{field, generate} when is_function(generate, 1) ->
	{field, generate.(struct)}

Should we instead be passing Map.get(struct, field)? Seems more appropriate.

It seems like there's a good probability for one field like "status", you might need other fields from the strict to derive or calculate beyond just a single field.

[bjyoungblood]

I could see the case for adding an additional clause like this:

{field, generate} when is_function(generate, 2) ->
  {field, generate.(struct, field)}

In usage, that'd let you reuse the same function for multiple fields in cases like:

def get(conn, _params) do
  Solicit.Response.ok(conn, struct, [:foo, inserted_at: &truncate_datetime/2, updated_at: &truncate_datetime/2])
end

defp truncate_datetime(map, field) do
  case Map.get(map, field) do
    %DateTime{} = v -> DateTime.truncate(v, :millisecond)
    nil -> nil
  end
end