-
Notifications
You must be signed in to change notification settings - Fork 472
♿(frontend) improve editor a11y and brand/neutral contrast #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
af3194e to
6c511e1
Compare
|
Size Change: -2 B (0%) Total Size: 4.11 MB
|
AntoLC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot update directly this file (https://github.com/suitenumerique/docs/blob/6c511e1854757d333a4ea6bf5f05b5cff00ea7c9/src/frontend/apps/impress/src/cunningham/cunningham-tokens.css), it is auto-generated.
To generate it we do yarn build-theme:
| "build-theme": "cunningham -g css,ts -o src/cunningham --utility-classes && yarn prettier && yarn stylelint --fix", |
If you want to modify colors it should be here:
https://github.com/suitenumerique/docs/blob/main/src/frontend/apps/impress/cunningham.ts
If the color modification is about the dsfr theme, the colors update chould be in the ui-kit repository, if it is in the generic theme, it should be on our side:
docs/src/frontend/apps/impress/cunningham.ts
Lines 87 to 93 in 8036f16
| const genericTheme = { | |
| generic: { | |
| globals: { | |
| colors: { | |
| 'brand-050': '#EEF1FA', | |
| 'brand-100': '#DDE2F5', | |
| 'brand-150': '#CED3F1', |
adjust brand and neutral tertiary text colors to meet WCAG contrast ratio Signed-off-by: Cyril <c.gromoff@gmail.com>
6c511e1 to
81a1ea1
Compare
Thanks again for the detailed explanation, Just to confirm the approach on our side for the generic theme: For the DSFR theme in the |
Purpose
Fix AXE accessibility issues related to color contrast
@rl-83 I made a small adjusment to pass WCAG AA requirements, do you think it is ok for you ? the ratio was a bit low
Proposal
--c--globals--colors--brand-500→--c--globals--colors--brand-550--c--globals--colors--gray-500→--c--globals--colors--gray-550