✨(auth) Add slient login #1690
Open
✨(auth) Add slient login #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-robin
force-pushed
the
silent-login
branch
from
fc97595 to
2d5d759
Compare
Currently users already logged in to the SSO have to click on the login button again to be connected. This extra step should not be necessary. This commit uses the "silent=true" parameter to the login endpoint to avoid the extra step.
arnaud-robin
force-pushed
the
silent-login
branch
from
2d5d759 to
9b6703f
Compare
Member
Author
|
This implementation is heavily copied from @lebaudantoine work. |
|
Size Change: +1.61 kB (+0.04%) Total Size: 4.12 MB
|
arnaud-robin
added
the
FAST
Collaborator
|
@AntoLC fyi |
AntoLC
reviewed
Dec 5, 2025
Collaborator
AntoLC
left a comment
AntoLC
left a comment
There was a problem hiding this comment.
We need a test to assert that it is working, the tests don't seem happy btw.
If I understand correctly, even if our cookies is dead (frontend side), if the SSO recognize the user it will not prompt the user again, isn't it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now users already logged in to the SSO have to click on the login button again to be connected. This extra step should not be necessary and some partners have complained
Proposed solution
This PR uses the "silent=true" parameter in the lasuite login endpoint to avoid showing the IdP login screen if user already have an active session.