Commit 90eaef6
committed
bug #6270 [Validator] Add warning for null and blank values for minimum string length (theofidry)
This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #6270).
Discussion
----------
[Validator] Add warning for null and blank values for minimum string length
| Q | A |
| --- | --- |
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | symfony/symfony#16157 |
Follow up of #5789.
Summary of what has been said: even though the [Length#min](http://symfony.com/doc/current/reference/constraints/Length.html#min) option is well detailed and mention the case of `null` values, the introduction is still confusing:
> Validates that a given string length is between some minimum and maximum value.
As a result, a warning note is being added under this introduction.
I've listed all the Symfony constraints. For some this `null` and `blank` values specificity has already been mentioned. I've noted the ones on which this warning does not apply, but for some I am not sure so it needs to be doubled checked.
- Basic Contraints
- [x] NotBlank: already done
- [x] Blank: already done
- [x] NotNull: already done
- [x] IsNull: already done
- ~~[ ] IsTrue~~
- ~~[ ] IsFalse~~
- ~~[ ] Type~~
- String Constraints¶
- ~~[ ] Email~~
- [x] Length
- ~~[ ] Url~~
- ~~[ ] Regex~~
- ~~[ ] Ip~~
- ~~[ ] Uuid~~
- Number Constraints¶
- [ ] Range
- Comparison Constraints¶
- ~~[ ] EqualTo~~
- ~~[ ] NotEqualTo~~
- ~~[ ] IdenticalTo~~
- ~~[ ] NotIdenticalTo~~
- [ ] LessThan: needed? How `@Assert\LessThan("-18 years")` behaves if the value is null?
- [ ] LessThanOrEqual: same as `LessThan`
- [ ] GreaterThan: same as `LessThan`
- [ ] GreaterThanOrEqual: same as `LessThan`
- Date Constraints¶
- ~~[ ] Date~~
- ~~[ ] DateTime~~
- ~~[ ] Time~~
- Collection Constraints¶
- ~~[ ] Choice~~
- ~~[ ] Collection~~
- ~~[ ] Count~~
- ~~[ ] UniqueEntity~~
- ~~[ ] Language~~
- ~~[ ] Locale~~
- ~~[ ] Country~~
- File Constraints¶
- ~~[ ] File~~
- ~~[ ] Image~~
- Financial and other Number Constraints¶
- ~~[ ] Bic~~
- ~~[ ] CardScheme~~
- ~~[ ] Currency~~
- ~~[ ] Luhn~~
- ~~[ ] Iban~~
- ~~[ ] Isbn~~
- ~~[ ] Issn~~
- Other Constraints¶
- ~~[ ] Callback~~
- ~~[ ] Expression~~
- ~~[ ] All~~
- ~~[ ] UserPassword~~
- ~~[ ] Valid~~
Commits
-------
38d44c2 [Validator] Add warning for null and blank values for minimum string length1 file changed
+6
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
6 | 10 | | |
7 | 11 | | |
8 | 12 | | |
| |||
0 commit comments