-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Labels
refactoringThings that have to be refactoredThings that have to be refactored
Description
PAC-96 introduced a new option which allows overriding already existing images. In order to stay backwards compabile, new methods and attributes were made private in
src/Subjects/FileUploadTrait.php. These should be either public or protected.
Additionally, a new constant OVERRIDE_IMAGES should be introduced in the ConfigurationKeys utility class for components using the new option:
- techdivision/import-attribute
- src/Subjects/OptionSubject.php
- src/Utils/ConfigurationKeys.php
- techdivision/import-category
- src/Subjects/BunchSubject.php
- src/Utils/ConfigurationKeys.php
- techdivision/import-product
- src/Subjects/BunchSubject.php
- src/Utils/ConfigurationKeys.php
The necessary changes are highligted as "TODOs" in the corresponding files.
Metadata
Metadata
Assignees
Labels
refactoringThings that have to be refactoredThings that have to be refactored