Completely refreshing a timeline with an active benchmark leads to a crash when the benchmark name has a space

[sgraf812]

In our project, we have benchmark names such as "Parser-Test 1", with a space in the benchmark name.

When I hit Ctrl+F5 (or close the tab and re-open it with Ctrl+Shift+T) in the timeline view for such a benchmark, the benchmark becomes unselected and I get notified via E-Mail that there was a crash in codespeed here:

codespeed/codespeed/views.py

Line 257 in 7341205

if data['ben'] == 'grid':

, apparently because there's no entry for 'ben' in the data dictionary. The request URL doesn't seem to contain the 'ben' entry at all.

If I remove the space from the name, e.g. "Parser-Test", everything works as advertised.

[tobami]

It would be best to move to using ids in the url parameters to avoid this kind of problems.