Copy the 4 ukfed policy files into the testbed

[philsmart]

To begin the transition to using the upstream policy files in ukf-meta directly, we will copy the four developed policy files into the testbed. These files are from ukf-meta:

• policy-edugain.xml
• policy-publication.xml
• policy-registered-entity.xml
• policy-registration.xml

The policy files should be added to the all/classes directory, alongside the default-validator* XML files. I believe the policy files will require modifications to include the same imports as the default-validator.xml file, such as the import for the context-beans.xml file. Additionally, each policy file will need an id and a description. The id is particularly important, as we will reference it whenever we refer to individual validators in our tests. The IDs can be the name of the policies, perhaps without the policy prefix.

Once those are in place, we can try referencing them from the application-default.properties to see if they load.

[iay]

It's probably worth trying to keep the profile files as similar as possible to the way they appear in the deployment, and putting anything you can that they require into a file which then includes them. This will make it easier to pull them in directly from the deployment in the longer term.

It's probably also worth reviewing the diagram on https://github.com/iay/md-validator as it seems to me that most of the beans required by the different profiles can be shared by being incorporated into one of the shared contexts, and not imported into each validator context.

[philsmart]

Yes, keeping the files are vanilla as possible is a good idea. I'll look into both those suggestions.

[philsmart]

I've included a <policy>-validator.xml file alongside each policy file. This validator file contains the ID, description, imports, and the pipeline stage, pipeline, that references the policy composite stage bean from its corresponding policy file.

[philsmart]

Some of the beans have property placeholders for external files and directories. For example, the directory to the compromised keys listing in compromised.ukf: ${blocklists.dir}/compromised-keys.txt. We've avoided using this check in the current testbed, but it is included in edugain policy.

We could include properties like this by adding a properties file as a property placeholder in each of the validator XML files: <context:property-placeholder location="classpath:policy-edugain.properties" />. I can not see they come from elsewhere, but I might have totally missed it.

[philsmart]

Concentrating on the eduGAIN profile as a first step, that approach with the properties file works. I'll keep that for now, and we can review later.

[philsmart]

I am going to copy over required files from ukf-data for the time being (e.g, members.xml), I just want to see the extent of the work. I'll need to come back to think about how we incorporate (or not) ukf-data.

[philsmart]

I will also copy over the JAXB implementation JARS.