Skip to content

Conversation

@tukwila
Copy link
Contributor

@tukwila tukwila commented Dec 2, 2025

Summary

Details

  • [ ]

fix: #492

Test Plan

Related Issues

  • Resolves #

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
@tukwila
Copy link
Contributor Author

tukwila commented Dec 2, 2025

@markurtz please help to check, thks.

@markurtz
Copy link
Collaborator

markurtz commented Dec 5, 2025

@tukwila one minor NIT on it is that we should move the import to the top of the module. The other side, though, is given the complexity and the numer of assumptions we have to make on what the user is passing in, I think we should likely drop support for the SQL table and remove it entirey for now. If a user wants to use that, they can still construct the dataset first and pass it in through the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DBFileDatasetDeserializer TypeError: Dataset.from_sql() missing 1 required positional argument: 'sql'

2 participants